Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable https by default #9550

Merged
merged 1 commit into from
Nov 4, 2019
Merged

Conversation

ninjadq
Copy link
Member

@ninjadq ninjadq commented Oct 23, 2019

  1. Umcomment https related configs
  2. Remove the https prepare related thing in ci

Signed-off-by: DQ dengq@vmware.com

@coveralls
Copy link

coveralls commented Oct 23, 2019

Pull Request Test Coverage Report for Build 16519

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 4 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.03%) to 66.255%

Files with Coverage Reduction New Missed Lines %
src/jobservice/api/server.go 2 95.92%
src/jobservice/period/basic_scheduler.go 2 70.49%
Totals Coverage Status
Change from base Build 16516: 0.03%
Covered Lines: 24272
Relevant Lines: 36634

💛 - Coveralls

@ninjadq ninjadq force-pushed the enable_https_by_default branch 2 times, most recently from 23a8a48 to b5dbe14 Compare October 30, 2019 09:35
1. Umcomment https related configs
2. Remove the https prepare related thing in ci

Signed-off-by: DQ <dengq@vmware.com>
Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wy65701436 wy65701436 merged commit 3f39b0b into goharbor:master Nov 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants