Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug of UI; #9730

Merged
merged 1 commit into from
Nov 4, 2019
Merged

Conversation

jwangyangls
Copy link
Contributor

@jwangyangls jwangyangls commented Nov 4, 2019

1.One of the request is cancelled when trying to do the multiple deletion for tags(fix #9720 #9714 )
image
after modify:
image

2.when using other languages, switch languages, English button has default border
image
after modify:
image

Signed-off-by: Yogi_Wang yawang@vmware.com

Copy link
Contributor

@zhoumeina zhoumeina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coveralls
Copy link

coveralls commented Nov 4, 2019

Pull Request Test Coverage Report for Build 16569

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 66.304%

Totals Coverage Status
Change from base Build 16564: 0.0%
Covered Lines: 24362
Relevant Lines: 36743

💛 - Coveralls

1.One of the request is cancelled when trying to do the multiple deletion for tags
2.when using other languages, switch languages, English button has default border
Signed-off-by: Yogi_Wang <yawang@vmware.com>
Copy link
Contributor

@AllForNothing AllForNothing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jwangyangls jwangyangls merged commit 184ba9f into goharbor:master Nov 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

One of the request is cancelled when trying to do the multiple deletion for tags
4 participants