Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default merge strategy for markup.goldmark.extensions.typographer and others #11355

Open
salim-b opened this issue Aug 11, 2023 · 1 comment
Assignees
Milestone

Comments

@salim-b
Copy link
Contributor

salim-b commented Aug 11, 2023

Since #10620 has been resolved, we can set per-language markup config like

[languages.de.markup.goldmark.extensions.typographer]
leftDoubleQuote = '«'   # default “
rightDoubleQuote = '»'  # default ”

Now one mustn't forget to also set

[languages.de.markup]
_merge = 'deep'

since otherwise other options from regular markup config aren't respected for lang de and Hugo falls back to built-in defaults.

Would be nice if _merge = 'deep' could become the default for languages.<LangPrefix>.markup.

@bep bep removed the NeedsTriage label Aug 12, 2023
@bep bep added this to the v0.118.0 milestone Aug 12, 2023
@bep
Copy link
Member

bep commented Aug 12, 2023

Would be nice if _merge = 'deep' could become the default for languages..markup.

I don't think we can/want to do it so coarse grained. I would hate for a random theme to set markup.goldmark.renderer.unsafe=true e.g.

I think what we need to do is:

  • Make sure that all settings below languages gets the same default merge strategy as they would have gotten on the top level (I'm not sure that is the case today)
  • Revise the current defaults and open up markup.goldmark.extensions.typographer and possibly others.

@bep bep added Enhancement and removed Proposal labels Aug 12, 2023
@bep bep changed the title Change default merge strategy for languages.<LangPrefix>.markup to deep Change default merge strategy for markup.goldmark.extensions.typographer and others etc. Aug 12, 2023
@bep bep self-assigned this Aug 12, 2023
@salim-b salim-b changed the title Change default merge strategy for markup.goldmark.extensions.typographer and others etc. Change default merge strategy for markup.goldmark.extensions.typographer and others Aug 12, 2023
@bep bep modified the milestones: v0.118.0, v0.119.0 Sep 15, 2023
@bep bep modified the milestones: v0.119.0, v0.120.0 Oct 4, 2023
@bep bep modified the milestones: v0.120.0, v0.121.0 Oct 31, 2023
@bep bep modified the milestones: v0.121.0, v0.122.0 Dec 6, 2023
@bep bep modified the milestones: v0.122.0, v0.123.0, v0.124.0 Jan 27, 2024
@bep bep modified the milestones: v0.124.0, v0.125.0 Mar 4, 2024
@bep bep modified the milestones: v0.125.0, v0.137.0, v0.138.0 Oct 23, 2024
@bep bep added this to the v0.139.0 milestone Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants