Fix data race in templating code #7507
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should fix the "concurrent map access" crashes reported in gohugoio#7293. Changes: * Use existing "muFunc" lock in Template.AddParseTree and Template.Lookup * Call Template.Lookup from outside instead of accessing map directly The additional lock doesn't appear to impact performance noticeably.
|
Thanks for this; but this needs to be fixed upstream (https://github.com/golang/go) -- we have a (hopefully) temporary fork with some controlled patches to the execution of templates, but I'm not opening up that fence to bug fixes in the parser etc., that I don't have any plans to maintain here. |
This was referenced Jul 23, 2020
|
Sorry for the delay on this. If this will not be fixed for Go 1.16 then we need to fix it on our side. |
|
It's not your fault, I didn't have time in the past weeks to look further into the discussion on the Go side. |
|
Superseded by 9650e56 |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix the concurrent map access crashes reported in #7293.
Changes:
The additional lock doesn't appear to impact performance noticeably.