Add theme hugo-theme-relearn #14
Conversation
|
✔️ Deploy Preview for hugothemes ready! 🔨 Explore the source changes: d57571c 🔍 Inspect the deploy log: https://app.netlify.com/sites/hugothemes/deploys/60e20a7d8bee800007ac469d 😎 Browse the preview: https://deploy-preview-14--hugothemes.netlify.app |
|
Is anything wrong about my PR? Just wondering because all other open PRs but mine are merged? Just for information: I forked the original Learn theme, because it's stalled for quite some while. |
|
Hello Sören, thanks for your theme submission. Relearn seems to be a fork of the learn theme that is also listed on www.themes.gohugo.io. Hugo users could find both themes but will not immediately able to understand how they relate to each other, i.e. that relearn is a fork. It might also be of interest for them to know what changes or additions have been made in your fork. This kind of information should be visible in the README of your theme. |
|
Thank for the information. I'll provide some additions in the README in the next few days. |
As always, software projects take longer than intended. Because this theme is meant to be a drop-in replacement of the original learn theme, it visually looks very similar by intent. I've added a short "motivation" statement in the README.md and prominently in a notice box on the front page of the theme's documentation, giving the main reason behind my fork. This box even shows up in the screenshots, that will be shown in the theme repo. Additionally I've added a lot of links to the original theme - even in the Version 2.0.0 of my fork was released a few hours ago. It alone fixes 27 issues, many of them are long outstanding in the original learn theme. And that's only for the latest release - not counted the issues fixed in previous (smaller) releases. Don't get me wrong: Forking the theme wasn't a light decision and loomed in me for almost a year. I've made proposals on how to revive the development multiple times but with no success. Even other users are discussing the theme's state to no success (see matcornic/hugo-theme-learn#502, matcornic/hugo-theme-learn#505). I've made PRs, code reviews and giving help in the issues comments with almost no reaction from the maintainers. Although the theme repo mentions the last update to be on 2021-03-31, the commit history shows a different picture. I am more than willing to dump my fork if the development of the original learn theme comes up to speed again. But for the moment the learn theme is dead. I hope the information given, help to make a positive decision for including my fork in the theme repo. |
|
@bep, @digitalcraftsman : Given my previous explanation, is there at least a chance to get listed in the theme gallery? Is there something else I can do to get listed? |
|
Thank you Sören for adding the all the information to your theme's documentation. I appreciate that you continue the development of the learn theme. Pardon my delayed response and review. Everything looks fine now. Your theme should appear soon on www.themes.gohugo.io. |
No description provided.