Skip to content
This repository has been archived by the owner on Aug 23, 2019. It is now read-only.

Update to lodash 4.5.1 #12

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update to lodash 4.5.1 #12

wants to merge 1 commit into from

Conversation

petercyr
Copy link

Lodash is wayyy out of date here and its causing issues with deep comparison of relatively simple objects.

  • Update lodash to 4.5.1
  • Fix two references to include which is now includes.
  • Fix output of objects on failed deepEquals
npm test

> goinstant-assert@1.1.3 test /Users/pcyr/repos/assert
> mocha test/test.js


․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․

109 tests complete (23 ms)

@colinmacdonald

…cludes. Fix output of objects on failed deepEquals
@colinmacdonald
Copy link

if the tests pass LGTM

@petercyr
Copy link
Author

@bendecoste can you take a look? looks like you committed the last changes for this, so just want to make sure you agree with this so it doesn't break everything i'm not aware of.

@jeffandersen
Copy link

👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants