Improve test coverage for cmd package #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajatprabha
added a commit
to ajatprabha/darkroom
that referenced
this pull request
Jul 19, 2020
* add test for runServerCmd * update NewDependencies test tp return err if dependencies are not valid * return err if dependencies are not valid * create new cobra command with SetupSignalHandler * refactor server Start with SetupSignalHandler for testable code * add test for root cmd * refactor root cmd * add test for setupSignalHandler * implement SetupSignalHandler * add newRunCmdWithOpts to rootCmd with SetupSignalHandler * add test for LifeCycleHook * refactor if-else statement * remove signals package and import it from sigs.k8s.io/controller-runtime * add version cmd to root * remove TDD cycle comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.