Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix missing millisecond unit for hystrix timeout #77

Merged
merged 1 commit into from
May 15, 2020
Merged

fix missing millisecond unit for hystrix timeout #77

merged 1 commit into from
May 15, 2020

Conversation

flof
Copy link
Contributor

@flof flof commented Feb 18, 2020

Fixes #76

@coveralls
Copy link

coveralls commented Feb 18, 2020 •
edited
Loading

Coverage Status

Coverage remained the same at 87.234% when pulling 77a91a4 on flof:master into 93314ae on gojek:master.

unmultimedio
unmultimedio approved these changes Feb 19, 2020
View reviewed changes
Copy link

@unmultimedio unmultimedio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I recently noticed this in one of our projects 👍

@rShetty rShetty merged commit 28627ee into gojek:master May 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@unmultimedio unmultimedio unmultimedio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Misleading example in README.md
4 participants
@flof @coveralls @unmultimedio @rShetty