Makes metrics implementation configurable #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sses "all" as metric-name now
shubhang93
reviewed
Apr 28, 2020
|
|
||
| (defn get-metrics-implementor-constructor [] | ||
| (if-let [configured-metrics-class-constructor (get-in (ziggurat-config) [:metrics :implementation])] | ||
| (let [configured-constructor-symbol (symbol configured-metrics-class-constructor) |
There was a problem hiding this comment.
looks good, I was wondering if we could instantiate the impl class by doing something like this?
https://stackoverflow.com/questions/3748559/clojure-creating-new-instance-from-string-class-name
There was a problem hiding this comment.
Hey, good suggestion, couldn't make it work. Will try it out in the next release.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces a {:ziggurat {:metrics {:constructor}}} configuration key that accepts a constructor (of a class that implements MetricsLib interface).
Renames interface fn
update-histogramtoupdate-timingas timing is the statsd metric_type.