Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

combine all config.test*edn files #223

Merged
merged 1 commit into from
May 11, 2021
Merged

combine all config.test*edn files #223

merged 1 commit into from
May 11, 2021

Conversation

macalimlim
Copy link
Contributor

combine all config.test*edn files

@macalimlim macalimlim changed the title [WIP] combine all config.test*edn files combine all config.test*edn files Apr 30, 2021
@macalimlim macalimlim force-pushed the combine-all-config-edns branch 4 times, most recently from b28457b to 7cd0c16 Compare April 30, 2021 12:18
mjayprateek
mjayprateek suggested changes May 4, 2021
View reviewed changes
project.clj Outdated Show resolved Hide resolved
Makefile Show resolved Hide resolved
@mjayprateek
Copy link
Contributor

Two additional comments:

  • we need to remove datadog and statsd specific config files too
  • we need to make testing with kafka cluster the only default for CI runs while testing with one-broker kafka can be done on developer environments. This will need a change in .gitlab-ci.yml

@macalimlim
Copy link
Contributor Author

@mjayprateek can we deprecate datadog instead? this way we could properly remove the stasd and datadog config files

@macalimlim macalimlim force-pushed the combine-all-config-edns branch 4 times, most recently from 7fe9855 to a02a8c3 Compare May 10, 2021 09:35
mjayprateek
mjayprateek reviewed May 11, 2021
View reviewed changes
bin/run_tests_in_ci.sh Outdated Show resolved Hide resolved
@mjayprateek mjayprateek merged commit 7028d0a into master May 11, 2021
@mjayprateek mjayprateek deleted the combine-all-config-edns branch February 7, 2022 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjayprateek mjayprateek mjayprateek requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@macalimlim @mjayprateek