refactor the inclusion of the actor key/value in the tags #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
macalimlim
force-pushed
the
refactor-additional-tags
branch
from
589ad26
to
e1f68ca
Compare
macalimlim
force-pushed
the
refactor-additional-tags
branch
from
43e975f
to
b47c0d2
Compare
|
I also fixed the generator in the |
|
I will be closing this because changes to the library made this PR irrelevant |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I refactored the inclusion of the actor key/value to be more testable and have more predictable behavior. I basically moved it to when the
additional-tagsis created. With this thegroupatom is not needed anymore. It is now either enforced on the test and on the precondition.An odd thing happened when I was testing this, does
(gen/string-alphanumeric)produce nil?