Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for Issue #14 #20

Merged
merged 1 commit into from
Apr 25, 2020
Merged

Fix for Issue #14 #20

merged 1 commit into from
Apr 25, 2020

Conversation

Risavk
Copy link
Contributor

@Risavk Risavk commented Apr 4, 2020

Another one.
Embedded space segment wasn't "turned off" after ':' delimiter. Delimiter was treated just like space. begin keyword too :)
Delimiter ':' is recognized properly in IsBuildingEmbeddedSpaceItem IF statement, so there is no problem.

I don't know if else of modified if statement is realy needed at all.

This one tested - works fine :)
verilog_issue#14

@Risavk
Copy link
Contributor Author

Risavk commented Apr 4, 2020

Pure GIT is somewhat difficult for me - sorry.
At work we've got TFS which is doing all work for us :)
And in pure mainframe cobol development there is no git at all... (comments in code are the best way to version changes)

@gojimmypi gojimmypi merged commit 87abdc3 into gojimmypi:development Apr 25, 2020
@gojimmypi
Copy link
Owner

@Risavk this is a great fix - thank you!

sorry for the delay in responding. VS debugging has been crazy slow these days. not sure why.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants