Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ringbuf support #35

Merged
merged 2 commits into from
Jul 20, 2023
Merged

add ringbuf support #35

merged 2 commits into from
Jul 20, 2023

Conversation

spoock1024
Copy link
Contributor

No description provided.

Copy link
Member

@cfc4n cfc4n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add some unit tests?

@cfc4n cfc4n added the enhancement New feature or request label Jul 17, 2023
@spoock1024 spoock1024 force-pushed the master branch 2 times, most recently from c5fd260 to 3fd1cfc Compare July 19, 2023 09:41
Copy link
Member

@cfc4n cfc4n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for your contribution.

unsigned int type;
unsigned int key_size;
unsigned int value_size;
unsigned int max_entries;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code format?



struct ringbuf_bpf_map_def SEC("maps/ringbuf_map") ringbuf_map = {
.type = 27,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's 27 means? used constant instead?

Copy link
Member

@cfc4n cfc4n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cfc4n cfc4n merged commit 371b1b2 into gojue:master Jul 20, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants