This repository has been archived by the owner on Dec 7, 2019. It is now read-only.
Add option to keep existing avds #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make checking for existing emulators os independant
artem-zinnatullin
approved these changes
Aug 5, 2018
| Observable | ||
| .just(Unit) | ||
| .doOnSubscribe { log("Avd ${args.emulatorName} already exists, will not be overridden.") } | ||
| } else { |
There was a problem hiding this comment.
wow. I love how this non trivial logic ended up in just couple lines of code 👍
| var useCompatEmulator: Boolean = false, | ||
|
|
||
| @Parameter( | ||
| names = ["--keep-existing-avds"], |
There was a problem hiding this comment.
Please add it to the README too
|
Please update the readme with new params, otherwise LGTM cc @yunikkk PTAL |
|
LGTM with README updates |
|
Updated README |
|
👍 @yunikkk I don't have merge permissions jfyi |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #41 (@yunikkk, @artem-zinnatullin)
When starting 4 emulators on my development machine, this change cut the boot-up time of the emulators in half (from ~55 sec down to ~25 sec). When using snapshots, it went down even further (~12 sec).