Improve code comments, including security consideration #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vuonghx
previously approved these changes
Sep 22, 2021
lggomez
requested changes
Sep 24, 2021
oxisto
requested changes
Sep 24, 2021
Co-authored-by: Christian Banse <oxisto@aybaze.com>
Co-authored-by: Christian Banse <oxisto@aybaze.com>
oxisto
approved these changes
Oct 13, 2021
mfridman
approved these changes
Oct 13, 2021
lggomez
approved these changes
Oct 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The README file includes a security notice about validating the 'alg' claim. This PR adds code comments for the
Parse()function to help present the information to users of the library.