Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using tparse for nicer CI test display #251

Merged
merged 3 commits into from
Nov 29, 2022
Merged

Using tparse for nicer CI test display #251

merged 3 commits into from
Nov 29, 2022

Conversation

oxisto
Copy link
Collaborator

@oxisto oxisto commented Oct 26, 2022

Why didn't I notice this nice tool before?

Why didn't I notice this nice tool before?
@mfridman
Copy link
Member

mfridman commented Nov 1, 2022

Hehe, we could also output to the GITHUB_STEP_SUMMARY variable (announced here).

https://github.com/mfridman/tparse/blob/main/.github/workflows/ci.yml#L32-L39

That way we see a nice summary and any failures. Can ignore the -slow 20.

Here is a sample of what that looks like (in addition to the CI logged output):

https://github.com/mfridman/tparse/actions/runs/2771562675#summary-7602716816

@oxisto
Copy link
Collaborator Author

oxisto commented Nov 2, 2022

Hehe, we could also output to the GITHUB_STEP_SUMMARY variable (announced here).

https://github.com/mfridman/tparse/blob/main/.github/workflows/ci.yml#L32-L39

That way we see a nice summary and any failures. Can ignore the -slow 20.

Here is a sample of what that looks like (in addition to the CI logged output):

https://github.com/mfridman/tparse/actions/runs/2771562675#summary-7602716816

Ah very cool! I can try to add that later.

@mfridman
Copy link
Member

mfridman commented Nov 9, 2022

I can pick this up, did you want me to commandeer this PR?

@oxisto
Copy link
Collaborator Author

oxisto commented Nov 9, 2022

I can pick this up, did you want me to commandeer this PR?

Sure, go ahead.

@mfridman
Copy link
Member

Before committing to a new /v5 api, I'd love if we could add a bit more coverage for some of the code paths. Wdyt?

No all of them, but the unhappy paths in the parser, the error contracts, etc.

CleanShot 2022-11-29 at 09 58 02@2x

@mfridman mfridman merged commit 2f0984a into main Nov 29, 2022
@mfridman mfridman deleted the using-tparse branch November 29, 2022 15:00
oxisto added a commit to moneszarrugh/jwt that referenced this pull request Feb 21, 2023
oxisto added a commit to twocs/jwt that referenced this pull request Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants