Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format code with "go fmt" #53

Merged
merged 1 commit into from
Aug 20, 2021
Merged

Format code with "go fmt" #53

merged 1 commit into from
Aug 20, 2021

Conversation

xyproto
Copy link
Contributor

@xyproto xyproto commented Aug 3, 2021

No description provided.

@lggomez
Copy link
Member

lggomez commented Aug 3, 2021

LGTM. @mfridman @oxisto

As a further pass I propose using https://github.com/mvdan/gofumpt, which is a superset of go fmt maintained by some of the folks of the go team (my guess is some of the rules eventually make into fmt, but this is the bleeding edge version)

@mfridman
Copy link
Member

mfridman commented Aug 4, 2021

LGTM.

I like gofumt, but most users are unlikely to have this enabled. E.g., if using vs code requires this setting:

"gopls": {
    "formatting.gofumpt": true
}

Were you thinking of adding a github workflow that automatically formats code after each merge to main ?

@lggomez lggomez merged commit eac9e9e into golang-jwt:main Aug 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants