Harmonising capitalisation of "token" in error strings #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfridman
reviewed
Aug 29, 2021
| @@ -61,7 +61,7 @@ func (c RegisteredClaims) Valid() error { | |||
| } | |||
|
|
|||
| if !c.VerifyIssuedAt(now, false) { | |||
| vErr.Inner = fmt.Errorf("Token used before issued") | |||
| vErr.Inner = fmt.Errorf("token used before issued") | |||
There was a problem hiding this comment.
Curious, why this PR? Are you relying on the capitilization?
I'm indifferent about this one way or the other, but I'd prefer to avoid these kinds of PRs. Closing.
Also. https://github.com/golang/go/wiki/CodeReviewComments#error-strings
There was a problem hiding this comment.
Didn't he try to remove the capitalisation? It seems that we missed this one, the other Errorf calls are also lowercased.
There was a problem hiding this comment.
Oops, diff'd it wrong. You're right, apologies @yoogoc . Thanks for your contribution. My mistake.
mfridman
approved these changes
Aug 29, 2021
oxisto
approved these changes
Aug 29, 2021
oxisto
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.