Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Report coverage on more files #2

Closed
dhui opened this issue Jan 20, 2018 · 1 comment
Closed

Report coverage on more files #2

dhui opened this issue Jan 20, 2018 · 1 comment
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@dhui
Copy link
Member

dhui commented Jan 20, 2018

The coverage profile filename specified to each test run (via test-with-flags) is re-used. e.g. The filename is not regenerated for each go test call

This may no longer be an issue in Go 1.10
@dhui
Copy link
Member Author

dhui commented Jan 20, 2018

I misread the Makefile. The coverage profile filename (specified via _$$(RAND).txt) is doing the right thing.

I'm not sure why coveralls only shows 9 files when many more files (like all the db drivers) must be covered.

@dhui dhui added the enhancement New feature or request label May 30, 2018
@dhui dhui added the help wanted Extra attention is needed label Jun 5, 2019
dhui added a commit to dhui/migrate that referenced this issue Jun 21, 2019
@dhui
Run tests so that coverage profiles don't need to be manually concate…
481bf0f 
…nated

Addresses: golang-migrate#2
@dhui dhui closed this as completed Jun 21, 2019
@dhui dhui mentioned this issue Aug 21, 2019
Closed
@agnivade agnivade mentioned this issue Feb 26, 2021
Open
FPiety0521 pushed a commit to FPiety0521/Golang-SQL that referenced this issue May 24, 2023
Run tests so that coverage profiles don't need to be manually concate…
203dbcd 
…nated

Addresses: golang-migrate/migrate#2
@jdudmesh jdudmesh mentioned this issue Aug 24, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dhui