Fix dockerfile version and deps #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhui
requested changes
May 9, 2018
Dockerfile
Outdated
| @@ -12,7 +15,7 @@ COPY source ./source | |||
| RUN go get -v ./... && \ | |||
| go get -u github.com/fsouza/fake-gcs-server/fakestorage && \ | |||
| go get -u github.com/kshvakov/clickhouse && \ | |||
| GOOS=linux GOARCH=386 go build -a -o build/migrate.linux-386 -ldflags='-X main.Version=$(VERSION)' -tags '$(DATABASE) $(SOURCE)' ./cli | |||
| GOOS=linux GOARCH=386 go build -a -o build/migrate.linux-386 -ldflags="-X main.Version=${VERSION}" -tags "$DEPS" ./cli | |||
There was a problem hiding this comment.
Drop GOARCH and GOOS since we're running inside docker and the binary doesn't need to be portable.
Also, specify the sources.
There was a problem hiding this comment.
Sources are inside DEPS variable
There was a problem hiding this comment.
Let's keep the db and source dependencies separate for easier management
Its-Alex
force-pushed
the
master
branch
2 times, most recently
from
2c02e3c
to
6fcfbd0
Compare
Signed-off-by: Alexandre MARRE <me@itsalex.fr>
dhui
approved these changes
May 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently version and dependencies doesn't work on docker image I didn't notice it so this is the fix