Add neo4j driver on params instance

[dynastymasra]

• Add neo4j driver on the instance param
• Check version constraint avoid duplicate error
• Remove unnecessary field on config struct

[coveralls]

Pull Request Test Coverage Report for Build 750

• 18 of 28 (64.29%) changed or added relevant lines in 1 file are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage decreased (-0.01%) to 53.17%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
database/neo4j/neo4j.go	18	28	64.29%

Totals
Change from base Build 748:	-0.01%
Covered Lines:	2575
Relevant Lines:	4843

---

💛 - Coveralls

[dhui]

Thanks for the PR!

Having a neo4j.Driver as a param to WithInstance() makes sense.
This also means that options that can be specified via the neo4j.Driver should be removed from Config. e.g. AuthToken and URL

I'm fine w/ this backwards incompatible change since it's pretty minor.

[dhui]

Looks like tests are failing:

    TestMigrate/neo4j:3.5: neo4j_test.go:97: database returned error [Neo.ClientError.Statement.SyntaxError]: Unknown procedure output: `name` (line 1, column 29 (offset: 28))
        "CALL db.constraints() yield name WHERE name="schema_migration_constraint_key" RETURN *"
                                     ^

[dhui]

The linter failed in tests. You need to run gofmt:

database/neo4j/neo4j.go:23: File is not `gofmt`-ed with `-s` (gofmt)

const DefaultMigrationsLabel  = "SchemaMigration"

The command "golangci-lint run" exited with 1.

Also, not sure why tests are failing for neo4j v4. Didn't see anything in the logs...
https://travis-ci.com/github/golang-migrate/migrate/jobs/319479345
--- FAIL: Test/neo4j:4.0 (84.71s)

[dynastymasra]

Also, not sure why tests are failing for neo4j v4. Didn't see anything in the logs...
https://travis-ci.com/github/golang-migrate/migrate/jobs/319479345
--- FAIL: Test/neo4j:4.0 (84.71s)

Hai @dhui
Test Neo4J fail because of by default TLS Encrypted set to true when creating new driver,
isReady function on test got an error and assume the container is not ready

[dhui]

Thanks again for the PR and for addressing all of the feedback!