Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Cassandra SSL options #386

Merged
merged 1 commit into from May 12, 2020
Merged

Update Cassandra SSL options #386

merged 1 commit into from May 12, 2020

Conversation

ghost
Copy link

@ghost ghost commented May 12, 2020

Cassandra

Problem Description

I've run into a problem where if I wanted to just pass the query parameter for sslrootcert, I would get a connection reset by peer error. This happens because when the query parameters are parsed by the Cassandra driver, their existence as a whole is verified before any configuration can take place. This is improper, the query parameters should be parsed/verified individually and have their respective SSL options set individually.

@ghost ghost changed the title update cassandra ssl options Update Cassandra SSL options May 12, 2020
@ghost ghost marked this pull request as ready for review May 12, 2020 02:40
@coveralls
Copy link

coveralls commented May 12, 2020

Pull Request Test Coverage Report for Build 763

  • 1 of 13 (7.69%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.08%) to 53.448%

Changes Missing Coverage Covered Lines Changed/Added Lines %
database/cassandra/cassandra.go 1 13 7.69%
Totals Coverage Status
Change from base Build 760: -0.08%
Covered Lines: 2612
Relevant Lines: 4887

💛 - Coveralls

@dhui dhui merged commit b88b868 into golang-migrate:master May 12, 2020
@dhui
Copy link
Member

dhui commented May 12, 2020

Thanks for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants