Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WithConnection to Postgres similar to MySQL. #659

Merged
merged 4 commits into from Feb 24, 2022
Merged

Add WithConnection to Postgres similar to MySQL. #659

merged 4 commits into from Feb 24, 2022

Conversation

AndreasKl
Copy link
Contributor

@AndreasKl AndreasKl commented Nov 29, 2021

Enable consumers to provide an existing *sql.DB with the option to close the connection without closing the underlying *sql.DB instance.

See the following thread for reference and how it was implemented for MySQL:
#578
#583

@coveralls
Copy link

@coveralls coveralls commented Nov 29, 2021

Pull Request Test Coverage Report for Build 1875336797

  • 20 of 24 (83.33%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.05%) to 57.854%

Changes Missing Coverage Covered Lines Changed/Added Lines %
database/postgres/postgres.go 20 24 83.33%
Totals Coverage Status
Change from base Build 1821224966: 0.05%
Covered Lines: 3742
Relevant Lines: 6468

💛 - Coveralls

@AndreasKl
Copy link
Contributor Author

@AndreasKl AndreasKl commented Dec 3, 2021

@dhui Hi, can I improve the PR to get the change merged?

@c0olix
Copy link

@c0olix c0olix commented Jan 3, 2022

+1 for this feature.

dhui
dhui approved these changes Feb 24, 2022
@dhui dhui merged commit 57aead3 into golang-migrate:master Feb 24, 2022
8 checks passed
@dhui
Copy link
Member

@dhui dhui commented Feb 24, 2022

Thanks for the PR and your patience!

@AndreasKl AndreasKl deleted the add-with-connection-to-postgres branch Feb 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants