-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: pin setup-gcloud gh action to v0 #271
Conversation
KaylaNguyen
commented
Dec 29, 2021
•
edited
Loading
edited
- Pin setup-gcloud gh action to v0 instead of head
- Typo fix
- qa changes equivalent of changes to master
- switch default logStream from stdout to stderr #272
- Add Go 1.16 to tested Go versions #255
- Fix header name to associate log entry & trace #263
@@ -70,7 +70,7 @@ jobs: | |||
restore-keys: | | |||
${{ runner.os }}-${{ matrix.go-version }}-go- | |||
- name: Set up Cloud SDK | |||
uses: google-github-actions/setup-gcloud@master | |||
uses: google-github-actions/setup-gcloud@v0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you help me understand why "uses" v0 only is sufficient? I'm trying to make sure we don't lose CI coverage. In other words, why not using two workflows one for v0 (like staging?) and another one for master?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
setup-gcloud github action repo is renaming their master
branch so they're suggesting to pin to v0 instead: https://github.com/google-github-actions/setup-gcloud#-notices
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see. It's an official rename. LGTM.