Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x86spec: fix header parsing #9

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

x86spec: fix header parsing #9

wants to merge 4 commits into from
+2,500 −0

Conversation

anton-kuklin
Copy link

@anton-kuklin anton-kuklin commented Jul 17, 2023 •
edited
Loading

The existing implementation of the Intel x86 doc parser matches headers by just trimming spaces. However, there are cases, when a header string takes several lines, which breaks current switch case matching, e.g. during the parsing of AMX operations. This commit fixes it by replacing \n with a whitespace in a header string.

For: golang/go#61079

@anton-kuklin
x86spec: fix header parsing
0d9feca 
The existing implementation of the Intel x86 doc parser matches headers
by just trimming spaces. However, there are cases, when a header string
takes several lines, which breaks current switch case matching, e.g.
during the parsing of AMX operations. This commit fixes it by replacing
\n with a whitespace in a header string.

For: #61079
@gopherbot
Copy link

This PR (HEAD: 0d9feca) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/arch/+/510555.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to register for Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

@gopherbot
Copy link

This PR (HEAD: 1f785a7) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/arch/+/510555.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to register for Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

@gopherbot
Copy link

Message from Anton Kuklin:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/510555.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Cherry Mui:

Patch Set 2: Run-TryBot+1

(3 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/510555.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Gopher Robot:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/510555.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Gopher Robot:

Patch Set 2: TryBot-Result+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/510555.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

This PR (HEAD: e97199f) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/arch/+/510555.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to register for Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

@gopherbot
Copy link

This PR (HEAD: 08f9014) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/arch/+/510555.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to register for Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

@gopherbot
Copy link

Message from Anton Kuklin:

Patch Set 4:

(3 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/510555.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Anton Kuklin:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/510555.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Cherry Mui:

Patch Set 2: Run-TryBot+1

(3 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/510555.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Gopher Robot:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/510555.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Gopher Robot:

Patch Set 2: TryBot-Result+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/510555.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Anton Kuklin:

Patch Set 4:

(3 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/510555.
After addressing review feedback, remember to publish your drafts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anton-kuklin @gopherbot