Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ssh: add (*Client).DialContext method #260

Closed
wants to merge 6 commits into from
Closed

ssh: add (*Client).DialContext method #260

wants to merge 6 commits into from

Conversation

ydnar
Copy link
Contributor

@ydnar ydnar commented Jun 21, 2023 •
edited
Loading

This change adds DialContext to ssh.Client, which opens a TCP-IP
connection tunneled over the SSH connection. This is useful for
proxying network connections, e.g. setting
(net/http.Transport).DialContext.

Fixes golang/go#20288.

@gopherbot
Copy link
Contributor

This PR (HEAD: 24a796c) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/crypto/+/504735 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Han-Wen Nienhuys:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/504735.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Randy Reddig:

Patch Set 1:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/504735.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Randy Reddig:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/504735.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Han-Wen Nienhuys:

Patch Set 1:

(7 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/504735.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

This PR (HEAD: 584f08b) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/crypto/+/504735 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

This PR (HEAD: 3a0b93d) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/crypto/+/504735 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Randy Reddig:

Patch Set 2:

(6 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/504735.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Randy Reddig:

Patch Set 3:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/504735.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Randy Reddig:

Patch Set 3:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/504735.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Han-Wen Nienhuys:

Patch Set 3:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/504735.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

This PR (HEAD: 29823f3) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/crypto/+/504735 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Randy Reddig:

Patch Set 4:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/504735.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Han-Wen Nienhuys:

Patch Set 4:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/504735.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

This PR (HEAD: ce9c179) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/crypto/+/504735 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Randy Reddig:

Patch Set 5:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/504735.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Han-Wen Nienhuys:

Patch Set 5:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/504735.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Han-Wen Nienhuys:

Patch Set 5: Code-Review+1 Commit-Queue+1 Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/504735.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 5:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/504735.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Randy Reddig:

Patch Set 5:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/504735.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Han-Wen Nienhuys:

Patch Set 5:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/504735.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

This PR (HEAD: 3176984) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/crypto/+/504735 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Go LUCI:

Patch Set 6:

CV cannot start a Run for hanwen@google.com because the user is neither the CL owner nor a committer.

Please don’t reply on this GitHub thread. Visit golang.org/cl/504735.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Han-Wen Nienhuys:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/504735.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Randy Reddig:

Patch Set 1:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/504735.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Randy Reddig:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/504735.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Han-Wen Nienhuys:

Patch Set 1:

(7 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/504735.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Randy Reddig:

Patch Set 2:

(6 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/504735.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Randy Reddig:

Patch Set 3:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/504735.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Randy Reddig:

Patch Set 3:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/504735.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Han-Wen Nienhuys:

Patch Set 3:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/504735.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Randy Reddig:

Patch Set 4:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/504735.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Han-Wen Nienhuys:

Patch Set 4:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/504735.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Randy Reddig:

Patch Set 5:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/504735.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Han-Wen Nienhuys:

Patch Set 5:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/504735.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Han-Wen Nienhuys:

Patch Set 5: Code-Review+1 Commit-Queue+1 Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/504735.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 5:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/504735.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Randy Reddig:

Patch Set 5:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/504735.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Han-Wen Nienhuys:

Patch Set 5:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/504735.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 5: TryBot-Result+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/504735.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Han-Wen Nienhuys:

Patch Set 6: Code-Review+2 Commit-Queue+1 Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/504735.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Dmitri Shuralyov:

Patch Set 6: Hold+1

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/504735.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Dmitri Shuralyov:

Patch Set 6: Code-Review+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/504735.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Han-Wen Nienhuys:

Patch Set 6: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/504735.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Go LUCI:

Patch Set 6:

CV cannot start a Run for hanwen@google.com because the user is neither the CL owner nor a committer.

Please don’t reply on this GitHub thread. Visit golang.org/cl/504735.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Nicola Murino:

Patch Set 6: Code-Review+1 Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/504735.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Nicola Murino:

Patch Set 6: Code-Review+2

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/504735.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request Nov 27, 2023
@ydnar @gopherbot
ssh: add (*Client).DialContext method
b2d7c26 
This change adds DialContext to ssh.Client, which opens a TCP-IP
connection tunneled over the SSH connection. This is useful for
proxying network connections, e.g. setting
(net/http.Transport).DialContext.

Fixes golang/go#20288.

Change-Id: I110494c00962424ea803065535ebe2209364ac27
GitHub-Last-Rev: 3176984
GitHub-Pull-Request: #260
Reviewed-on: https://go-review.googlesource.com/c/crypto/+/504735
Run-TryBot: Nicola Murino <nicola.murino@gmail.com>
Run-TryBot: Han-Wen Nienhuys <hanwen@google.com>
Auto-Submit: Nicola Murino <nicola.murino@gmail.com>
Reviewed-by: Han-Wen Nienhuys <hanwen@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Nicola Murino <nicola.murino@gmail.com>
Commit-Queue: Nicola Murino <nicola.murino@gmail.com>
@gopherbot
Copy link
Contributor

This PR is being closed because golang.org/cl/504735 has been merged.

@gopherbot gopherbot closed this Nov 27, 2023
HouseK added a commit to HouseK/crypto that referenced this pull request Dec 4, 2023
@HouseK
ssh: add (*Client).DialContext method
40517c7 
This change adds DialContext to ssh.Client, which opens a TCP-IP
connection tunneled over the SSH connection. This is useful for
proxying network connections, e.g. setting
(net/http.Transport).DialContext.

Fixes golang/go#20288.

Change-Id: I110494c00962424ea803065535ebe2209364ac27
GitHub-Last-Rev: 3176984
GitHub-Pull-Request: golang#260
Reviewed-on: https://go-review.googlesource.com/c/crypto/+/504735
Run-TryBot: Nicola Murino <nicola.murino@gmail.com>
Run-TryBot: Han-Wen Nienhuys <hanwen@google.com>
Auto-Submit: Nicola Murino <nicola.murino@gmail.com>
Reviewed-by: Han-Wen Nienhuys <hanwen@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Nicola Murino <nicola.murino@gmail.com>
Commit-Queue: Nicola Murino <nicola.murino@gmail.com>
@ydnar ydnar deleted the dialcontext branch December 17, 2023 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

x/crypto/ssh: provide Client.DialContext method
2 participants
@ydnar @gopherbot