This repository has been archived by the owner on Sep 9, 2020. It is now read-only.
allow dirs that don't contain go files (fix #1306) #1398
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Any feedback on how this should be behave is welcome. This is to fix #1306. The case I've hit is with repos with directories of just protobufs.
What version of Go (go version) and dep (git describe --tags) are you using??
Go 1.9.2 and dep on master.
What dep command did you run?
What did you expect to see?
With the repo vendored into vendor/.
What did you see instead?
With this PR, the expected behavior is what you get.