-
Notifications
You must be signed in to change notification settings - Fork 1k
Conversation
i'd actually love to have this, like, really soon. i might not block on it for the immediately-upcoming release (because it's just not necessary, we get the same benefit after the fact), but the big thing here is being able to provide people a one-liner that will get them a version of dep that includes version info. |
@sdboyer cool, I'll clean up a bit of it tonight (fix the changelog conflict, add a bit to the README.md) |
Ok I've updated the README.md to include info about the script. and fixed other issues. |
CHANGELOG.md
Outdated
* Add support for importing from [glock](https://github.com/robfig/glock) based projects. ([#1422](https://github.com/golang/dep/pull/1422) | ||
* Add support for importing from [govendor](https://github.com/kardianos/govendor) based projects. ([#815](https://github.com/golang/dep/pull/815) | ||
* Allow override of cache directory location using environment variable `DEPCACHEDIR`. ([#1234](https://github.com/golang/dep/pull/1234)) | ||
* Add support for template output in `dep status`. ([#1389](https://github.com/golang/dep/pull/1389) | ||
* Each element in a multi-item TOML array is output on its own line. ([#1461](https://github.com/golang/dep/pull/1461) | ||
* Added `install.sh` script. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please follow the pattern of the other CHANGELOG entries - include a link to this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
my bad! done 👍
Travis build seems to be hanging on the osx build.. queued for hours. |
Restarted hung Travis. |
CHANGELOG.md
Outdated
* Add support for importing from [glock](https://github.com/robfig/glock) based projects. ([#1422](https://github.com/golang/dep/pull/1422) | ||
* Add support for importing from [govendor](https://github.com/kardianos/govendor) based projects. ([#815](https://github.com/golang/dep/pull/815) | ||
* Allow override of cache directory location using environment variable `DEPCACHEDIR`. ([#1234](https://github.com/golang/dep/pull/1234)) | ||
* Add support for template output in `dep status`. ([#1389](https://github.com/golang/dep/pull/1389) | ||
* Each element in a multi-item TOML array is output on its own line. ([#1461](https://github.com/golang/dep/pull/1461) | ||
* Added `install.sh` script. ([#1533](https://github.com/golang/dep/pull/1533) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like we started copying unbalanced parens at some point:
([#1533](https://github.com/golang/dep/pull/1533)
-> (#1533
Would you mind fixing this line and any nearby?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or we could come back with another PR and fix these (and add links) since there are so many.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jmank88 I should have noticed those in the MD preview. Fixed it throughout the section.
@sdboyer I've fixed the issue you pointed out. can you have another look? Also the travis builds look very stuck again. |
@sdboyer anything else to change here? |
a79ce47
to
aa9d47c
Compare
Had to do some surgery to rebase the branch on latest master. Including support for i386 and freebsd. |
c344f17
to
283c00c
Compare
…testing and unusual scenarios
c59be21
to
4f2a7ab
Compare
install.sh
Outdated
# Environment variables: | ||
# - INSTALL_DIRECTORY (optional): defaults to $GOPATH/bin | ||
# - DEP_RELEASE_TAG (optional): defaults to fetching the latest release | ||
# - DEP_FAKE_OS (optional): use a fake value for OS (mostly for testing) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor nit: can we use DEP_OS
and DEP_ARCH
instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, will push an update just now.
woo! there are some fixups to be made but i'll do them directly |
Thanks @sdboyer ! |
What does this do / why do we need it?
Provides a portable sh script for installing an appropriate dep binary into your environment.
Some regular build environments need
dep
installed but don't want to pull all the dependencies and build it every time. (Especially in docker-based build environments).This script provides an easy way to install dep into the GOPATH/bin or specified location via:
What should your reviewer look out for in this PR?
It should be compatible with basic
sh
syntax without needing anybash
magic. I'd appreciate it if others could test it in their environments.It supports both
curl
andwget
as download mechanisms and bails out if neither are available.It supports the current binaries available under releases.
Do you need help or clarification on anything?
*.sha256
files? I feel it may add some unexpected complexity having to deal with different platforms provided shasum binary.Which issue(s) does this PR fix?
No issue was cut for this, it is just a suggestion. Can retroactively cut an issue for it if necessary.
Example: