-
Notifications
You must be signed in to change notification settings - Fork 1k
Modify FAQ.md to address http authentication with git #822
Conversation
Added instructions for authentication with git.
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
I signed it! |
CLAs look good, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just two nits. again, thank you, i'm so grateful you tracked this down!
@@ -121,6 +122,42 @@ No. | |||
> We prefer to treat the `vendor/` as an implementation detail. | |||
-[@sdboyer on go package management list](https://groups.google.com/d/msg/go-package-management/et1qFUjrkP4/LQFCHP4WBQAJ) | |||
|
|||
## How do I get dep to authenticate to a git repo? | |||
|
|||
dep currently uses the git command under the hood, so configuring the credentials |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
consistency nit: backticks around git
, dep
, etc.
|
||
After configuring git, you may need to use git manually once to have it store the | ||
credentials. Once you've checked out the repo manually, it will then use the stored | ||
credentials. This at least appears to be the behaviour for the osxkeychain. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
more consistency nits: American English spellings, please 😄
I'll make a new PR with the suggested changes. |
Added instructions for authentication with git to the FAQ.
What does this do / why do we need it?
Clarify #264
What should your reviewer look out for in this PR?
Make sure that the examples work as expected.
Do you need help or clarification on anything?
Which issue(s) does this PR fix?
fixes #264