FAQ entry for issue #856, (anyway I think this is how it works) #863

djosephsen · 2017-07-20T16:44:27Z

What does this do / why do we need it?

Just some words for the faq / Because you asked for them in #856

What should your reviewer look out for in this PR?

no sharp edges here.

Do you need help or clarification on anything?

Nope 👍

Which issue(s) does this PR fix?

#865

matjam · 2017-07-20T17:02:43Z

FAQ.md

+
+## One or more of my dependencies doesn't tag its releases. What should I do?
+
+Simply add a constrainit to your manifest that specifies `"branch": "master"`


spelling: constraint

matjam · 2017-07-20T17:03:00Z

FAQ.md

+## One or more of my dependencies doesn't tag its releases. What should I do?
+
+Simply add a constrainit to your manifest that specifies `"branch": "master"`
+for the dependency. Dep will deduce the current revision number of your


use dep not Dep, I think.

carolynvs

Just two small changes. Thank you for tackling this so quickly!

carolynvs · 2017-07-20T17:30:20Z

FAQ.md

@@ -34,6 +34,7 @@ Summarize the question and quote the reply, linking back to the original comment
 * [What semver version should I use?](#what-semver-version-should-i-use)
 * [Is it OK to make backwards-incompatible changes now?](#is-it-ok-to-make-backwards-incompatible-changes-now)
 * [My dependers don't use `dep` yet. What should I do?](#my-dependers-dont-use-dep-yet-what-should-i-do)
+* [One or more of my dependencies doesn't tag its releases. What should I do?](#one-or-more-of-my-dependencies-dont-tag-their-releases-what-should-i-do)


Let's simplify the question to "How do I configure a dependency that doesn't tag its releases?"

carolynvs · 2017-07-20T17:32:47Z

FAQ.md

+
+## One or more of my dependencies doesn't tag its releases. What should I do?
+
+Simply add a constraint to your manifest that specifies `"branch": "master"`


Remove "simply", changing it to "Add a constraint...". I don't want anyone feeling bad about themselves if this doesn't feel simple! 😀

carolynvs · 2017-07-20T17:33:58Z

Don't worry about the PR status checks by the way! Github has a bug at the moment which is making them fail when the PR is just fine.

The toc formatting got messed up with extra hyphens

carolynvs · 2017-07-20T18:06:35Z

FAQ.md

+
+## How do I configure a dependency that doesn't tag its releases?
+
+Add a constraint to your manifest that specifies `"branch": "master"`


Ooops, I missed this the first time around but it should be branch = "master" in order to be proper TOML.

blerg sorry.

carolynvs · 2017-07-20T18:18:06Z

FAQ.md

@@ -34,8 +34,7 @@ Summarize the question and quote the reply, linking back to the original comment
 * [What semver version should I use?](#what-semver-version-should-i-use)
 * [Is it OK to make backwards-incompatible changes now?](#is-it-ok-to-make-backwards-incompatible-changes-now)
 * [My dependers don't use `dep` yet. What should I do?](#my-dependers-dont-use-dep-yet-what-should-i-do)
-
-___
+* [How do I configure a dependency that doesn't tag its releases?](#how-do-I-configure-a-dependency-that-doesnt-tag-its-releases)


One more change, I swear! Thank you for sticking with me. 😁

The link isn't scrolling down the page to the right section because of the upper-case "I" in the url. It should be this #how-do-i-configure-a-dependency-that-doesnt-tag-its-releases.

I tried to "help" before by adding a commit to your PR but I think that made it harder... Sorry about that!

np really. Making epics of what should be a simple change is my superpower

djosephsen · 2017-07-20T18:47:32Z

omg. I actually can't believe I just did that standby..

googlebot · 2017-07-20T18:47:36Z

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

djosephsen · 2017-07-20T18:57:06Z

Not sure why it thinks I didn't sign the cla (I did)

carolynvs

@sdboyer Would you please do a squash and merge for us?

carolynvs · 2017-07-20T19:38:36Z

Don't worry about the CLA, there's a bug at the moment which is causing it to fail. Thanks again for the PR! 💖

sdboyer

some quick changes, first...

sdboyer · 2017-07-21T00:07:46Z

FAQ.md

+
+Add a constraint to your manifest that specifies `branch: "master"`
+for the dependency. `dep` will deduce the current revision number of your
+dependencies master branch, and place it the lock-file (`Gopkg.lock`) for you.


s/dependencies/dependency's/

sdboyer · 2017-07-21T00:12:11Z

FAQ.md

+## How do I configure a dependency that doesn't tag its releases?
+
+Add a constraint to your manifest that specifies `branch: "master"`
+for the dependency. `dep` will deduce the current revision number of your


s/dep/dep ensure/ - just to make it clear what phase (e.g., not before dep init) in which this guidance applies.

Also, s/revision number/revision/

sdboyer · 2017-07-21T00:15:24Z

FAQ.md

+Add a constraint to your manifest that specifies `branch: "master"`
+for the dependency. `dep` will deduce the current revision number of your
+dependencies master branch, and place it the lock-file (`Gopkg.lock`) for you.
+Anyone who clones your project will, therefore, wind up with same version of the dependency,


I'm not sure this is quite what we want to be saying here. Committing vendor is what would guarantee this at clone time; having the rev in your Gopkg.lock only guarantees that vendor will be populated with it by dep ensure (assuming no other changes).

Just the last sentence, referring the reader to the other question, is probably sufficient.

sdboyer

tiny nit, then needs a rebase, then we're good 😄

sdboyer · 2017-07-26T08:53:40Z

FAQ.md

+## How do I configure a dependency that doesn't tag its releases?
+
+Add a constraint to your manifest that specifies `branch: "master"`
+for the dependency. `dep ensure` will deduce the current revision of your


eh, one last tiny nit - we often use "deduce" to mean a specific thing in the dep/gps world. there's nothing wrong with this usage here, but if you did s/determine/deduce/, it would help avoid any possible inferred relationship forming in the mind of the reader between the deduction subsystem (if they know about it) and figuring out the underlying rev of a branch.

sdboyer

i have some small tweaks to make, but i'll do those directly rather than having this languish further. sorry for the slowness!

sdboyer · 2017-08-11T17:48:59Z

oh wait, conflicts. ok, i'll fix directly, then push 😄

sdboyer · 2017-08-11T17:54:26Z

@djosephsen thank you!

FAQ, anyway I *think* this is how it works golang#865)

63045be

djosephsen requested a review from sdboyer as a code owner July 20, 2017 16:44

googlebot added the cla: yes label Jul 20, 2017

djosephsen changed the title ~~FAQ entry for issue #865, (anyway I *think* this is how it works)~~ FAQ entry for issue #856, (anyway I *think* this is how it works) Jul 20, 2017

matjam suggested changes Jul 20, 2017

View reviewed changes

spelling/capitilization fixes

0d9f186

carolynvs suggested changes Jul 20, 2017

View reviewed changes

Dave Josephsen and others added 3 commits July 20, 2017 12:56

simpler question, fewer "simples" in the answer

b9a6c1c

Fix toc formatting

16002a9

The toc formatting got messed up with extra hyphens

haha Im awesome at this

16e8e97

carolynvs suggested changes Jul 20, 2017

View reviewed changes

Dave Josephsen added 2 commits July 20, 2017 13:11

merge in dash fix

63230af

fix toml

eb114f8

carolynvs suggested changes Jul 20, 2017

View reviewed changes

wherein attention to detail is retroactively applied

a433d9c

googlebot added cla: no and removed cla: yes labels Jul 20, 2017

fixing uppercase I

17d16f5

carolynvs approved these changes Jul 20, 2017

View reviewed changes

sdboyer suggested changes Jul 21, 2017

View reviewed changes

various corrections

deaa88a

sdboyer added the docs label Jul 21, 2017

sdboyer approved these changes Jul 26, 2017

View reviewed changes

sdboyer reviewed Jul 26, 2017

View reviewed changes

s/deduce/decide/

f53c745

sdboyer approved these changes Aug 11, 2017

View reviewed changes

sdboyer merged commit f53c745 into golang:master Aug 11, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

FAQ entry for issue #856, (anyway I think this is how it works) #863

FAQ entry for issue #856, (anyway I think this is how it works) #863

djosephsen commented Jul 20, 2017 •

edited

Loading

matjam Jul 20, 2017

matjam Jul 20, 2017

carolynvs left a comment

carolynvs Jul 20, 2017

carolynvs Jul 20, 2017

carolynvs commented Jul 20, 2017

carolynvs Jul 20, 2017

djosephsen Jul 20, 2017

carolynvs Jul 20, 2017

djosephsen Jul 20, 2017

djosephsen commented Jul 20, 2017

googlebot commented Jul 20, 2017

djosephsen commented Jul 20, 2017

carolynvs left a comment

carolynvs commented Jul 20, 2017

sdboyer left a comment

sdboyer Jul 21, 2017

sdboyer Jul 21, 2017

sdboyer Jul 21, 2017

sdboyer Jul 21, 2017

sdboyer left a comment

sdboyer Jul 26, 2017

sdboyer left a comment

sdboyer commented Aug 11, 2017

sdboyer commented Aug 11, 2017


		## One or more of my dependencies doesn't tag its releases. What should I do?

		Simply add a constrainit to your manifest that specifies `"branch": "master"`


		## One or more of my dependencies doesn't tag its releases. What should I do?

		Simply add a constraint to your manifest that specifies `"branch": "master"`


		## How do I configure a dependency that doesn't tag its releases?

		Add a constraint to your manifest that specifies `"branch": "master"`

FAQ entry for issue #856, (anyway I *think* this is how it works) #863

FAQ entry for issue #856, (anyway I *think* this is how it works) #863

Conversation

djosephsen commented Jul 20, 2017 • edited Loading

What does this do / why do we need it?

What should your reviewer look out for in this PR?

Do you need help or clarification on anything?

Which issue(s) does this PR fix?

Choose a reason for hiding this comment

Choose a reason for hiding this comment

carolynvs left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

carolynvs commented Jul 20, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

djosephsen commented Jul 20, 2017

googlebot commented Jul 20, 2017

djosephsen commented Jul 20, 2017

carolynvs left a comment

Choose a reason for hiding this comment

carolynvs commented Jul 20, 2017

sdboyer left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sdboyer left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sdboyer left a comment

Choose a reason for hiding this comment

sdboyer commented Aug 11, 2017

sdboyer commented Aug 11, 2017

FAQ entry for issue #856, (anyway I think this is how it works) #863

FAQ entry for issue #856, (anyway I think this is how it works) #863

djosephsen commented Jul 20, 2017 •

edited

Loading