This repository has been archived by the owner on Jan 16, 2021. It is now read-only.
Improve handling of vendored packages, fix issues #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
garyburd
commented
Jan 20, 2015
garyburd
commented
- Remove code that blocked vendored packages.
- Allow "_" at beginning of path element in package path. This had blocked package vendored by godeps.
- Compensate for previous two changes by improving the recognition and scoring of vendored packages.
- Fix issues searches for commands don't work #201, linking to "vendored" dependencies like importers #195, Incorrect error "The go get command cannot install this package" #230
- Do not set score to zero for all commands. Fixes #201 - Separate logic for scoring commands and packages. - Set score to zero for command with no documentation. - Add regexp to recognize vendored package paths. Set score to zero for vendored packages. Penalize packages that import vendored packages.
adg
added a commit
that referenced
this pull request
Feb 9, 2015
Improve handling of vendored packages, fix issues
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.