Skip to content
This repository has been archived by the owner on Jan 16, 2021. It is now read-only.

doc: Add "linux", "js" GOOS-GOARCH env pair. #343

Merged
merged 1 commit into from
Oct 21, 2015
Merged

doc: Add "linux", "js" GOOS-GOARCH env pair. #343

merged 1 commit into from
Oct 21, 2015

Conversation

dmitshur
Copy link
Contributor

Resolves #342.

There is a Go compiler (named GopherJS) that targets environments where only JavaScript can run. Its GOARCH value is "js". Adding a "linux", "js" GOOS-GOARCH env pair allows gddo to display Go packages that are targeting js environments only.

See #342 (comment) for full motivation and additional details, examples of such packages that currently exist.

/cc @adg

Resolves #342.

There is a Go compiler (named GopherJS) that targets environments where only JavaScript can run. Its GOARCH value is "js". Adding a "linux", "js" GOOS-GOARCH env pair allows gddo to display Go packages that are targeting js environments only.

See #342 (comment) for full motivation and additional details, examples of such packages that currently exist.
adg added a commit that referenced this pull request Oct 21, 2015
doc: Add "linux", "js" GOOS-GOARCH env pair.
@adg adg merged commit a93040f into golang:master Oct 21, 2015
@dmitshur dmitshur deleted the add-linux-js-env-pair branch October 21, 2015 07:36
@dmitshur
Copy link
Contributor Author

@adg, has godoc.org been redeployed since this was merged (4 days ago)?

Because https://godoc.org/github.com/gopherjs/jsbuiltin is still not working, and I can't tell if it's because no redeploy or because this PR hasn't resolved the issue fully somehow.

@dmitshur
Copy link
Contributor Author

@adg, has godoc.org been redeployed yet?

@dmitshur
Copy link
Contributor Author

dmitshur commented Nov 7, 2015

It has been 18 days since this was merged, I can only assume that gddo has been deployed at least once since then (although I still don't have any sure confirmation). However, the issue appears unresolved even now.

I was pretty sure this patch would've fixed the problem and it had in my local testing (after I resolved an unrelated issue in the package gopherjs/jsbuiltin#6). But it looks like I should look into it again.

@adg
Copy link
Contributor

adg commented Nov 9, 2015

I may not have updated it the last time you asked. Sorry, I've been
distracted.
It is updated now.

On 8 November 2015 at 07:26, Dmitri Shuralyov notifications@github.com
wrote:

It has been 18 days since this was merged, I can only assume that gddo has
been deployed at least once since then (although I still don't have any
sure confirmation). However, the issue appears unresolved even now.

I was pretty sure this patch would've fixed the problem and it had in my
local testing (after I resolved an unrelated issue in the package
gopherjs/jsbuiltin#6 gopherjs/jsbuiltin#6). But
it looks like I should look into it again.


Reply to this email directly or view it on GitHub
#343 (comment).

@dmitshur
Copy link
Contributor Author

dmitshur commented Nov 9, 2015

I see. https://godoc.org/github.com/gopherjs/jsbuiltin is now working, so there's no problem with code, it was just not yet deployed.

Thank you @adg!

@adg
Copy link
Contributor

adg commented Nov 9, 2015

Again, sorry for the delay. Glad it's working.

On 9 November 2015 at 16:11, Dmitri Shuralyov notifications@github.com
wrote:

I see. https://godoc.org/github.com/gopherjs/jsbuiltin is now working, so
there's no problem with code, it was just not yet deployed.

Thank you @adg https://github.com/adg!


Reply to this email directly or view it on GitHub
#343 (comment).

@dmitshur
Copy link
Contributor Author

dmitshur commented Nov 9, 2015

No problem at all; I know whatever else you're spending time on is no less important. :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants