Skip to content

Commit

Permalink
time: stop referring to timerproc in comment
Browse files Browse the repository at this point in the history
The timerproc function has been removed.

Fixes #37774

Change-Id: Ice5e1d8fec91cd6ee7f032e0d21e8315a26bc6a3
Reviewed-on: https://go-review.googlesource.com/c/go/+/222783
Reviewed-by: Alberto Donizetti <alb.donizetti@gmail.com>
  • Loading branch information
ianlancetaylor committed Mar 13, 2020
1 parent 1f231d7 commit 85e87f9
Showing 1 changed file with 7 additions and 6 deletions.
13 changes: 7 additions & 6 deletions src/time/internal_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -67,12 +67,13 @@ func CheckRuntimeTimerOverflow() {
resetTimer(r, 0)
}()

// If the test fails, we will hang here until the timeout in the testing package
// fires, which is 10 minutes. It would be nice to catch the problem sooner,
// but there is no reliable way to guarantee that timerproc schedules without
// doing something involving timerproc itself. Previous failed attempts have
// tried calling runtime.Gosched and runtime.GC, but neither is reliable.
// So we fall back to hope: We hope we don't hang here.
// If the test fails, we will hang here until the timeout in the
// testing package fires, which is 10 minutes. It would be nice to
// catch the problem sooner, but there is no reliable way to guarantee
// that timers are run without doing something involving the scheduler.
// Previous failed attempts have tried calling runtime.Gosched and
// runtime.GC, but neither is reliable. So we fall back to hope:
// We hope we don't hang here.
<-t.C
}

Expand Down

0 comments on commit 85e87f9

Please sign in to comment.