Skip to content

Commit

Permalink
time: note that formats may parse invalid strings
Browse files Browse the repository at this point in the history
The existing documentation for time format constants doesn't mention
that they may parse technically-invalid strings, such as single-digit
hours when a two-digit hour is required by a specification.  This commit
adds a short warning note to that effect.

Fixes #37616

Change-Id: I6e5e12bd42dc368f8ca542b4c0527a2b7d30acaf
Reviewed-on: https://go-review.googlesource.com/c/go/+/229460
Run-TryBot: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
  • Loading branch information
David Golden authored and ianlancetaylor committed Jun 2, 2020
1 parent ee776b4 commit a9cc105
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/time/format.go
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ import "errors"
// that insist on that format, and RFC3339 should be preferred for new protocols.
// RFC3339, RFC822, RFC822Z, RFC1123, and RFC1123Z are useful for formatting;
// when used with time.Parse they do not accept all the time formats
// permitted by the RFCs.
// permitted by the RFCs and they do accept time formats not formally defined.
// The RFC3339Nano format removes trailing zeros from the seconds field
// and thus may not sort correctly once formatted.
const (
Expand Down

0 comments on commit a9cc105

Please sign in to comment.