Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

all: refresh contributor and authors files before releases #12042

Open
rsc opened this Issue Aug 5, 2015 · 48 comments

Comments

Projects
None yet
10 participants
@rsc
Copy link
Contributor

rsc commented Aug 5, 2015

We should set up a process where CONTRIBUTORS gets updated semiautomatically.
See #10639 for the last time, which I believe was more manual.

@rsc rsc added this to the Go1.6 milestone Aug 5, 2015

@bradfitz

This comment has been minimized.

Copy link
Member

bradfitz commented Aug 6, 2015

I wrote a tool for it. But it has to run inside Google (with my credentials refreshed) to hit the CLA server.

@gopherbot

This comment has been minimized.

Copy link

gopherbot commented Nov 12, 2015

CL https://golang.org/cl/16824 mentions this issue.

@gopherbot

This comment has been minimized.

Copy link

gopherbot commented Nov 12, 2015

CL https://golang.org/cl/16825 mentions this issue.

bradfitz added a commit that referenced this issue Nov 12, 2015

misc/sortac: add tool to sort the AUTHORS and CONTRIBUTORS files
I keep losing this utility, used as part of other tools to auto-update
the AUTHORS and CONTRIBUTORS files.  Check it in to the repo so I
don't lose it, and so others can use it as well.

Updates #12042

Change-Id: Ib5886b85799087aaaddcec4c81169e2726322c05
Reviewed-on: https://go-review.googlesource.com/16824
Reviewed-by: Russ Cox <rsc@golang.org>

bradfitz added a commit that referenced this issue Nov 13, 2015

A+C: automated updates
Add Alberto Bertogli (individual CLA)
Add Alexander Demakin (individual CLA)
Add Angelo Bulfone (individual CLA)
Add Anthony Canino (individual CLA)
Add Arnout Engelen (individual CLA)
Add Cedric Staub (corporate CLA for Square, Inc.)
Add Dan Caddigan (individual CLA)
Add Dan Jacques (corporate CLA for Google Inc.)
Add Daniel Skinner (individual CLA)
Add David Howden (individual CLA)
Add Dmitry Yakunin (individual CLA)
Add Emmanuel Odeke (individual CLA)
Add Eric Koleda (corporate CLA for Google Inc.)
Add Erik Dubbelboer (individual CLA)
Add Evan Broder (corporate CLA for Stripe, Inc.)
Add Ford Hurley (individual CLA)
Add Francisco Claude (individual CLA)
Add Gaurish Sharma (individual CLA)
Add Hsin-Ho Yeh (individual CLA)
Add Ian Gudger (individual CLA)
Add Ilya Tocar (corporate CLA for Intel Corporation)
Add John Jenkins (individual CLA)
Add Kenny Grant (individual CLA)
Add Kevin Malachowski (corporate CLA for Google Inc.)
Add Kim Shrier (corporate CLA for RackTop Systems Inc.)
Add Klaus Post (individual CLA)
Add Lewin Bormann (individual CLA)
Add Manu S Ajith (individual CLA)
Add Matt Drollette (individual CLA)
Add Meng Zhuo (individual CLA)
Add Mhd Sulhan (individual CLA)
Add Mohit Agarwal (individual CLA)
Add Nathan Otterness (individual CLA)
Add Nathan VanBenschoten (individual CLA)
Add Paul Hankin (corporate CLA for Google Inc.)
Add Paul Meyer (individual CLA)
Add Pavel Paulau (individual CLA)
Add Ralph Corderoy (individual CLA)
Add Rob Norman (individual CLA)
Add Seth Hoenig (individual CLA)
Add Spencer Nelson (individual CLA)
Add Steve Phillips (individual CLA)
Add Thorben Krueger (individual CLA)
Add Tormod Erevik Lea (individual CLA)
Add Will Chan (corporate CLA for Google Inc.)
Add Yao Zhang (individual CLA)
Add Yasuharu Goto (individual CLA)
Add Yuki Yugui Sonoda (corporate CLA for Google Inc.)

Updates #12042

Change-Id: Ia5f8e184fdbe8b135b2c29bb75f20bf72042abae
Reviewed-on: https://go-review.googlesource.com/16825
Reviewed-by: Russ Cox <rsc@golang.org>
@bradfitz

This comment has been minimized.

Copy link
Member

bradfitz commented Nov 13, 2015

I've added the Google-internal tool to google3/experimental/users/bradfitz/updateac/updateac.go for now so I don't lose it. We can put it somewhere better outside of experimental when it's code reviewed and we decide on a name and location. (which might prove more difficult than writing the tool)

I don't know what it takes to close this bug. I doubt we'll be able to auto-run the tool regularly, given its dependence on Google's internal CLA service.

We can at least run this again right before Go 1.6 is released.

@andygrunwald

This comment has been minimized.

Copy link

andygrunwald commented Nov 27, 2015

@bradfitz Is this tool open source or public available?

@bradfitz

This comment has been minimized.

Copy link
Member

bradfitz commented Nov 27, 2015

Nope. It uses a Google-internal service.

@andygrunwald

This comment has been minimized.

Copy link

andygrunwald commented Nov 27, 2015

That was fast. Thx.

@gopherbot

This comment has been minimized.

Copy link

gopherbot commented Jan 5, 2016

CL https://golang.org/cl/18264 mentions this issue.

bradfitz added a commit that referenced this issue Jan 5, 2016

A+C: automated update
These are the easy, automated cases. There were some more where we
need to fight Gerrit and the CLA system to extract the appropriate
metadata.

Updates #12042

Change-Id: Id63ae635ee7efeec4cd372c7d85bb5b1f557951b
Reviewed-on: https://go-review.googlesource.com/18264
Reviewed-by: Ian Lance Taylor <iant@golang.org>
@bradfitz

This comment has been minimized.

Copy link
Member

bradfitz commented Jan 8, 2016

I also submitted git rev 9a2d717 yesterday but forgot to mention this issue.

It might be okay to close this bug now. @rsc?

@rsc

This comment has been minimized.

Copy link
Contributor Author

rsc commented Jan 8, 2016

It's kind of nice to have a bug open to remind us. I was thinking we could just move the milestone. But whatever you want to do is fine, since you run the tool.

@bradfitz bradfitz modified the milestones: Go1.7, Go1.6 Jan 8, 2016

@quentinmit quentinmit added the NeedsFix label May 19, 2016

@gopherbot

This comment has been minimized.

Copy link

gopherbot commented May 20, 2016

CL https://golang.org/cl/23303 mentions this issue.

gopherbot pushed a commit that referenced this issue May 20, 2016

A+C: automated updates
Add Aiden Scandella (individual CLA)
Add Alessandro Arzilli (individual CLA)
Add Augusto Roman (individual CLA)
Add Brady Catherman (individual CLA)
Add Brady Sullivan (individual CLA)
Add Caio Marcelo de Oliveira Filho (corporate CLA for Intel Corporation)
Add Catalin Nicutar (corporate CLA for Google Inc.)
Add Cherry Zhang (corporate CLA for Google Inc.)
Add Chris Zou (corporate CLA for IBM)
Add Christopher Nelson (individual CLA)
Add Conrad Irwin (individual CLA)
Add Cuihtlauac ALVARADO (corporate CLA for Orange)
Add Daniel Speichert (individual CLA)
Add Datong Sun (individual CLA)
Add Denys Honsiorovskyi (individual CLA)
Add Derek Shockey (individual CLA)
Add Dmitriy Dudkin (individual CLA)
Add Dustin Herbis (individual CLA)
Add Frits van Bommel (individual CLA)
Add Harshavardhana (individual CLA)
Add Hitoshi Mitake (individual CLA)
Add James Bardin (individual CLA)
Add James Chacon (corporate CLA for Google Inc.)
Add Jamil Djadala (individual CLA)
Add Jess Frazelle (individual CLA)
Add Joe Sylve (individual CLA)
Add Johan Sageryd (individual CLA)
Add John Jeffery (individual CLA)
Add Julia Hansbrough (corporate CLA for Google Inc.)
Add Jure Ham (corporate CLA for Zemanta d.o.o.)
Add Kamal Aboul-Hosn (corporate CLA for Google Inc.)
Add Kevin Burke (individual CLA)
Add Kevin Kirsche (individual CLA)
Add Kevin Vu (individual CLA)
Add Lee Hinman (individual CLA)
Add Luan Santos (individual CLA)
Add Marc-Antoine Ruel (corporate CLA for Google Inc.)
Add Matt Robenolt (individual CLA)
Add Michael McConville (individual CLA)
Add Michael Munday (corporate CLA for IBM)
Add Michael Pratt (corporate CLA for Google Inc.)
Add Michel Lespinasse (corporate CLA for Google Inc.)
Add Mike Danese (corporate CLA for Google Inc.)
Add Mikhail Gusarov (individual CLA)
Add Monty Taylor (individual CLA)
Add Morten Siebuhr (individual CLA)
Add Muhammed Uluyol (individual CLA)
Add Niels Widger (individual CLA)
Add Niko Dziemba (individual CLA)
Add Olivier Poitrey (individual CLA)
Add Paul Wankadia (corporate CLA for Google Inc.)
Add Philip Hofer (individual CLA)
Add Prashant Varanasi (individual CLA)
Add Rhys Hiltner (corporate CLA for Amazon.com, Inc)
Add Richard Miller (individual CLA)
Add Scott Bell (individual CLA)
Add Shahar Kohanim (individual CLA)
Add Shinji Tanaka (individual CLA)
Add Suharsh Sivakumar (corporate CLA for Google Inc.)
Add Tal Shprecher (individual CLA)
Add Tilman Dilo (individual CLA)
Add Tim Ebringer (individual CLA)
Add Tom Bergan (corporate CLA for Google Inc.)
Add Vishvananda Ishaya (individual CLA)
Add Wedson Almeida Filho (corporate CLA for Google Inc.)
Add Zhongwei Yao (corporate CLA for ARM Ltd.)

Updates #12042

Change-Id: Ia118adc2eb38e5ffc8448de2d9dd3ca792ee7227
Reviewed-on: https://go-review.googlesource.com/23303
Reviewed-by: Ian Lance Taylor <iant@golang.org>
@gopherbot

This comment has been minimized.

Copy link

gopherbot commented May 21, 2016

CL https://golang.org/cl/23306 mentions this issue.

gopherbot pushed a commit that referenced this issue May 21, 2016

A+C: automated update (subrepos)
Add Abe Haskins (individual CLA)
Add Ahmy Yulrizka (individual CLA)
Add Akihiro Suda (individual CLA)
Add Alex Vaghin (corporate CLA for Google Inc.)
Add Arlo Breault (individual CLA)
Add Audrey Lim (individual CLA)
Add Benjamin Wester (corporate CLA for Square, Inc.)
Add Bryan Chan (corporate CLA for IBM)
Add Christy Perez (corporate CLA for IBM)
Add Colin Edwards (individual CLA)
Add David Brophy (individual CLA)
Add David Sansome (individual CLA)
Add Diwaker Gupta (individual CLA)
Add Doug Anderson (corporate CLA for Google Inc.)
Add Dustin Carlino (corporate CLA for Google Inc.)
Add Ernest Chiang (individual CLA)
Add Ethan Burns (corporate CLA for Google Inc.)
Add Gary Elliott (corporate CLA for Google Inc.)
Add Hallgrimur Gunnarsson (corporate CLA for Google Inc.)
Add Hironao OTSUBO (individual CLA)
Add Holden Huang (individual CLA)
Add Idora Shinatose (individual CLA)
Add Irieda Noboru (individual CLA)
Add Jeff Craig (corporate CLA for Google Inc.)
Add Joe Henke (individual CLA)
Add John Schnake (individual CLA)
Add Jonathan Amsterdam (corporate CLA for Google Inc.)
Add Kenji Kaneda (individual CLA)
Add Kenneth Shaw (individual CLA)
Add Mark Severson (individual CLA)
Add Martin Garton (individual CLA)
Add Mathias Leppich (individual CLA)
Add Maxwell Krohn (individual CLA)
Add Niall Sheridan (individual CLA)
Add Nick Patavalis (individual CLA)
Add Nick Petroni (individual CLA)
Add Omar Jarjur (corporate CLA for Google Inc.)
Add Özgür Kesim (individual CLA)
Add Peter Gonda (corporate CLA for Google Inc.)
Add Pierre Durand (individual CLA)
Add Quentin Smith (corporate CLA for Google Inc.)
Add Ricardo Padilha (individual CLA)
Add Riku Voipio (corporate CLA for Linaro Limited)
Add Roland Shoemaker (individual CLA)
Add Sam Hug (individual CLA)
Add Sam Whited (individual CLA)
Add Sami Commerot (corporate CLA for Google Inc.)
Add Scott Mansfield (corporate CLA for Netflix, Inc.)
Add Sean Harger (corporate CLA for Google Inc.)
Add Simon Jefford (individual CLA)
Add Sridhar Venkatakrishnan (individual CLA)
Add Tim Swast (corporate CLA for Google Inc.)
Add Timothy Studd (individual CLA)
Add Tipp Moseley (corporate CLA for Google Inc.)
Add Toby Burress (corporate CLA for Google Inc.)
Add Tzu-Jung Lee (corporate CLA for Currant)
Add Vadim Grek (individual CLA)
Add Xudong Zhang (individual CLA)

Updates #12042

Change-Id: I4119a8829119a2b8a9abbea9f52ceebb04878764
Reviewed-on: https://go-review.googlesource.com/23306
Reviewed-by: Ian Lance Taylor <iant@golang.org>
Reviewed-by: Andrew Gerrand <adg@golang.org>
@gopherbot

This comment has been minimized.

Copy link

gopherbot commented Jun 23, 2016

CL https://golang.org/cl/24420 mentions this issue.

gopherbot pushed a commit that referenced this issue Jun 24, 2016

A+C: automated updates
Add Aaron Zinman (corporate CLA for Empirical Interfaces Inc.)
Add Ayanamist Yang (individual CLA)
Add Christian Couder (individual CLA)
Add Eric Engestrom (individual CLA)
Add Filippo Valsorda (individual CLA)
Add Gyu-Ho Lee (individual CLA)
Add H. İbrahim Güngör (individual CLA)
Add Jacob Hoffman-Andrews (individual CLA)
Add Jason Barnett (individual CLA)
Add Joe Farrell (individual CLA)
Add Julian Kornberger (individual CLA)
Add Kris Rousey (corporate CLA for Google Inc.)
Add Miguel Mendez (individual CLA)
Add Nic Day (individual CLA)
Add Paulo Casaretto (individual CLA)
Add Philip Børgesen (individual CLA)
Add Quan Tran (individual CLA)
Add Sai Cheemalapati (corporate CLA for Google Inc.)
Add Sasha Sobol (individual CLA)
Add Seth Vargo (individual CLA)
Add Simon Thulbourn (individual CLA)
Add Wisdom Omuya (individual CLA)

Updates #12042

Change-Id: Ie8ab5e3500ee62000c0b176d4d71340446e72ab7
Reviewed-on: https://go-review.googlesource.com/24420
Reviewed-by: Ian Lance Taylor <iant@golang.org>
@bradfitz

This comment has been minimized.

Copy link
Member

bradfitz commented Jun 27, 2016

Moving to Go 1.8. I don't expect new contributors during the deep freeze for Go 1.7.

@bradfitz bradfitz modified the milestones: Go1.8, Go1.7 Jun 27, 2016

@gopherbot

This comment has been minimized.

Copy link

gopherbot commented Nov 10, 2016

CL https://golang.org/cl/33028 mentions this issue.

gopherbot pushed a commit that referenced this issue Nov 10, 2016

A+C: update for Go 1.8
Add Albert Nigmatzianov (individual CLA)
Add Alex Browne (individual CLA)
Add Alex Carol (individual CLA)
Add Alexander Döring (individual CLA)
Add Allan Simon (individual CLA)
Add Alok Menghrajani (individual CLA)
Add Andreas Auernhammer (individual CLA)
Add Andreas Litt (individual CLA)
Add Andrew Pogrebnoy (individual CLA)
Add Antonio Murdaca (corporate CLA for Red Hat, Inc.)
Add Atin Malaviya (individual CLA)
Add Billy Lynch (corporate CLA for Google Inc.)
Add Blixt (individual CLA)
Add Boris Nagaev (corporate CLA for Google Inc.)
Add Braden Bassingthwaite (corporate CLA for Vendasta)
Add Brian Kennedy (individual CLA)
Add Bryan Alexander (individual CLA)
Add Carl Johnson (individual CLA)
Add Cixtor (individual CLA)
Add Cyrill Schumacher (individual CLA)
Add Daniel Martí (individual CLA)
Add Daria Kolistratova (corporate CLA for Intel Corporation)
Add David Hubbard (corporate CLA for Google Inc.)
Add David Stainton (individual CLA)
Add Deepak Jois (individual CLA)
Add Denis Nagorny (corporate CLA for Intel Corporation)
Add Dhaivat Pandit (individual CLA)
Add Dhananjay Nakrani (corporate CLA for Google Inc.)
Add Dmitri Popov (individual CLA)
Add Erik Staab (corporate CLA for Google Inc.)
Add Ethan Miller (corporate CLA for IBM)
Add Faiyaz Ahmed (individual CLA)
Add Fedor Indutny (individual CLA)
Add Gabriel Russell (individual CLA)
Add Gareth Paul Jones (individual CLA)
Add Geoffroy Lorieux (individual CLA)
Add Gleb Stepanov (individual CLA)
Add Henrik Hodne (individual CLA)
Add Ivan Babrou (individual CLA)
Add Jack Lindamood (corporate CLA for Amazon.com, Inc)
Add James Clarke (individual CLA)
Add Jamie Beverly (individual CLA)
Add Jason Smale (individual CLA)
Add Jean-Nicolas Moal (individual CLA)
Add Jeroen Bobbeldijk (individual CLA)
Add Jim Kingdon (corporate CLA for Bolt)
Add Jirka Daněk (individual CLA)
Add Jon Chen (corporate CLA for Amazon.com, Inc)
Add Joonas Kuorilehto (individual CLA)
Add Josh Chorlton (individual CLA)
Add Joshua Boelter (corporate CLA for Intel Corporation)
Add Justyn Temme (individual CLA)
Add Kale Blankenship (individual CLA)
Add LE Manh Cuong (individual CLA)
Add Luigi Riefolo (individual CLA)
Add Manfred Touron (individual CLA)
Add Martin Bertschler (individual CLA)
Add Martin Hamrle (individual CLA)
Add Matthew Denton (individual CLA)
Add Matthieu Hauglustaine (individual CLA)
Add Michael Darakananda (corporate CLA for Google Inc.)
Add Mike Appleby (individual CLA)
Add Mike Houston (individual CLA)
Add Mike Strosaker (corporate CLA for IBM)
Add Miroslav Genov (individual CLA)
Add Momchil Velikov (individual CLA)
Add Nick Harper (corporate CLA for Google Inc.)
Add Oleg Vakheta (individual CLA)
Add Parker Moore (individual CLA)
Add Prasanna Swaminathan (corporate CLA for MediaMath, Inc)
Add Radu Berinde (individual CLA)
Add Ramesh Dharan (corporate CLA for Google Inc.)
Add Richard Gibson (individual CLA)
Add Samuel Tan (corporate CLA for Google Inc.)
Add Samuele Pedroni (individual CLA)
Add Sarah Adams (corporate CLA for Google Inc.)
Add Sean Rees (individual CLA)
Add Simon Rawet (individual CLA)
Add Sina Siadat (individual CLA)
Add Song Gao (individual CLA)
Add Suyash (individual CLA)
Add Sven Blumenstein (corporate CLA for Google Inc.)
Add Syohei YOSHIDA (individual CLA)
Add Terrel Shumway (individual CLA)
Add Than McIntosh (corporate CLA for Google Inc.)
Add Thomas de Zeeuw (individual CLA)
Add Tim Henderson (individual CLA)
Add Tom Wilkie (corporate CLA for Weaveworks)
Add Trey Lawrence (individual CLA)
Add Tristan Ooohry (individual CLA)
Add Tuo Shan (corporate CLA for Google Inc.)
Add Victor Chudnovsky (corporate CLA for Google Inc.)
Add Vitor De Mario (individual CLA)
Add Vladimir Mihailenco (individual CLA)
Add Vladimir Stefanovic (individual CLA)
Add Walter Poupore (corporate CLA for Google Inc.)
Add Xuyang Kang (individual CLA)
Add Zev Goldstein (individual CLA)

Updates #12042

Change-Id: I28d63babe225683b88f3f1501e529aed636c9ead
Reviewed-on: https://go-review.googlesource.com/33028
Reviewed-by: Ian Lance Taylor <iant@golang.org>

@bradfitz bradfitz modified the milestones: Go1.8Maybe, Go1.8 Nov 11, 2016

@ianlancetaylor

This comment has been minimized.

Copy link
Contributor

ianlancetaylor commented May 2, 2018

Historically we've just updated the files for major releases. I guess we could start doing them for minor releases, but we would tend to pick up a lot of people whose work is only on tip and not in the minor release.

@ashishgandhi

This comment has been minimized.

Copy link
Contributor

ashishgandhi commented May 2, 2018

Makes sense. Thanks for letting me know.

@bradfitz

This comment has been minimized.

Copy link
Member

bradfitz commented Jun 6, 2018

@FiloSottile said he'd do it this cycle.

@FiloSottile, this is one of the bugs we never close but just keep it alive as a reminder from release-to-release. So after rc2 (when we generally stop updating this file), then change it to Milestone Go 1.12.

@bradfitz

This comment has been minimized.

Copy link
Member

bradfitz commented Jul 11, 2018

I showed @FiloSottile how to use the internal tool we have for updating this today.

@gopherbot

This comment has been minimized.

Copy link

gopherbot commented Jul 26, 2018

Change https://golang.org/cl/126215 mentions this issue: A+C: first round of automated updates for Go 1.11

gopherbot pushed a commit that referenced this issue Aug 9, 2018

A+C: first round of automated updates for Go 1.11 and missing AUTHORS
One first round of low-hanging fruit, excluding anything unclear.

Also fixed a bug where, if a contributor had different emails under
different CLAs, only the first one was added to AUTHORS.

Updates #12042

Change-Id: Id7b06c885d74b4718ef2d74d149513a7c0f40c91
Reviewed-on: https://go-review.googlesource.com/126215
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
@gopherbot

This comment has been minimized.

Copy link

gopherbot commented Aug 9, 2018

Change https://golang.org/cl/128877 mentions this issue: A+C: second and final round of automated updates for Go 1.11

gopherbot pushed a commit that referenced this issue Aug 12, 2018

A+C: second and final round of updates for Go 1.11
Updates #12042

Change-Id: Ia8d2214caad50560c4d46d723f8b94c954059b98
Reviewed-on: https://go-review.googlesource.com/128877
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
@rsc

This comment has been minimized.

Copy link
Contributor Author

rsc commented Aug 17, 2018

Last CL said "final for Go 1.11" so bumping to Go 1.12.

@rsc rsc modified the milestones: Go1.11, Go1.12 Aug 17, 2018

@FiloSottile

This comment has been minimized.

Copy link
Member

FiloSottile commented Jan 2, 2019

@dmitshur The tool is at google3/go/team/updateac/updateac.go. You'll have to strip all the parts related to CLAs and AUTHORS as we don't update that automatically anymore.

There's a sorting tool in the go tree at misc/sortac. I think we could probably merge it with the contributors tool eventually, now that it doesn't need the CLA server anymore.

@FiloSottile FiloSottile removed their assignment Jan 2, 2019

@gopherbot

This comment has been minimized.

Copy link

gopherbot commented Jan 4, 2019

Change https://golang.org/cl/156278 mentions this issue: CONTRIBUTORS: first round of automated updates for Go 1.12

gopherbot pushed a commit that referenced this issue Jan 4, 2019

CONTRIBUTORS: first round of automated updates for Go 1.12
These updates have been automatically generated using a modified
version of the updateac command with the following changes:

-	code to automatically update the AUTHORS file has been removed,
	since we're not updating that file automatically after Go 1.11
	(see CL 128877)
-	CLA checking code has been removed, since it was primarily needed
	for updating the AUTHORS file
-	instead of executing the misc/sortac binary, its code was embedded
	into the updateac command itself

The modified updateac command will be added to x/build repository soon,
and the misc/sortac command can be removed afterwards.

Updates #12042

Change-Id: Ibf73068698b14b1aad4df4490747b488508ff5fd
Reviewed-on: https://go-review.googlesource.com/c/156278
Reviewed-by: Filippo Valsorda <filippo@golang.org>
@gopherbot

This comment has been minimized.

Copy link

gopherbot commented Jan 10, 2019

Change https://golang.org/cl/157238 mentions this issue: cmd/updatecontrib: add updatecontrib command

@gopherbot

This comment has been minimized.

Copy link

gopherbot commented Jan 10, 2019

Change https://golang.org/cl/157257 mentions this issue: misc/sortac: delete sortac command

gopherbot pushed a commit to golang/build that referenced this issue Jan 14, 2019

cmd/updatecontrib: add updatecontrib command
This change adds a updatecontrib command that is used to update
the CONTRIBUTORS file in the Go repository.

It's based on a previously-internal updateac tool that updated both
CONTRIBUTORS and AUTHORS files. That program was modified to implement
the new behavior for golang.org/issue/12042, now that we're no longer
updating the AUTHORS file.

Specifically, all code to check CLAs and update AUTHORS file was
removed. Instead of relying on an external sortac binary from
GOROOT/misc/sortac, its code is incorporated directly here. That
means the misc/sortac binary can be deleted after this is merged.

Updates golang/go#12042

Change-Id: I45ae247c4e5b558e8a11cdaf720b60c2cf8fc876
Reviewed-on: https://go-review.googlesource.com/c/157238
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>

gopherbot pushed a commit that referenced this issue Jan 14, 2019

misc/sortac: delete sortac command
The sortac command is no longer needed as of CL 157238, and
can be deleted. Its functionality has been directly integrated
into the new x/build/cmd/updatecontrib command. A previous version
of updatecontrib was the only user of sortac.

Updates #12042

Change-Id: If7442ebee11d05d095ff875a37eed3973c0fd9ca
Reviewed-on: https://go-review.googlesource.com/c/157257
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
@gopherbot

This comment has been minimized.

Copy link

gopherbot commented Jan 29, 2019

Change https://golang.org/cl/160261 mentions this issue: CONTRIBUTORS: second and final round of updates for Go 1.12

gopherbot pushed a commit that referenced this issue Jan 30, 2019

CONTRIBUTORS: second round of updates for Go 1.12
This update has been automatically generated using the updatecontrib
command at CL 160277:

	cd gotip
	go run golang.org/x/build/cmd/updatecontrib

Actions taken (relative to CONTRIBUTORS at origin/master):

	Added Aaron Cannon <cannona@fireantproductions.com>
	Added Andzej Maciusovic <andzej.maciusovic@gmail.com>
	Added Douglas Danger Manley <doug.manley@gmail.com>
	Added Federico Bond <federicobond@gmail.com>
	Added Frew Schmidt <github@frew.co>
	Added GitHub User @saitarunreddy (21041941) <saitarunreddypalla@gmail.com>
	Added GitHub User @tell-k (26263) <ffk2005@gmail.com>
	Added Guilherme Caruso <gui.martinscaruso@gmail.com>
	Added Jay Taylor <outtatime@gmail.com>
	Added Juan Pablo Civile <elementohb@gmail.com>
	Added Julien Kauffmann <julien.kauffmann@freelan.org>
	Added Maya Rashish <maya@NetBSD.org>
	Added Parminder Singh <parmsingh101@gmail.com>
	Added Peter Dotchev <dotchev@gmail.com>
	Added Quinten Yearsley <qyearsley@chromium.org>
	Added Ross Smith II <ross@smithii.com>
	Added Sean Chen <oohcode@gmail.com>
	Added Sebastiaan van Stijn <github@gone.nl>
	Added Sebastian Schmidt <yath@google.com>
	Added Sebastien Williams-Wynn <sebastien@cytora.com>
	Added Viacheslav Poturaev <vearutop@gmail.com>
	Added Yohei Takeda <yo.tak0812@gmail.com>
	Used GitHub User @saitarunreddy (21041941) form for saitarunreddy <saitarunreddypalla@gmail.com> golang/build@269e03a [build]
	Used GitHub User @tell-k (26263) form for tell-k <ffk2005@gmail.com> golang/tools@85a87a8 [tools]
	Used GitHub name "Akhil Indurti" for smasher164 <aindurti@gmail.com> a7af474 [build go]
	Used GitHub name "Guilherme Caruso" for GuilhermeCaruso <gui.martinscaruso@gmail.com> 5fae09b [go]
	Used GitHub name "Ivan Markin" for nogoegst <nogoegst@users.noreply.github.com> a1addf1 [go]
	Used GitHub name "Keiji Yoshida" for yosssi <yoshida.keiji.84@gmail.com> golang/lint@ac6833c [lint]
	Used GitHub name "Marwan Sulaiman" for marwan-at-work <marwan.sameer@gmail.com> 92caeef [go]
	Used GitHub name "Michalis Kargakis" for kargakis <mkargaki@redhat.com> e243d24 [go]
	Used GitHub name "Robin Eklind" for mewmew <rnd0x00@gmail.com> b8620af [go proposal.git]
	Used GitHub name "Sean Chen" for two <oohcode@gmail.com> golang/sys@302c3dd [sys]
	Used GitHub name "Sebastien Williams-Wynn" for GiantsLoveDeathMetal <sebastien@cytora.com> 4e056ad [go]
	Used GitHub name "Yohei Takeda" for yo-tak <yo.tak0812@gmail.com> 8b7cf89 [go]

Given that the scope of updatecontrib is only to add contributors to
CONTRIBUTORS file, without having to check CLAs or deal with legal
matters, we can relax the requirement of having a space in the name
before it gets added to the CONTRIBUTORS file. That will be done
in a later change.

Updates #12042

Change-Id: I70248f3c82a836ee829256898e931e638ee45eb4
Reviewed-on: https://go-review.googlesource.com/c/160261
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>

nebulabox added a commit to nebulabox/go that referenced this issue Feb 18, 2019

CONTRIBUTORS: second round of updates for Go 1.12
This update has been automatically generated using the updatecontrib
command at CL 160277:

	cd gotip
	go run golang.org/x/build/cmd/updatecontrib

Actions taken (relative to CONTRIBUTORS at origin/master):

	Added Aaron Cannon <cannona@fireantproductions.com>
	Added Andzej Maciusovic <andzej.maciusovic@gmail.com>
	Added Douglas Danger Manley <doug.manley@gmail.com>
	Added Federico Bond <federicobond@gmail.com>
	Added Frew Schmidt <github@frew.co>
	Added GitHub User @saitarunreddy (21041941) <saitarunreddypalla@gmail.com>
	Added GitHub User @tell-k (26263) <ffk2005@gmail.com>
	Added Guilherme Caruso <gui.martinscaruso@gmail.com>
	Added Jay Taylor <outtatime@gmail.com>
	Added Juan Pablo Civile <elementohb@gmail.com>
	Added Julien Kauffmann <julien.kauffmann@freelan.org>
	Added Maya Rashish <maya@NetBSD.org>
	Added Parminder Singh <parmsingh101@gmail.com>
	Added Peter Dotchev <dotchev@gmail.com>
	Added Quinten Yearsley <qyearsley@chromium.org>
	Added Ross Smith II <ross@smithii.com>
	Added Sean Chen <oohcode@gmail.com>
	Added Sebastiaan van Stijn <github@gone.nl>
	Added Sebastian Schmidt <yath@google.com>
	Added Sebastien Williams-Wynn <sebastien@cytora.com>
	Added Viacheslav Poturaev <vearutop@gmail.com>
	Added Yohei Takeda <yo.tak0812@gmail.com>
	Used GitHub User @saitarunreddy (21041941) form for saitarunreddy <saitarunreddypalla@gmail.com> golang/build@269e03a [build]
	Used GitHub User @tell-k (26263) form for tell-k <ffk2005@gmail.com> golang/tools@85a87a8 [tools]
	Used GitHub name "Akhil Indurti" for smasher164 <aindurti@gmail.com> golang@a7af474 [build go]
	Used GitHub name "Guilherme Caruso" for GuilhermeCaruso <gui.martinscaruso@gmail.com> golang@5fae09b [go]
	Used GitHub name "Ivan Markin" for nogoegst <nogoegst@users.noreply.github.com> golang@a1addf1 [go]
	Used GitHub name "Keiji Yoshida" for yosssi <yoshida.keiji.84@gmail.com> golang/lint@ac6833c [lint]
	Used GitHub name "Marwan Sulaiman" for marwan-at-work <marwan.sameer@gmail.com> golang@92caeef [go]
	Used GitHub name "Michalis Kargakis" for kargakis <mkargaki@redhat.com> golang@e243d24 [go]
	Used GitHub name "Robin Eklind" for mewmew <rnd0x00@gmail.com> golang@b8620af [go proposal.git]
	Used GitHub name "Sean Chen" for two <oohcode@gmail.com> golang/sys@302c3dd [sys]
	Used GitHub name "Sebastien Williams-Wynn" for GiantsLoveDeathMetal <sebastien@cytora.com> golang@4e056ad [go]
	Used GitHub name "Yohei Takeda" for yo-tak <yo.tak0812@gmail.com> golang@8b7cf89 [go]

Given that the scope of updatecontrib is only to add contributors to
CONTRIBUTORS file, without having to check CLAs or deal with legal
matters, we can relax the requirement of having a space in the name
before it gets added to the CONTRIBUTORS file. That will be done
in a later change.

Updates golang#12042

Change-Id: I70248f3c82a836ee829256898e931e638ee45eb4
Reviewed-on: https://go-review.googlesource.com/c/160261
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>

nebulabox added a commit to nebulabox/go that referenced this issue Feb 20, 2019

CONTRIBUTORS: second round of updates for Go 1.12
This update has been automatically generated using the updatecontrib
command at CL 160277:

	cd gotip
	go run golang.org/x/build/cmd/updatecontrib

Actions taken (relative to CONTRIBUTORS at origin/master):

	Added Aaron Cannon <cannona@fireantproductions.com>
	Added Andzej Maciusovic <andzej.maciusovic@gmail.com>
	Added Douglas Danger Manley <doug.manley@gmail.com>
	Added Federico Bond <federicobond@gmail.com>
	Added Frew Schmidt <github@frew.co>
	Added GitHub User @saitarunreddy (21041941) <saitarunreddypalla@gmail.com>
	Added GitHub User @tell-k (26263) <ffk2005@gmail.com>
	Added Guilherme Caruso <gui.martinscaruso@gmail.com>
	Added Jay Taylor <outtatime@gmail.com>
	Added Juan Pablo Civile <elementohb@gmail.com>
	Added Julien Kauffmann <julien.kauffmann@freelan.org>
	Added Maya Rashish <maya@NetBSD.org>
	Added Parminder Singh <parmsingh101@gmail.com>
	Added Peter Dotchev <dotchev@gmail.com>
	Added Quinten Yearsley <qyearsley@chromium.org>
	Added Ross Smith II <ross@smithii.com>
	Added Sean Chen <oohcode@gmail.com>
	Added Sebastiaan van Stijn <github@gone.nl>
	Added Sebastian Schmidt <yath@google.com>
	Added Sebastien Williams-Wynn <sebastien@cytora.com>
	Added Viacheslav Poturaev <vearutop@gmail.com>
	Added Yohei Takeda <yo.tak0812@gmail.com>
	Used GitHub User @saitarunreddy (21041941) form for saitarunreddy <saitarunreddypalla@gmail.com> golang/build@269e03a [build]
	Used GitHub User @tell-k (26263) form for tell-k <ffk2005@gmail.com> golang/tools@85a87a8 [tools]
	Used GitHub name "Akhil Indurti" for smasher164 <aindurti@gmail.com> golang@a7af474 [build go]
	Used GitHub name "Guilherme Caruso" for GuilhermeCaruso <gui.martinscaruso@gmail.com> golang@5fae09b [go]
	Used GitHub name "Ivan Markin" for nogoegst <nogoegst@users.noreply.github.com> golang@a1addf1 [go]
	Used GitHub name "Keiji Yoshida" for yosssi <yoshida.keiji.84@gmail.com> golang/lint@ac6833c [lint]
	Used GitHub name "Marwan Sulaiman" for marwan-at-work <marwan.sameer@gmail.com> golang@92caeef [go]
	Used GitHub name "Michalis Kargakis" for kargakis <mkargaki@redhat.com> golang@e243d24 [go]
	Used GitHub name "Robin Eklind" for mewmew <rnd0x00@gmail.com> golang@b8620af [go proposal.git]
	Used GitHub name "Sean Chen" for two <oohcode@gmail.com> golang/sys@302c3dd [sys]
	Used GitHub name "Sebastien Williams-Wynn" for GiantsLoveDeathMetal <sebastien@cytora.com> golang@4e056ad [go]
	Used GitHub name "Yohei Takeda" for yo-tak <yo.tak0812@gmail.com> golang@8b7cf89 [go]

Given that the scope of updatecontrib is only to add contributors to
CONTRIBUTORS file, without having to check CLAs or deal with legal
matters, we can relax the requirement of having a space in the name
before it gets added to the CONTRIBUTORS file. That will be done
in a later change.

Updates golang#12042

Change-Id: I70248f3c82a836ee829256898e931e638ee45eb4
Reviewed-on: https://go-review.googlesource.com/c/160261
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
@dmitshur

This comment has been minimized.

Copy link
Member

dmitshur commented Feb 25, 2019

Second round is the last for 1.12. Moving to 1.13.

Edit: Keeping myself assigned to this issue to follow up with some improvements to updatecontrib tool.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.