Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

all: delete AUTHORS, CONTRIBUTORS files #53961

Closed
rsc opened this issue Jul 20, 2022 · 34 comments
Closed

all: delete AUTHORS, CONTRIBUTORS files #53961

rsc opened this issue Jul 20, 2022 · 34 comments
Assignees
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone

Comments

@rsc
Copy link
Contributor

rsc commented Jul 20, 2022

In 2009, Google's open-source lawyers required us to create the AUTHORS file to define "The Go Authors".

Re-reviewing our repos now in 2022, the open-source lawyers are comfortable with source control history serving that purpose instead, meaning that we are permitted to delete the AUTHORS and CONTRIBUTORS files from all the repos. I intend to do exactly that, which will let us close #12042 once and for all.

@rsc rsc added the NeedsFix The path to resolution is known, but the work has not been done. label Jul 20, 2022
@rsc rsc self-assigned this Jul 20, 2022
@mvdan
Copy link
Member

mvdan commented Jul 20, 2022

Out of curiosity, what about source archives where the source control history is missing? Are we OK with those not shipping with a definition of "The Go Authors"?

@rsc
Copy link
Contributor Author

rsc commented Jul 20, 2022

Legally speaking, yes, we are okay with that (that is, Google's lawyers tell me we are). The details of who owns what for copyright purposes are entirely independent of what the AUTHORS file says. Also we haven't even updated the AUTHORS file regularly since around Go 1.11 - see the top of https://tip.golang.org/AUTHORS.

https://google.github.io/opencasebook/authorship/ has a law school-style casebook about copyright authorship for anyone who is interested in a more in-depth introduction to the legal landscape. (And https://google.github.io/opencasebook/ has some other topics too.)

@gopherbot
Copy link
Contributor

Change https://go.dev/cl/418916 mentions this issue: A+C: delete AUTHORS and CONTRIBUTORS

@gopherbot
Copy link
Contributor

Change https://go.dev/cl/419074 mentions this issue: A+C: delete AUTHORS and CONTRIBUTORS

@gopherbot
Copy link
Contributor

Change https://go.dev/cl/418900 mentions this issue: A+C: delete AUTHORS and CONTRIBUTORS

@gopherbot
Copy link
Contributor

Change https://go.dev/cl/419094 mentions this issue: A+C: delete AUTHORS and CONTRIBUTORS

@gopherbot
Copy link
Contributor

Change https://go.dev/cl/418917 mentions this issue: A+C: delete AUTHORS and CONTRIBUTORS

@gopherbot
Copy link
Contributor

Change https://go.dev/cl/419095 mentions this issue: A+C: delete AUTHORS and CONTRIBUTORS

@gopherbot
Copy link
Contributor

Change https://go.dev/cl/419096 mentions this issue: A+C: delete AUTHORS and CONTRIBUTORS

@gopherbot
Copy link
Contributor

Change https://go.dev/cl/419097 mentions this issue: A+C: delete AUTHORS and CONTRIBUTORS

@gopherbot
Copy link
Contributor

Change https://go.dev/cl/419099 mentions this issue: A+C: delete AUTHORS and CONTRIBUTORS

@gopherbot
Copy link
Contributor

Change https://go.dev/cl/418918 mentions this issue: A+C: delete AUTHORS and CONTRIBUTORS

@gopherbot
Copy link
Contributor

Change https://go.dev/cl/419114 mentions this issue: A+C: delete AUTHORS and CONTRIBUTORS

@gopherbot
Copy link
Contributor

Change https://go.dev/cl/418919 mentions this issue: A+C: delete AUTHORS and CONTRIBUTORS

@gopherbot
Copy link
Contributor

Change https://go.dev/cl/418920 mentions this issue: A+C: delete AUTHORS and CONTRIBUTORS

@gopherbot
Copy link
Contributor

Change https://go.dev/cl/418903 mentions this issue: A+C: delete AUTHORS and CONTRIBUTORS

@gopherbot
Copy link
Contributor

Change https://go.dev/cl/418921 mentions this issue: A+C: delete AUTHORS and CONTRIBUTORS

@gopherbot
Copy link
Contributor

Change https://go.dev/cl/419101 mentions this issue: A+C: delete AUTHORS and CONTRIBUTORS

@gopherbot
Copy link
Contributor

Change https://go.dev/cl/419104 mentions this issue: A+C: delete AUTHORS and CONTRIBUTORS

@gopherbot
Copy link
Contributor

Change https://go.dev/cl/418922 mentions this issue: A+C: delete AUTHORS and CONTRIBUTORS

@gopherbot
Copy link
Contributor

Change https://go.dev/cl/418926 mentions this issue: A+C: delete AUTHORS and CONTRIBUTORS

@gopherbot
Copy link
Contributor

Change https://go.dev/cl/418925 mentions this issue: A+C: delete AUTHORS and CONTRIBUTORS

@gopherbot
Copy link
Contributor

Change https://go.dev/cl/419105 mentions this issue: A+C: delete AUTHORS and CONTRIBUTORS

@gopherbot
Copy link
Contributor

Change https://go.dev/cl/418923 mentions this issue: A+C: delete AUTHORS and CONTRIBUTORS

@gopherbot
Copy link
Contributor

Change https://go.dev/cl/418929 mentions this issue: A+C: delete AUTHORS and CONTRIBUTORS

@gopherbot
Copy link
Contributor

Change https://go.dev/cl/418930 mentions this issue: all: remove references to AUTHORS, CONTRIBUTORS files

@gopherbot
Copy link
Contributor

Change https://go.dev/cl/419075 mentions this issue: cmd/updatecontrib: delete

gopherbot pushed a commit to golang/vgo that referenced this issue Jul 22, 2022
In 2009, Google's open-source lawyers asked us to create the AUTHORS
file to define "The Go Authors", and the CONTRIBUTORS file was in
keeping with open source best practices of the time.

Re-reviewing our repos now in 2022, the open-source lawyers are
comfortable with source control history taking the place of the
AUTHORS file, and most open source projects no longer maintain
CONTRIBUTORS files.

To ease maintenance, remove AUTHORS and CONTRIBUTORS from all repos.

For golang/go#53961.

Change-Id: I15f0e3efdd1fdc70eb56520430f1a88a8e1042a2
Reviewed-on: https://go-review.googlesource.com/c/vgo/+/418926
Run-TryBot: Russ Cox <rsc@golang.org>
Reviewed-by: David Chase <drchase@google.com>
gopherbot pushed a commit to golang/tools that referenced this issue Jul 22, 2022
In 2009, Google's open-source lawyers asked us to create the AUTHORS
file to define "The Go Authors", and the CONTRIBUTORS file was in
keeping with open source best practices of the time.

Re-reviewing our repos now in 2022, the open-source lawyers are
comfortable with source control history taking the place of the
AUTHORS file, and most open source projects no longer maintain
CONTRIBUTORS files.

To ease maintenance, remove AUTHORS and CONTRIBUTORS from all repos.

For golang/go#53961.

Change-Id: Icaaaf04cc7884b479c7fd1231c53c8bf1f349623
Reviewed-on: https://go-review.googlesource.com/c/tools/+/419105
gopls-CI: kokoro <noreply+kokoro@google.com>
Run-TryBot: Russ Cox <rsc@golang.org>
Reviewed-by: David Chase <drchase@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
gopherbot pushed a commit to golang/website that referenced this issue Jul 22, 2022
Also fix unnecessary capitalization in blog/experiment.md.

For golang/go#53961.

Change-Id: Ief95e4cdd2085c081a4ad97ffc8678db75bfce69
Reviewed-on: https://go-review.googlesource.com/c/website/+/418930
Reviewed-by: David Chase <drchase@google.com>
Run-TryBot: Russ Cox <rsc@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
gopherbot pushed a commit that referenced this issue Jul 22, 2022
In 2009, Google's open-source lawyers asked us to create the AUTHORS
file to define "The Go Authors", and the CONTRIBUTORS file was in
keeping with open source best practices of the time.

Re-reviewing our repos now in 2022, the open-source lawyers are
comfortable with source control history taking the place of the
AUTHORS file, and most open source projects no longer maintain
CONTRIBUTORS files.

To ease maintenance, remove AUTHORS and CONTRIBUTORS from all repos.

For #53961.

Change-Id: I332327afb49c45d54e71e018193fb18b09e5d91a
Reviewed-on: https://go-review.googlesource.com/c/go/+/419114
Reviewed-by: David Chase <drchase@google.com>
Run-TryBot: Russ Cox <rsc@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
@rsc
Copy link
Contributor Author

rsc commented Jul 22, 2022

Done.

@rsc rsc closed this as completed Jul 22, 2022
gopherbot pushed a commit to golang/build that referenced this issue Jul 22, 2022
The CONTRIBUTORS files are being deleted from Go repositories as part of
go.dev/issue/53961, so the updatecontrib tool won't be needed anymore.

For golang/go#53961.
For golang/go#12042.

Change-Id: I800ed7bcb32fd5b7effd9f74cefa2302ba9e8612
Reviewed-on: https://go-review.googlesource.com/c/build/+/419075
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Russ Cox <rsc@golang.org>
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
gopherbot pushed a commit to golang/website that referenced this issue Jul 22, 2022
In 2009, Google's open-source lawyers asked us to create the AUTHORS
file to define "The Go Authors", and the CONTRIBUTORS file was in
keeping with open source best practices of the time.

Re-reviewing our repos now in 2022, the open-source lawyers are
comfortable with source control history taking the place of the
AUTHORS file, and most open source projects no longer maintain
CONTRIBUTORS files.

To ease maintenance, remove AUTHORS and CONTRIBUTORS from all repos.

For golang/go#53961.

Change-Id: Ib2124d3938974d1155b8c7ff50505bef3ac1d79d
Reviewed-on: https://go-review.googlesource.com/c/website/+/418929
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: David Chase <drchase@google.com>
Run-TryBot: Russ Cox <rsc@golang.org>
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
@dmitshur dmitshur added this to the Go1.19 milestone Jul 23, 2022
@nightlyone
Copy link
Contributor

@rsc That is a very sad move.

Now it becomes much harder to prove you did contributions in the past. Instead of sending a link you now have to ask your future employer to run a shell script on his windows(?) machine to prove your contribution. Oh and existing links in existing reference documents probably just broke.

It also makes it even harder to prove that this contribution was done by you and not someone else after you loose access to your company mail, google closes gmail (not unlikely given past product decisions) or loose access to your university mail.

The previous authors/contributors file allowed adding additional emails for an author/contributor after job changes, company mergers/acquisitions, re-branding, change of your free mail provider etc.

All that is lost for the benefit of one script-run less every 3-6 months and a few hours of odd changes every 3-6 months.

Are you sure benefits and costs for the projects and contributors are well weighted here?

Would you at least consider to provide the same information pre-aggregated under a permanent website link out of respect for your previous contributors?

@gopherbot
Copy link
Contributor

Change https://go.dev/cl/418932 mentions this issue: _content: add AUTHORS page, and CONTRIBUTORS redirect

@rsc
Copy link
Contributor Author

rsc commented Jul 25, 2022

Thanks for pointing out the broken links. I have created a new page in https://go.dev/cl/418932. I don't follow about the asking future employers to run a shell script. There are plenty of ways to look at the Git commit history online. I linked how to do it from Gerrit in the new AUTHORS page.

gopherbot pushed a commit to golang/website that referenced this issue Jul 25, 2022
Now that there's no AUTHORS file, go.dev/AUTHORS will become a dead link
as of Go 1.19, and tip.golang.org/AUTHORS is already one.
Write a page to keep those links not 404-ing.

Same is true for CONTRIBUTORS; redirect to AUTHORS.

For golang/go#53961.

Change-Id: I17cc932f3f870bf4b9970151ead4b5e72a94845b
Reviewed-on: https://go-review.googlesource.com/c/website/+/418932
Run-TryBot: Russ Cox <rsc@golang.org>
Reviewed-by: Ian Lance Taylor <iant@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
hajimehoshi added a commit to ebitengine/oto that referenced this issue Jul 30, 2022
hajimehoshi added a commit to hajimehoshi/ebiten that referenced this issue Jul 31, 2022
realqhc pushed a commit to realqhc/gofrontend that referenced this issue Aug 4, 2022
In 2009, Google's open-source lawyers asked us to create the AUTHORS
file to define "The Go Authors", and the CONTRIBUTORS file was in
keeping with open source best practices of the time.

Re-reviewing our repos now in 2022, the open-source lawyers are
comfortable with source control history taking the place of the
AUTHORS file, and most open source projects no longer maintain
CONTRIBUTORS files.

To ease maintenance, remove AUTHORS and CONTRIBUTORS from all repos.

For golang/go#53961.

Change-Id: Ic5770c342c5862deb61b48864777dab70a779db0
Reviewed-on: https://go-review.googlesource.com/c/gofrontend/+/419097
Run-TryBot: Russ Cox <rsc@golang.org>
Reviewed-by: David Chase <drchase@google.com>
jproberts pushed a commit to jproberts/go that referenced this issue Aug 10, 2022
In 2009, Google's open-source lawyers asked us to create the AUTHORS
file to define "The Go Authors", and the CONTRIBUTORS file was in
keeping with open source best practices of the time.

Re-reviewing our repos now in 2022, the open-source lawyers are
comfortable with source control history taking the place of the
AUTHORS file, and most open source projects no longer maintain
CONTRIBUTORS files.

To ease maintenance, remove AUTHORS and CONTRIBUTORS from all repos.

For golang#53961.

Change-Id: I332327afb49c45d54e71e018193fb18b09e5d91a
Reviewed-on: https://go-review.googlesource.com/c/go/+/419114
Reviewed-by: David Chase <drchase@google.com>
Run-TryBot: Russ Cox <rsc@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
golightlyb added a commit to tawesoft/golib that referenced this issue Aug 31, 2022
@proggga
Copy link
Contributor

proggga commented Sep 9, 2022

Totally agree with nightlyone, sad move. Also helps you to prove that you are helping community + helps in interview

@rsc
Copy link
Contributor Author

rsc commented Sep 9, 2022

@progga, did you see the page I added at https://go.dev/AUTHORS and in particular the sample search query? I think that should serve the same purposes.

@AlekSi
Copy link
Contributor

AlekSi commented Oct 5, 2022

Another option is to use GitHub:

xhit pushed a commit to xhit/text that referenced this issue Oct 10, 2022
In 2009, Google's open-source lawyers asked us to create the AUTHORS
file to define "The Go Authors", and the CONTRIBUTORS file was in
keeping with open source best practices of the time.

Re-reviewing our repos now in 2022, the open-source lawyers are
comfortable with source control history taking the place of the
AUTHORS file, and most open source projects no longer maintain
CONTRIBUTORS files.

To ease maintenance, remove AUTHORS and CONTRIBUTORS from all repos.

For golang/go#53961.

Change-Id: I3abeb5f16d9a9446e16a3a5318d22a9c622db0b6
Reviewed-on: https://go-review.googlesource.com/c/text/+/418923
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: David Chase <drchase@google.com>
Run-TryBot: Russ Cox <rsc@golang.org>
maisem pushed a commit to tailscale/golang-x-crypto that referenced this issue Nov 15, 2022
In 2009, Google's open-source lawyers asked us to create the AUTHORS
file to define "The Go Authors", and the CONTRIBUTORS file was in
keeping with open source best practices of the time.

Re-reviewing our repos now in 2022, the open-source lawyers are
comfortable with source control history taking the place of the
AUTHORS file, and most open source projects no longer maintain
CONTRIBUTORS files.

To ease maintenance, remove AUTHORS and CONTRIBUTORS from all repos.

For golang/go#53961.

Change-Id: Ieb32933de4f234c77f0131490d4081b6c336820c
Reviewed-on: https://go-review.googlesource.com/c/crypto/+/419094
Run-TryBot: Russ Cox <rsc@golang.org>
Reviewed-by: David Chase <drchase@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
maisem pushed a commit to tailscale/golang-x-crypto that referenced this issue Nov 15, 2022
In 2009, Google's open-source lawyers asked us to create the AUTHORS
file to define "The Go Authors", and the CONTRIBUTORS file was in
keeping with open source best practices of the time.

Re-reviewing our repos now in 2022, the open-source lawyers are
comfortable with source control history taking the place of the
AUTHORS file, and most open source projects no longer maintain
CONTRIBUTORS files.

To ease maintenance, remove AUTHORS and CONTRIBUTORS from all repos.

For golang/go#53961.

Change-Id: Ieb32933de4f234c77f0131490d4081b6c336820c
Reviewed-on: https://go-review.googlesource.com/c/crypto/+/419094
Run-TryBot: Russ Cox <rsc@golang.org>
Reviewed-by: David Chase <drchase@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
WeiminShang added a commit to WeiminShang/net that referenced this issue Nov 16, 2022
In 2009, Google's open-source lawyers asked us to create the AUTHORS
file to define "The Go Authors", and the CONTRIBUTORS file was in
keeping with open source best practices of the time.

Re-reviewing our repos now in 2022, the open-source lawyers are
comfortable with source control history taking the place of the
AUTHORS file, and most open source projects no longer maintain
CONTRIBUTORS files.

To ease maintenance, remove AUTHORS and CONTRIBUTORS from all repos.

For golang/go#53961.

Change-Id: I2b96a857eec7ee44c58d8a8b1ff2d0bf5f0c2847
Reviewed-on: https://go-review.googlesource.com/c/net/+/418919
Reviewed-by: David Chase <drchase@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Russ Cox <rsc@golang.org>
LewiGoddard added a commit to LewiGoddard/crypto that referenced this issue Feb 16, 2023
In 2009, Google's open-source lawyers asked us to create the AUTHORS
file to define "The Go Authors", and the CONTRIBUTORS file was in
keeping with open source best practices of the time.

Re-reviewing our repos now in 2022, the open-source lawyers are
comfortable with source control history taking the place of the
AUTHORS file, and most open source projects no longer maintain
CONTRIBUTORS files.

To ease maintenance, remove AUTHORS and CONTRIBUTORS from all repos.

For golang/go#53961.

Change-Id: Ieb32933de4f234c77f0131490d4081b6c336820c
Reviewed-on: https://go-review.googlesource.com/c/crypto/+/419094
Run-TryBot: Russ Cox <rsc@golang.org>
Reviewed-by: David Chase <drchase@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
BiiChris pushed a commit to BiiChris/crypto that referenced this issue Sep 15, 2023
In 2009, Google's open-source lawyers asked us to create the AUTHORS
file to define "The Go Authors", and the CONTRIBUTORS file was in
keeping with open source best practices of the time.

Re-reviewing our repos now in 2022, the open-source lawyers are
comfortable with source control history taking the place of the
AUTHORS file, and most open source projects no longer maintain
CONTRIBUTORS files.

To ease maintenance, remove AUTHORS and CONTRIBUTORS from all repos.

For golang/go#53961.

Change-Id: Ieb32933de4f234c77f0131490d4081b6c336820c
Reviewed-on: https://go-review.googlesource.com/c/crypto/+/419094
Run-TryBot: Russ Cox <rsc@golang.org>
Reviewed-by: David Chase <drchase@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
@golang golang locked and limited conversation to collaborators Oct 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Development

No branches or pull requests

7 participants