Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

godoc: Doesn't handle repos with no master #15580

Closed
bep opened this issue May 6, 2016 · 5 comments
Closed

godoc: Doesn't handle repos with no master #15580

bep opened this issue May 6, 2016 · 5 comments

Comments

@bep
Copy link
Contributor

bep commented May 6, 2016

@kr has created a "left-pad npm like" situation by deleting the master branch in https://github.com/kr/text -- that works in Go 1.6, but not in Go 1.5.4.

I wish that fix had been backported, but you should at least have a look at the logic behind:

https://godoc.org/github.com/kr/text

(I assume godoc.org is backed by you)

@minux
Copy link
Member

minux commented May 6, 2016 via email

@bep
Copy link
Contributor Author

bep commented May 6, 2016

What's the rationale behind deleting the master branch?

Vanity? But it sure gets people to look hard at vendoring.

@kr
Copy link
Contributor

kr commented May 7, 2016

Please see golang/gddo#405

@bep
Copy link
Contributor Author

bep commented May 7, 2016

@kr not sure what point you are trying to make here ...

... but if you can confirm that you have no intention to reintroduce the master branch, I will have to fork your repo and try to patch up my stuff.

@cespare
Copy link
Contributor

cespare commented May 7, 2016

It seems reasonable that tools should use the default branch even if it's not master. Since the go tool already does and there's a separate gddo issue, I think there's nothing to be done here and this issue should be closed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants