Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go/build: permit vendoring golang.org from std without breaking users #17326

Closed
bradfitz opened this issue Oct 3, 2016 · 1 comment
Closed

go/build: permit vendoring golang.org from std without breaking users #17326

bradfitz opened this issue Oct 3, 2016 · 1 comment
Labels
early-in-cycle A change that should be done early in the 3 month dev cycle. FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Go1.12

Comments

@bradfitz
Copy link
Contributor

bradfitz commented Oct 3, 2016

In #16333 a user reported that they were unable to vendor code which the Go standard library itself vendored.

To "fix" the problem for the 1.7 release, we renamed the "$GOROOT/src/vendor/golang.org" directory to "golang_org" with an underscore, so it wouldn't conflict with users.

This is slightly annoying for us to maintain in the stdlib.

We should probably fix it properly in go/build and/or cmd/go.

/cc @ianlancetaylor @rsc
@bradfitz bradfitz added this to the Go1.8 milestone Oct 3, 2016
@quentinmit quentinmit added the NeedsFix The path to resolution is known, but the work has not been done. label Oct 7, 2016
@quentinmit quentinmit mentioned this issue Oct 24, 2016
Closed
@rsc rsc modified the milestones: Go1.9Early, Go1.8 Oct 26, 2016
@bradfitz bradfitz mentioned this issue Apr 24, 2017
Closed
@bradfitz bradfitz modified the milestones: Go1.10Early, Go1.9Early May 3, 2017
@bradfitz bradfitz mentioned this issue May 23, 2017
Closed
@bradfitz bradfitz added early-in-cycle A change that should be done early in the 3 month dev cycle. and removed early-in-cycle A change that should be done early in the 3 month dev cycle. labels Jun 14, 2017
@bradfitz bradfitz modified the milestones: Go1.10Early, Go1.10 Jun 14, 2017
@rsc rsc modified the milestones: Go1.10, Go1.11 Nov 22, 2017
@bradfitz bradfitz mentioned this issue Feb 13, 2018
Closed
@elldritch elldritch mentioned this issue Mar 19, 2018
Closed
@WillAbides WillAbides mentioned this issue May 21, 2018
Merged
@ianlancetaylor ianlancetaylor modified the milestones: Go1.11, Go1.12 Jun 23, 2018
@ianlancetaylor
Copy link
Contributor

The standard library no longer has a top level vendor directory. The contents have moved to internal/x to fix #26988 and #27285. I think that fixes this problem, so closing.

@chrismwendt chrismwendt mentioned this issue Jan 23, 2019
Merged
@golang golang locked and limited conversation to collaborators Dec 12, 2019
@rsc rsc removed their assignment Jun 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
early-in-cycle A change that should be done early in the 3 month dev cycle. FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Go1.12
Development

No branches or pull requests
5 participants
@bradfitz @rsc @quentinmit @ianlancetaylor @gopherbot