New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/build: permit vendoring golang.org from std without breaking users #17326

Closed
bradfitz opened this Issue Oct 3, 2016 · 1 comment

Comments

Projects
None yet
4 participants
@bradfitz
Member

bradfitz commented Oct 3, 2016

In #16333 a user reported that they were unable to vendor code which the Go standard library itself vendored.

To "fix" the problem for the 1.7 release, we renamed the "$GOROOT/src/vendor/golang.org" directory to "golang_org" with an underscore, so it wouldn't conflict with users.

This is slightly annoying for us to maintain in the stdlib.

We should probably fix it properly in go/build and/or cmd/go.

/cc @ianlancetaylor @rsc

@ianlancetaylor

This comment has been minimized.

Contributor

ianlancetaylor commented Dec 12, 2018

The standard library no longer has a top level vendor directory. The contents have moved to internal/x to fix #26988 and #27285. I think that fixes this problem, so closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment