Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reflect: StructOf should support embedding types with non-exported methods #20015

Open
mdempsky opened this issue Apr 17, 2017 · 3 comments
Open

reflect: StructOf should support embedding types with non-exported methods #20015

mdempsky opened this issue Apr 17, 2017 · 3 comments
Labels
help wanted NeedsFix
Milestone

Comments

@mdempsky
Copy link
Member

@mdempsky mdempsky commented Apr 17, 2017

There's this code in reflect/type.go:

                                    if ift.nameOff(m.name).pkgPath() != "" {
                                            // TODO(sbinet)
                                            panic("reflect: embedded interface with unexported method(s) not implemented")
                                    }

See also #5748.

@bradfitz bradfitz added this to the Unplanned milestone Apr 17, 2017
@bradfitz bradfitz added NeedsFix help wanted labels Apr 17, 2017
@rberenguel
Copy link

@rberenguel rberenguel commented Aug 10, 2017

How hard do you reckon this to be @bradfitz @mdempsky ? I'm vaguely familiar with the internals of reflect already (had to do something weird recently and explored it a lot for inspiration), so would love a try if possible to improve my understanding of it.

@ianlancetaylor
Copy link
Contributor

@ianlancetaylor ianlancetaylor commented Aug 11, 2017

@rberenguel It would be great if you want to work on this, but unfortunately I think it will be pretty hard.

@rberenguel
Copy link

@rberenguel rberenguel commented Aug 12, 2017

Thanks @ianlancetaylor a bad choice then for the first contribution. I'll keep looking!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted NeedsFix
Projects
None yet
Development

No branches or pull requests

4 participants