x/crypto/ssh/terminal: GetSize doesn't work on Windows?

[gbraad]

What version of Go are you using (go version)?

go1.7.5

What operating system and processor architecture are you using (go env)?

Compared functionality between two platforms:
go on linux/amd64
go on windows/amd64

What did you do?

I am doing the following:

	fd := int(os.Stdin.Fd())

	termWidth, termHeight, err := terminal.GetSize(fd)
	if err != nil {
		return "", err
	}

on Linux, which returns me the correct size of the terminal when using for instance bash. However, this same call will fail on Windows cmd and powershell with an "invalid handle" error.

It seems that "golang.org/x/crypto/ssh/terminal" can not succesfully perform the following function:

func GetSize(fd int) (width, height int, err error)

More information about this can be found at: minishift/minishift-centos-iso#95 (comment) and minishift/minishift-centos-iso#95 (comment). This seems to be an issue when using Red Hat's provided ssh server with the go native implementation: docker/machine#3937

What did you expect to see?

I expected the command to pass

What did you see instead?

At the moment it fails with an invalid handle.

[bradfitz]

I don't understand the bug report.

The Windows code doesn't involve an ioctl. The Windows code is many years old at this point and in util_windows.go:

func GetSize(fd int) (width, height int, err error) {
        var info consoleScreenBufferInfo
        _, _, e := syscall.Syscall(procGetConsoleScreenBufferInfo.Addr(), 2, uintptr(fd), uintptr(unsafe.Pointer(&info)), 0)
        if e != 0 {
                return 0, 0, error(e)
        }
        return int(info.size.x), int(info.size.y), nil
}

What is fd := int(os.Stdin.Fd()) on Windows? Is that valid for GetConsoleScreenBufferInfo?

/cc @alexbrainman

[gbraad]

Will debug util_windows.go. (IDE redirect to the general util.go)

The value I got for the fd was 8 for my PowerShell, and 80 for a cmd instance. Creating a new cmd, returns a different fd (76) for cmd. But all of the calls return "The handle is invalid." as error.

[alexbrainman]

fd := int(os.Stdin.Fd())

Looking at an example https://msdn.microsoft.com/en-us/library/windows/desktop/ms685118(v=vs.85).aspx - the example calls GetStdHandle(STD_OUTPUT_HANDLE) to get the handle. So, I suppose, you should use os.Stdout.Fd() instead.

I am not sure if that is the intended behavior.

Alex

[gbraad]

Works as expected with doing:

        fd := int(os.Stdout.Fd())
	termWidth, termHeight, err := terminal.GetSize(fd)

pushing a change to libmachine for this. Cheers