Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build/cmd/releasebot: build releases regularly, automatically #29205

Open
bradfitz opened this issue Dec 12, 2018 · 8 comments
Open

x/build/cmd/releasebot: build releases regularly, automatically #29205

bradfitz opened this issue Dec 12, 2018 · 8 comments
Assignees
Milestone

Comments

@bradfitz
Copy link
Contributor

@bradfitz bradfitz commented Dec 12, 2018

Every release comes with surprises/problems with releasebot.

If releasebot was always running it would be less scary and prone to breakage.

Or we'd catch problems earlier.

We should be building automatic unsigned releases all the time. (at least daily, if not hourly)

/cc @dmitshur @andybons @bcmills @toothrot @cagedmantis

@gopherbot gopherbot added this to the Unreleased milestone Dec 12, 2018
@gopherbot gopherbot added the Builders label Dec 12, 2018
@bcmills
Copy link
Member

@bcmills bcmills commented Dec 12, 2018

Some open-source projects release continuous “nightly” pre-release builds. Perhaps we could do the same?

@bradfitz
Copy link
Contributor Author

@bradfitz bradfitz commented Dec 13, 2018

That's basically what I said above ("at least daily, if not hourly")

But we could even go one further: we move the cmd/release + releaselet code into a package used by the coordinator and run it on every post-submit build and save the results to GCS (like we already do post-make.bash).

Then x/build/cmd/release basically does nothing except wait for the unsigned build to finish building normally and then pulls the unsigned builds from GCS for signing and uploads them to the right place post-signing.

Then the golang.org/dl/ handler could be modified to have some ?mode=nightly view that shows the recent unsigned binaries/installers served directly from the existing GCS snapshots.

@smasher164
Copy link
Member

@smasher164 smasher164 commented Oct 14, 2019

I think that this process is key to reducing the number of minor revisions. 1.11 and 1.12 have had the greatest number of minor revisions, so it looks like the trend has been that the number increases with every major release.

@andybons
Copy link
Member

@andybons andybons commented Oct 15, 2019

@smasher164 we switched to doing monthly point releases during that time, so it's an unrelated metric.

@smasher164

This comment was marked as off-topic.

@gopherbot
Copy link

@gopherbot gopherbot commented Apr 22, 2020

Change https://golang.org/cl/229483 mentions this issue: cmd/golangorg: generate major version list on Go project page

@gopherbot
Copy link

@gopherbot gopherbot commented Apr 22, 2020

Change https://golang.org/cl/229482 mentions this issue: content/static/doc: copy The Go Project page (contrib.html) from Go repo

gopherbot pushed a commit to golang/website that referenced this issue Apr 24, 2020
The Go Project page is copied from Go master as of 2020/04/24
(commit golang/go@ee8972c, CL 209679).

This page not closely tied to specific Go releases, and thus is better
suited to live in the x/website repo.

It will be modified in CL 229483 to use the release history data from
the internal/history package, rather than using hand-written HTML
which needs to be updated manually after each major Go release.

For golang/go#29205.
For golang/go#29206.

Change-Id: I6a6fa734fb3d873da59d67d796616fc53d684610
Reviewed-on: https://go-review.googlesource.com/c/website/+/229482
Reviewed-by: Alexander Rakoczy <alex@golang.org>
gopherbot pushed a commit to golang/website that referenced this issue Apr 24, 2020
This change builds on what was done in CL 229081, and uses the Go
release history data from internal/history package to generate the
list of major Go versions on the Go project page.

This way, this page doesn't need to be manually edited when major
Go releases are made.

For golang/go#38488.
For golang/go#29205.
For golang/go#29206.

Change-Id: Ie0b12707d828207173a54f0a1bc6a4ef69dcedef
Reviewed-on: https://go-review.googlesource.com/c/website/+/229483
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Alexander Rakoczy <alex@golang.org>
@gopherbot
Copy link

@gopherbot gopherbot commented Jul 28, 2020

Change https://golang.org/cl/245277 mentions this issue: maintner/maintnerd/maintapi/version: support beta and RC release tags

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
7 participants
You can’t perform that action at this time.