Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/perf/benchstat: add -metrics=speed,alloc/op flag #30368

Open
nigeltao opened this issue Feb 23, 2019 · 2 comments

Comments

@nigeltao
Copy link
Contributor

commented Feb 23, 2019

benchstat reports a number of metrics:

  • alloc/op
  • speed
  • time/GC
  • time/op

In my automated reports, I'm only interested in a subset of those, even if the underlying source files provide more than that.

Would you (@aclements) accept a patch so that I can say benchstat -metrics=speed,alloc/op?

Right now, I can workaround it with piping benchstat's output through sed. It's not that onerous, but if others might find it useful, it's possibly a little cleaner to do it in benchstat itself.

@gopherbot gopherbot added this to the Unreleased milestone Feb 23, 2019

@bcmills

This comment has been minimized.

Copy link
Member

commented Feb 28, 2019

@josharian

This comment has been minimized.

Copy link
Contributor

commented Feb 28, 2019

Sounds fine to me, but I think this is Austin's call.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.