Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
net/http: document that context cancellation does not apply to writable bodies #30876
To enable http.ReverseProxy to cleanly support websocket connections, http.Transport began returning writable response bodies.
This is documented. But what's undocumented is how this response body deals with the request context's cancellation.
Right now, the documentation says the cancellation of the request context will cause the response body to close, even if it is writable. However, this is not the case. If a writable response body is returned, cancellation of the request context does not affect it. This is certainly the right behaviour but should be documented.
referenced a pull request that will
Mar 16, 2019
If you use this feature to do a WebSocket handshake, you will want to have a timeout on the handshake but not on the connection afterwards as WebSocket's can be long lived. Its best to let the caller handle timeouts via the Close method on the returned body.
If the context applied on the returned body for upgraded requests, it would become impossible to cleanly set a timeout on the handshake but not the body.
I definitely do see how this could be unexpected as a server could make client code hang if it returns an unexpected upgrade response..
I think the solution here is to only return a writable body if the request is a upgrade request as well, meaning the client understands the body will be writable and not affected by the request context.