Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: fix, stabilize netbsd/386 port #31726

Open
4a6f656c opened this issue Apr 28, 2019 · 10 comments

Comments

@4a6f656c
Copy link
Contributor

commented Apr 28, 2019

There has not seemingly been a netbsd/386 builder for a number of years - given that a builder is a requirement for a port, is it time to remove netbsd/386?

https://github.com/golang/go/wiki/PortingPolicy

@bradfitz

This comment has been minimized.

Copy link
Member

commented Apr 29, 2019

We have plenty of x86 compute resources to run a netbsd-386 builder and we used to run one.

The builder's not the issue.

The issue was that the builder was super flaky, IIRC. (There are probably old bugs about turning it off and its flakes)

I'd rather see some attention paid to fixing it up.

@krytarowski

This comment has been minimized.

Copy link
Contributor

commented Apr 30, 2019

netbsd/386 builder for a number of years like.. 1 year?

@krytarowski

This comment has been minimized.

Copy link
Contributor

commented Apr 30, 2019

golang for i386 has some users and it works good enough, but some corner cases are flaky.

@bradfitz

This comment has been minimized.

Copy link
Member

commented Apr 30, 2019

I just tried to run the builder. It hangs somewhere in the runtime tests ("go test -short runtime").

@krytarowski, I'm happy to re-enable the builder if you can even get it to 50% reliably passing, as long as it doesn't hang.

@bradfitz

This comment has been minimized.

Copy link
Member

commented Apr 30, 2019

Previously: #25206 in which @bsiegert said it was passing. Maybe not on GCE?

@bradfitz bradfitz added the OS-NetBSD label Apr 30, 2019

@bradfitz bradfitz changed the title all: remove netbsd/386 port? build: fix, stabilize netbsd/386 port Apr 30, 2019

@gopherbot

This comment has been minimized.

Copy link

commented Apr 30, 2019

Change https://golang.org/cl/174637 mentions this issue: dashboard: add darwin-amd64-nocgo config, remove nacl-386 trybot

gopherbot pushed a commit to golang/build that referenced this issue Apr 30, 2019
dashboard: add darwin-amd64-nocgo config, remove nacl-386 trybot
Also remove dead nacl-arm. It hasn't run in ages.

And update netbsd comment about why 386 doesn't run. And correct its
VM image name.

Updates golang/go#31705
Updates golang/go#31726

Change-Id: I9de4605f34a052d0a84684fca098388d75602a82
Reviewed-on: https://go-review.googlesource.com/c/build/+/174637
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
@krytarowski

This comment has been minimized.

Copy link
Contributor

commented May 1, 2019

I'm still busy with !golang so cannot make any promises myself.

@bsiegert

This comment has been minimized.

Copy link
Contributor

commented May 3, 2019

And it still passes, I tried in VirtualBox yesterday.

Given how close we are to branching NetBSD 9, maybe running the 386 builder on -current would make sense?

@bradfitz

This comment has been minimized.

Copy link
Member

commented May 3, 2019

And it still passes, I tried in VirtualBox yesterday.

Did you test 8 or current?

8 on GCE doesn't work. I tried 3 days ago (see above).

@krytarowski

This comment has been minimized.

Copy link
Contributor

commented May 3, 2019

Using HEAD / -9 is a good idea. There were many improvements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.