Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
x/build/cmd/coordinator: add control over build mode in subrepos with directory granularity #34190
Some subrepos, such as
We should add support for this to the coordinator. I've started the work.
I plan to make it something we configure in code in
I've tested this change on CL 191018 by restarting trybots just now, and watched the build logs very closely. So far, everything is looking good and working as intended.
It correctly determined the build mode as GOPATH mode for the "linux-amd64 (Go 1.12.x)" builder, and as module mode for all other builders (since they're running Go 1.13 and newer, and x/tools repo has a go.mod file at root).
Here are build logs for various builds of the successful trybot run:
linux-386 (Go tip) - tests ran in module mode
linux-amd64 (Go 1.13.x) - tests ran in module mode
linux-amd64 (Go 1.12.x) - tests ran in GOPATH mode with x/tools/gopls directory skipped
linux-amd64-race (Go tip) - ran in module mode
windows-386-2008 (Go tip) - ran in module mode
android-amd64-emu (Go tip) - ran in module mode
Notably, in the "linux-amd64 (Go 1.12.x)" build where tests ran in GOPATH mode, the
I'll also watch the post-submit builders to make sure nothing unexpected happens there.
There was a minor issue affecting the "build", "oauth2", "website", and "perf" repos being misdetected as being tested in GOPATH mode, while in reality they're always tested in module mode. It was fixed in Patch Set 8 of CL 194277. I've verified that the fix is working as expected.