Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build/cmd/coordinator: add control over build mode in subrepos with directory granularity #34190

Closed
dmitshur opened this issue Sep 9, 2019 · 4 comments

Comments

@dmitshur
Copy link
Member

commented Sep 9, 2019

cmd/coordinator already has support for running tests in module mode for some subrepos. For example, it's currently used for oauth2, build, perf, and website subrepos:

https://github.com/golang/build/blob/a2cf19446e2ca6ac8153b261ab49f9be9394b5f4/dashboard/builders.go#L733-L734

Some subrepos, such as x/tools, want to be able to mark parts of the subrepo as module-only, while still maintaining both GOPATH and module mode coverage for the rest of the subrepo. This will allow said subrepos to continue to benefit from test coverage by trybots and builders, without forcing them to support GOPATH mode in internal areas where it isn't worthwhile (e.g., the nested gopls module).

We should add support for this to the coordinator. I've started the work.

/cc @toothrot @andybons @bradfitz @ianthehat

Plan

I plan to make it something we configure in code in x/build/dashboard, since it's not expected to change very often. It will be a change to the algorithm in buildStatus.runSubrepoTests that will use the data from the dashboard.

This is related to issues #32528 and #32528 (work on this one will make those easier to resolve too).

@dmitshur dmitshur self-assigned this Sep 9, 2019

@gopherbot gopherbot added this to the Unreleased milestone Sep 9, 2019

@dmitshur dmitshur changed the title x/build/cmd/coordinator: add ability to control build mode within subrepos x/build/cmd/coordinator: add control over build mode in subrepos with directory granularity Sep 9, 2019

@gopherbot

This comment has been minimized.

Copy link

commented Sep 9, 2019

Change https://golang.org/cl/194277 mentions this issue: cmd/coordinator: detect current build mode in subrepo tests

@gopherbot

This comment has been minimized.

Copy link

commented Sep 9, 2019

Change https://golang.org/cl/194397 mentions this issue: dashboard, cmd/coordinator: add controls to skip subrepo dirs in GOPATH mode

@dmitshur

This comment has been minimized.

Copy link
Member Author

commented Sep 11, 2019

I've tested this change on CL 191018 by restarting trybots just now, and watched the build logs very closely. So far, everything is looking good and working as intended.

It correctly determined the build mode as GOPATH mode for the "linux-amd64 (Go 1.12.x)" builder, and as module mode for all other builders (since they're running Go 1.13 and newer, and x/tools repo has a go.mod file at root).

Here are build logs for various builds of the successful trybot run:

linux-386 (Go tip) - tests ran in module mode
  builder: linux-386
      rev: 0e015e20cfe7265635af605d274ff8dc2de5b3a2
 buildlet: http://10.240.0.220 GCE VM: buildlet-linux-jessie-rn6b1b79e
  started: 2019-09-11 13:46:08.196523606 +0000 UTC m=+282.899161438
   status: still running

Events:
  2019-09-11T13:46:08Z checking_for_snapshot 
  2019-09-11T13:46:08Z finish_checking_for_snapshot after 12.9ms
  2019-09-11T13:46:08Z get_buildlet 
  2019-09-11T13:46:08Z awaiting_gce_quota 
  2019-09-11T13:46:08Z finish_awaiting_gce_quota after 0s
  2019-09-11T13:46:08Z create_gce_buildlet buildlet-linux-jessie-rn6b1b79e
  2019-09-11T13:46:08Z create_gce_instance buildlet-linux-jessie-rn6b1b79e
  2019-09-11T13:46:18Z finish_create_gce_instance after 10.2s; buildlet-linux-jessie-rn6b1b79e
  2019-09-11T13:46:18Z wait_buildlet_start buildlet-linux-jessie-rn6b1b79e
  2019-09-11T13:46:19Z got_instance_info waiting_for_buildlet...
  2019-09-11T13:47:00Z finish_wait_buildlet_start after 42s; buildlet-linux-jessie-rn6b1b79e
  2019-09-11T13:47:00Z finish_create_gce_buildlet after 52.4s; buildlet-linux-jessie-rn6b1b79e
  2019-09-11T13:47:01Z finish_get_buildlet after 52.5s
  2019-09-11T13:47:01Z using_buildlet 10.240.0.220:80
  2019-09-11T13:47:01Z write_snapshot_tar 
  2019-09-11T13:47:05Z finish_write_snapshot_tar after 3.85s
  2019-09-11T13:47:05Z make_and_test 
  2019-09-11T13:47:05Z fetching_subrepo tools
  2019-09-11T13:47:05Z get_source 
  2019-09-11T13:47:05Z finish_get_source after 0s
  2019-09-11T13:47:05Z running_subrepo_tests tools
  +41.6s (now)

Build log:
linux-386 at 0e015e20cfe7265635af605d274ff8dc2de5b3a2 building tools at d876d77976bd0ae3fa7013f4d86ec4080237cc8c

testing in module mode; GOMOD=/workdir/gopath/src/golang.org/x/tools/go.mod
:: Running /workdir/go/bin/go with args ["/workdir/go/bin/go" "test" "-short" "golang.org/x/tools/..."] and env ["PATH=/workdir/go/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin" "HOSTNAME=buildlet-linux-jessie-rn6b1b79e" "DEBIAN_FRONTEND=noninteractive" "HOME=/root" "USER=root" "GO_STAGE0_NET_DELAY=6s" "GO_STAGE0_DL_DELAY=0s" "WORKDIR=/workdir" "GOROOT_BOOTSTRAP=/workdir/go1.4" "GO_BUILDER_NAME=linux-386" "GOROOT_BOOTSTRAP=/go1.4" "GOARCH=386" "GOHOSTARCH=386" "GO_DISABLE_OUTBOUND_NETWORK=1" "GOROOT=/workdir/go" "GOPATH=/workdir/gopath" "GOPROXY=http://10.240.0.72:30157" "TMPDIR=/workdir/tmp" "GOCACHE=/workdir/gocache"] in dir /workdir/gopath/src/golang.org/x/tools

go: downloading golang.org/x/xerrors v0.0.0-20190717185122-a985d3407aa7
go: downloading golang.org/x/net v0.0.0-20190620200207-3b0461eec859
go: extracting golang.org/x/xerrors v0.0.0-20190717185122-a985d3407aa7
go: downloading golang.org/x/sync v0.0.0-20190423024810-112230192c58
go: extracting golang.org/x/sync v0.0.0-20190423024810-112230192c58
go: extracting golang.org/x/net v0.0.0-20190620200207-3b0461eec859
go: finding golang.org/x/net v0.0.0-20190620200207-3b0461eec859
go: finding golang.org/x/sync v0.0.0-20190423024810-112230192c58
go: finding golang.org/x/xerrors v0.0.0-20190717185122-a985d3407aa7
ok  	golang.org/x/tools/benchmark/parse	0.007s
ok  	golang.org/x/tools/blog	0.039s
?   	golang.org/x/tools/blog/atom	[no test files]
?   	golang.org/x/tools/cmd/auth/authtest	[no test files]
?   	golang.org/x/tools/cmd/auth/cookieauth	[no test files]
?   	golang.org/x/tools/cmd/auth/gitauth	[no test files]
?   	golang.org/x/tools/cmd/auth/netrcauth	[no test files]
ok  	golang.org/x/tools/cmd/benchcmp	0.014s
ok  	golang.org/x/tools/cmd/bundle	0.016s
ok  	golang.org/x/tools/cmd/callgraph	7.264s
?   	golang.org/x/tools/cmd/compilebench	[no test files]
ok  	golang.org/x/tools/cmd/cover	2.258s
ok  	golang.org/x/tools/cmd/digraph	0.013s
?   	golang.org/x/tools/cmd/eg	[no test files]
ok  	golang.org/x/tools/cmd/fiximports	10.307s
ok  	golang.org/x/tools/cmd/getgo	0.044s
?   	golang.org/x/tools/cmd/getgo/server	[no test files]
ok  	golang.org/x/tools/cmd/go-contrib-init	0.006s
?   	golang.org/x/tools/cmd/godex	[no test files]
ok  	golang.org/x/tools/cmd/godoc	13.742s
?   	golang.org/x/tools/cmd/goimports	[no test files]
?   	golang.org/x/tools/cmd/gomvpkg	[no test files]
?   	golang.org/x/tools/cmd/gopls	[no test files]
ok  	golang.org/x/tools/cmd/gorename	8.869s
?   	golang.org/x/tools/cmd/gotype	[no test files]
?   	golang.org/x/tools/cmd/goyacc	[no test files]
ok  	golang.org/x/tools/cmd/guru	0.020s
?   	golang.org/x/tools/cmd/guru/serial	[no test files]
?   	golang.org/x/tools/cmd/html2article	[no test files]
?   	golang.org/x/tools/cmd/present	[no test files]
?   	golang.org/x/tools/cmd/splitdwarf	[no test files]
ok  	golang.org/x/tools/cmd/splitdwarf/internal/macho	0.044s
?   	golang.org/x/tools/cmd/ssadump	[no test files]
?   	golang.org/x/tools/cmd/stress	[no test files]
ok  	golang.org/x/tools/cmd/stringer	31.813s
?   	golang.org/x/tools/cmd/toolstash	[no test files]
ok  	golang.org/x/tools/container/intsets	0.920s
?   	golang.org/x/tools/cover	[no test files]
?   	golang.org/x/tools/go/analysis	[no test files]
ok  	golang.org/x/tools/go/analysis/analysistest	0.218s
ok  	golang.org/x/tools/go/analysis/internal/analysisflags	0.116s
ok  	golang.org/x/tools/go/analysis/internal/checker	0.092s
ok  	golang.org/x/tools/go/analysis/internal/facts	0.217s
ok  	golang.org/x/tools/go/analysis/multichecker	16.719s
ok  	golang.org/x/tools/go/analysis/passes/asmdecl	0.572s
ok  	golang.org/x/tools/go/analysis/passes/assign	1.324s
ok  	golang.org/x/tools/go/analysis/passes/atomic	0.094s
ok  	golang.org/x/tools/go/analysis/passes/atomicalign	1.655s
ok  	golang.org/x/tools/go/analysis/passes/bools	1.249s
ok  	golang.org/x/tools/go/analysis/passes/buildssa	0.069s
ok  	golang.org/x/tools/go/analysis/passes/buildtag	0.027s
ok  	golang.org/x/tools/go/analysis/passes/cgocall	2.245s
ok  	golang.org/x/tools/go/analysis/passes/composite	1.894s
ok  	golang.org/x/tools/go/analysis/passes/copylock	1.576s
ok  	golang.org/x/tools/go/analysis/passes/ctrlflow	1.814s
ok  	golang.org/x/tools/go/analysis/passes/deepequalerrors	1.637s
ok  	golang.org/x/tools/go/analysis/passes/errorsas	1.120s
ok  	golang.org/x/tools/go/analysis/passes/findcall	0.366s
?   	golang.org/x/tools/go/analysis/passes/findcall/cmd/findcall	[no test files]
ok  	golang.org/x/tools/go/analysis/passes/httpresponse	2.915s
?   	golang.org/x/tools/go/analysis/passes/inspect	[no test files]
?   	golang.org/x/tools/go/analysis/passes/internal/analysisutil	[no test files]
ok  	golang.org/x/tools/go/analysis/passes/loopclosure	0.107s
ok  	golang.org/x/tools/go/analysis/passes/lostcancel	2.561s
?   	golang.org/x/tools/go/analysis/passes/lostcancel/cmd/lostcancel	[no test files]
ok  	golang.org/x/tools/go/analysis/passes/nilfunc	0.054s
ok  	golang.org/x/tools/go/analysis/passes/nilness	0.087s
?   	golang.org/x/tools/go/analysis/passes/nilness/cmd/nilness	[no test files]
ok  	golang.org/x/tools/go/analysis/passes/pkgfact	0.039s
ok  	golang.org/x/tools/go/analysis/passes/printf	2.302s
ok  	golang.org/x/tools/go/analysis/passes/shadow	1.854s
?   	golang.org/x/tools/go/analysis/passes/shadow/cmd/shadow	[no test files]
ok  	golang.org/x/tools/go/analysis/passes/shift	0.075s
ok  	golang.org/x/tools/go/analysis/passes/stdmethods	4.351s
ok  	golang.org/x/tools/go/analysis/passes/structtag	2.300s
ok  	golang.org/x/tools/go/analysis/passes/tests	2.117s
ok  	golang.org/x/tools/go/analysis/passes/unmarshal	1.951s
?   	golang.org/x/tools/go/analysis/passes/unmarshal/cmd/unmarshal	[no test files]
ok  	golang.org/x/tools/go/analysis/passes/unreachable	0.073s
ok  	golang.org/x/tools/go/analysis/passes/unsafeptr	1.707s
ok  	golang.org/x/tools/go/analysis/passes/unusedresult	1.759s
?   	golang.org/x/tools/go/analysis/singlechecker	[no test files]
ok  	golang.org/x/tools/go/analysis/unitchecker	2.980s
ok  	golang.org/x/tools/go/ast/astutil	0.045s
ok  	golang.org/x/tools/go/ast/inspector	0.083s
ok  	golang.org/x/tools/go/buildutil	0.043s
?   	golang.org/x/tools/go/callgraph	[no test files]
ok  	golang.org/x/tools/go/callgraph/cha	0.041s
ok  	golang.org/x/tools/go/callgraph/rta	0.027s
ok  	golang.org/x/tools/go/callgraph/static	0.033s
ok  	golang.org/x/tools/go/cfg	0.023s
ok  	golang.org/x/tools/go/expect	0.008s
ok  	golang.org/x/tools/go/gccgoexportdata	0.004s
ok  	golang.org/x/tools/go/gcexportdata	0.026s
?   	golang.org/x/tools/go/internal/cgo	[no test files]
ok  	golang.org/x/tools/go/internal/gccgoimporter	0.014s
ok  	golang.org/x/tools/go/internal/gcimporter	33.126s
?   	golang.org/x/tools/go/internal/packagesdriver	[no test files]
ok  	golang.org/x/tools/go/loader	10.564s
ok  	golang.org/x/tools/go/packages	36.886s
?   	golang.org/x/tools/go/packages/gopackages	[no test files]
ok  	golang.org/x/tools/go/packages/packagestest	0.062s
ok  	golang.org/x/tools/go/pointer	5.217s
ok  	golang.org/x/tools/go/ssa	9.830s
ok  	golang.org/x/tools/go/ssa/interp	0.375s
ok  	golang.org/x/tools/go/ssa/ssautil	3.527s
ok  	golang.org/x/tools/go/types/objectpath	0.046s
ok  	golang.org/x/tools/go/types/typeutil	1.111s
ok  	golang.org/x/tools/go/vcs	0.031s
ok  	golang.org/x/tools/godoc	0.895s
?   	golang.org/x/tools/godoc/analysis	[no test files]
?   	golang.org/x/tools/godoc/golangorgenv	[no test files]
ok  	golang.org/x/tools/godoc/redirect	5.182s
ok  	golang.org/x/tools/godoc/static	2.057s
?   	golang.org/x/tools/godoc/util	[no test files]
ok  	golang.org/x/tools/godoc/vfs	0.007s
ok  	golang.org/x/tools/godoc/vfs/gatefs	0.021s
?   	golang.org/x/tools/godoc/vfs/httpfs	[no test files]
ok  	golang.org/x/tools/godoc/vfs/mapfs	0.034s
ok  	golang.org/x/tools/godoc/vfs/zipfs	0.026s
?   	golang.org/x/tools/imports	[no test files]
ok  	golang.org/x/tools/internal/apidiff	0.506s
ok  	golang.org/x/tools/internal/fastwalk	0.035s
ok  	golang.org/x/tools/internal/gopathwalk	0.007s
ok  	golang.org/x/tools/internal/imports	17.446s
ok  	golang.org/x/tools/internal/jsonrpc2	0.014s
ok  	golang.org/x/tools/internal/lsp	14.759s
?   	golang.org/x/tools/internal/lsp/browser	[no test files]
?   	golang.org/x/tools/internal/lsp/cache	[no test files]
ok  	golang.org/x/tools/internal/lsp/cmd	5.156s
?   	golang.org/x/tools/internal/lsp/debug	[no test files]
ok  	golang.org/x/tools/internal/lsp/diff	0.008s
?   	golang.org/x/tools/internal/lsp/diff/difftest	[no test files]
ok  	golang.org/x/tools/internal/lsp/diff/myers	0.037s
ok  	golang.org/x/tools/internal/lsp/fuzzy	0.020s
?   	golang.org/x/tools/internal/lsp/protocol	[no test files]
ok  	golang.org/x/tools/internal/lsp/snippet	0.023s
ok  	golang.org/x/tools/internal/lsp/source	10.388s
?   	golang.org/x/tools/internal/lsp/telemetry	[no test files]
?   	golang.org/x/tools/internal/lsp/tests	[no test files]
ok  	golang.org/x/tools/internal/memoize	0.009s
ok  	golang.org/x/tools/internal/module	0.009s
ok  	golang.org/x/tools/internal/semver	0.014s
ok  	golang.org/x/tools/internal/span	0.011s
?   	golang.org/x/tools/internal/telemetry	[no test files]
?   	golang.org/x/tools/internal/telemetry/export	[no test files]
ok  	golang.org/x/tools/internal/telemetry/export/ocagent	0.017s
?   	golang.org/x/tools/internal/telemetry/export/ocagent/wire	[no test files]
?   	golang.org/x/tools/internal/telemetry/export/prometheus	[no test files]
?   	golang.org/x/tools/internal/telemetry/log	[no test files]
?   	golang.org/x/tools/internal/telemetry/metric	[no test files]
?   	golang.org/x/tools/internal/telemetry/stats	[no test files]
?   	golang.org/x/tools/internal/telemetry/tag	[no test files]
?   	golang.org/x/tools/internal/telemetry/trace	[no test files]
?   	golang.org/x/tools/internal/telemetry/unit	[no test files]
?   	golang.org/x/tools/internal/testenv	[no test files]
?   	golang.org/x/tools/internal/tool	[no test files]
ok  	golang.org/x/tools/internal/txtar	0.013s
?   	golang.org/x/tools/internal/xcontext	[no test files]
?   	golang.org/x/tools/playground	[no test files]
ok  	golang.org/x/tools/playground/socket	0.014s
ok  	golang.org/x/tools/present	0.021s
ok  	golang.org/x/tools/refactor/eg	3.263s
ok  	golang.org/x/tools/refactor/importgraph	0.588s
ok  	golang.org/x/tools/refactor/rename	0.089s
?   	golang.org/x/tools/refactor/satisfy	[no test files]
linux-amd64 (Go 1.13.x) - tests ran in module mode
  builder: linux-amd64
      rev: 052d7c80748ada786d12b27e58a4f63f118c1aef
 buildlet: http://10.240.0.219 GCE VM: buildlet-linux-stretch-rnc83e15a
  started: 2019-09-11 13:46:08.196560906 +0000 UTC m=+282.899198752
   status: still running

Events:
  2019-09-11T13:46:08Z checking_for_snapshot 
  2019-09-11T13:46:08Z finish_checking_for_snapshot after 12.6ms
  2019-09-11T13:46:08Z get_buildlet 
  2019-09-11T13:46:08Z awaiting_gce_quota 
  2019-09-11T13:46:08Z finish_awaiting_gce_quota after 0s
  2019-09-11T13:46:08Z create_gce_buildlet buildlet-linux-stretch-rnc83e15a
  2019-09-11T13:46:08Z create_gce_instance buildlet-linux-stretch-rnc83e15a
  2019-09-11T13:46:18Z finish_create_gce_instance after 9.79s; buildlet-linux-stretch-rnc83e15a
  2019-09-11T13:46:18Z wait_buildlet_start buildlet-linux-stretch-rnc83e15a
  2019-09-11T13:46:19Z got_instance_info waiting_for_buildlet...
  2019-09-11T13:46:59Z finish_wait_buildlet_start after 41.3s; buildlet-linux-stretch-rnc83e15a
  2019-09-11T13:46:59Z finish_create_gce_buildlet after 51.2s; buildlet-linux-stretch-rnc83e15a
  2019-09-11T13:46:59Z finish_get_buildlet after 51.3s
  2019-09-11T13:46:59Z using_buildlet 10.240.0.219:80
  2019-09-11T13:46:59Z write_snapshot_tar 
  2019-09-11T13:47:03Z finish_write_snapshot_tar after 3.93s
  2019-09-11T13:47:03Z make_and_test 
  2019-09-11T13:47:03Z fetching_subrepo tools
  2019-09-11T13:47:03Z get_source 
  2019-09-11T13:47:03Z finish_get_source after 0s
  2019-09-11T13:47:04Z running_subrepo_tests tools
   +8.0s (now)

Build log:
linux-amd64 at 052d7c80748ada786d12b27e58a4f63f118c1aef building tools at d876d77976bd0ae3fa7013f4d86ec4080237cc8c

testing in module mode; GOMOD=/workdir/gopath/src/golang.org/x/tools/go.mod
:: Running /workdir/go/bin/go with args ["/workdir/go/bin/go" "test" "-short" "golang.org/x/tools/..."] and env ["PATH=/workdir/go/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin" "HOSTNAME=buildlet-linux-stretch-rnc83e15a" "DEBIAN_FRONTEND=noninteractive" "HOME=/root" "USER=root" "GO_STAGE0_NET_DELAY=4.1s" "GO_STAGE0_DL_DELAY=0s" "WORKDIR=/workdir" "GOROOT_BOOTSTRAP=/workdir/go1.4" "GO_BUILDER_NAME=linux-amd64" "GOROOT_BOOTSTRAP=/go1.4" "GO_DISABLE_OUTBOUND_NETWORK=1" "GOROOT=/workdir/go" "GOPATH=/workdir/gopath" "GOPROXY=http://10.240.0.72:30157" "TMPDIR=/workdir/tmp" "GOCACHE=/workdir/gocache"] in dir /workdir/gopath/src/golang.org/x/tools

go: downloading golang.org/x/sync v0.0.0-20190423024810-112230192c58
go: downloading golang.org/x/net v0.0.0-20190620200207-3b0461eec859
go: extracting golang.org/x/sync v0.0.0-20190423024810-112230192c58
go: downloading golang.org/x/xerrors v0.0.0-20190717185122-a985d3407aa7
go: extracting golang.org/x/xerrors v0.0.0-20190717185122-a985d3407aa7
go: extracting golang.org/x/net v0.0.0-20190620200207-3b0461eec859
go: finding golang.org/x/net v0.0.0-20190620200207-3b0461eec859
go: finding golang.org/x/xerrors v0.0.0-20190717185122-a985d3407aa7
go: finding golang.org/x/sync v0.0.0-20190423024810-112230192c58
ok  	golang.org/x/tools/benchmark/parse	0.005s
ok  	golang.org/x/tools/blog	0.021s
?   	golang.org/x/tools/blog/atom	[no test files]
?   	golang.org/x/tools/cmd/auth/authtest	[no test files]
?   	golang.org/x/tools/cmd/auth/cookieauth	[no test files]
?   	golang.org/x/tools/cmd/auth/gitauth	[no test files]
?   	golang.org/x/tools/cmd/auth/netrcauth	[no test files]
ok  	golang.org/x/tools/cmd/benchcmp	0.014s
ok  	golang.org/x/tools/cmd/bundle	0.027s
ok  	golang.org/x/tools/cmd/callgraph	7.030s
?   	golang.org/x/tools/cmd/compilebench	[no test files]
ok  	golang.org/x/tools/cmd/cover	1.808s
ok  	golang.org/x/tools/cmd/digraph	0.024s
?   	golang.org/x/tools/cmd/eg	[no test files]
ok  	golang.org/x/tools/cmd/fiximports	8.337s
ok  	golang.org/x/tools/cmd/getgo	0.037s
?   	golang.org/x/tools/cmd/getgo/server	[no test files]
ok  	golang.org/x/tools/cmd/go-contrib-init	0.011s
?   	golang.org/x/tools/cmd/godex	[no test files]
ok  	golang.org/x/tools/cmd/godoc	11.602s
?   	golang.org/x/tools/cmd/goimports	[no test files]
?   	golang.org/x/tools/cmd/gomvpkg	[no test files]
?   	golang.org/x/tools/cmd/gopls	[no test files]
ok  	golang.org/x/tools/cmd/gorename	8.718s
?   	golang.org/x/tools/cmd/gotype	[no test files]
?   	golang.org/x/tools/cmd/goyacc	[no test files]
ok  	golang.org/x/tools/cmd/guru	0.020s
?   	golang.org/x/tools/cmd/guru/serial	[no test files]
?   	golang.org/x/tools/cmd/html2article	[no test files]
?   	golang.org/x/tools/cmd/present	[no test files]
?   	golang.org/x/tools/cmd/splitdwarf	[no test files]
ok  	golang.org/x/tools/cmd/splitdwarf/internal/macho	0.019s
?   	golang.org/x/tools/cmd/ssadump	[no test files]
?   	golang.org/x/tools/cmd/stress	[no test files]
ok  	golang.org/x/tools/cmd/stringer	35.167s
?   	golang.org/x/tools/cmd/toolstash	[no test files]
ok  	golang.org/x/tools/container/intsets	0.812s
?   	golang.org/x/tools/cover	[no test files]
?   	golang.org/x/tools/go/analysis	[no test files]
ok  	golang.org/x/tools/go/analysis/analysistest	0.213s
ok  	golang.org/x/tools/go/analysis/internal/analysisflags	0.134s
ok  	golang.org/x/tools/go/analysis/internal/checker	0.151s
ok  	golang.org/x/tools/go/analysis/internal/facts	0.193s
ok  	golang.org/x/tools/go/analysis/multichecker	19.131s
ok  	golang.org/x/tools/go/analysis/passes/asmdecl	0.537s
ok  	golang.org/x/tools/go/analysis/passes/assign	1.258s
ok  	golang.org/x/tools/go/analysis/passes/atomic	0.051s
ok  	golang.org/x/tools/go/analysis/passes/atomicalign	0.104s
ok  	golang.org/x/tools/go/analysis/passes/bools	1.844s
ok  	golang.org/x/tools/go/analysis/passes/buildssa	0.062s
ok  	golang.org/x/tools/go/analysis/passes/buildtag	0.044s
ok  	golang.org/x/tools/go/analysis/passes/cgocall	4.629s
ok  	golang.org/x/tools/go/analysis/passes/composite	2.251s
ok  	golang.org/x/tools/go/analysis/passes/copylock	2.189s
ok  	golang.org/x/tools/go/analysis/passes/ctrlflow	2.630s
ok  	golang.org/x/tools/go/analysis/passes/deepequalerrors	2.341s
ok  	golang.org/x/tools/go/analysis/passes/errorsas	1.636s
ok  	golang.org/x/tools/go/analysis/passes/findcall	0.199s
?   	golang.org/x/tools/go/analysis/passes/findcall/cmd/findcall	[no test files]
ok  	golang.org/x/tools/go/analysis/passes/httpresponse	4.198s
?   	golang.org/x/tools/go/analysis/passes/inspect	[no test files]
?   	golang.org/x/tools/go/analysis/passes/internal/analysisutil	[no test files]
ok  	golang.org/x/tools/go/analysis/passes/loopclosure	0.047s
ok  	golang.org/x/tools/go/analysis/passes/lostcancel	2.865s
?   	golang.org/x/tools/go/analysis/passes/lostcancel/cmd/lostcancel	[no test files]
ok  	golang.org/x/tools/go/analysis/passes/nilfunc	0.070s
ok  	golang.org/x/tools/go/analysis/passes/nilness	0.038s
?   	golang.org/x/tools/go/analysis/passes/nilness/cmd/nilness	[no test files]
ok  	golang.org/x/tools/go/analysis/passes/pkgfact	0.044s
ok  	golang.org/x/tools/go/analysis/passes/printf	2.379s
ok  	golang.org/x/tools/go/analysis/passes/shadow	2.105s
?   	golang.org/x/tools/go/analysis/passes/shadow/cmd/shadow	[no test files]
ok  	golang.org/x/tools/go/analysis/passes/shift	0.025s
ok  	golang.org/x/tools/go/analysis/passes/stdmethods	4.915s
ok  	golang.org/x/tools/go/analysis/passes/structtag	2.727s
ok  	golang.org/x/tools/go/analysis/passes/tests	2.092s
ok  	golang.org/x/tools/go/analysis/passes/unmarshal	2.273s
?   	golang.org/x/tools/go/analysis/passes/unmarshal/cmd/unmarshal	[no test files]
ok  	golang.org/x/tools/go/analysis/passes/unreachable	0.105s
ok  	golang.org/x/tools/go/analysis/passes/unsafeptr	1.577s
ok  	golang.org/x/tools/go/analysis/passes/unusedresult	3.066s
?   	golang.org/x/tools/go/analysis/singlechecker	[no test files]
ok  	golang.org/x/tools/go/analysis/unitchecker	2.981s
ok  	golang.org/x/tools/go/ast/astutil	0.034s
ok  	golang.org/x/tools/go/ast/inspector	0.103s
ok  	golang.org/x/tools/go/buildutil	0.043s
?   	golang.org/x/tools/go/callgraph	[no test files]
ok  	golang.org/x/tools/go/callgraph/cha	0.023s
ok  	golang.org/x/tools/go/callgraph/rta	0.006s
ok  	golang.org/x/tools/go/callgraph/static	0.014s
ok  	golang.org/x/tools/go/cfg	0.011s
ok  	golang.org/x/tools/go/expect	0.006s
ok  	golang.org/x/tools/go/gccgoexportdata	0.018s
ok  	golang.org/x/tools/go/gcexportdata	0.068s
?   	golang.org/x/tools/go/internal/cgo	[no test files]
ok  	golang.org/x/tools/go/internal/gccgoimporter	0.024s
ok  	golang.org/x/tools/go/internal/gcimporter	37.651s
?   	golang.org/x/tools/go/internal/packagesdriver	[no test files]
ok  	golang.org/x/tools/go/loader	10.067s
ok  	golang.org/x/tools/go/packages	39.020s
?   	golang.org/x/tools/go/packages/gopackages	[no test files]
ok  	golang.org/x/tools/go/packages/packagestest	0.062s
ok  	golang.org/x/tools/go/pointer	6.409s
ok  	golang.org/x/tools/go/ssa	7.994s
ok  	golang.org/x/tools/go/ssa/interp	0.484s
ok  	golang.org/x/tools/go/ssa/ssautil	2.609s
ok  	golang.org/x/tools/go/types/objectpath	0.035s
ok  	golang.org/x/tools/go/types/typeutil	1.058s
ok  	golang.org/x/tools/go/vcs	0.061s
ok  	golang.org/x/tools/godoc	0.668s
?   	golang.org/x/tools/godoc/analysis	[no test files]
?   	golang.org/x/tools/godoc/golangorgenv	[no test files]
ok  	golang.org/x/tools/godoc/redirect	5.151s
ok  	golang.org/x/tools/godoc/static	2.166s
?   	golang.org/x/tools/godoc/util	[no test files]
ok  	golang.org/x/tools/godoc/vfs	0.019s
ok  	golang.org/x/tools/godoc/vfs/gatefs	0.012s
?   	golang.org/x/tools/godoc/vfs/httpfs	[no test files]
ok  	golang.org/x/tools/godoc/vfs/mapfs	0.013s
ok  	golang.org/x/tools/godoc/vfs/zipfs	0.016s
?   	golang.org/x/tools/imports	[no test files]
ok  	golang.org/x/tools/internal/apidiff	0.657s
ok  	golang.org/x/tools/internal/fastwalk	0.009s
ok  	golang.org/x/tools/internal/gopathwalk	0.014s
ok  	golang.org/x/tools/internal/imports	17.298s
ok  	golang.org/x/tools/internal/jsonrpc2	0.036s
ok  	golang.org/x/tools/internal/lsp	15.395s
?   	golang.org/x/tools/internal/lsp/browser	[no test files]
?   	golang.org/x/tools/internal/lsp/cache	[no test files]
ok  	golang.org/x/tools/internal/lsp/cmd	5.355s
?   	golang.org/x/tools/internal/lsp/debug	[no test files]
ok  	golang.org/x/tools/internal/lsp/diff	0.011s
?   	golang.org/x/tools/internal/lsp/diff/difftest	[no test files]
ok  	golang.org/x/tools/internal/lsp/diff/myers	0.009s
ok  	golang.org/x/tools/internal/lsp/fuzzy	0.008s
?   	golang.org/x/tools/internal/lsp/protocol	[no test files]
ok  	golang.org/x/tools/internal/lsp/snippet	0.038s
ok  	golang.org/x/tools/internal/lsp/source	9.026s
?   	golang.org/x/tools/internal/lsp/telemetry	[no test files]
?   	golang.org/x/tools/internal/lsp/tests	[no test files]
ok  	golang.org/x/tools/internal/memoize	0.020s
ok  	golang.org/x/tools/internal/module	0.009s
ok  	golang.org/x/tools/internal/semver	0.007s
ok  	golang.org/x/tools/internal/span	0.014s
?   	golang.org/x/tools/internal/telemetry	[no test files]
?   	golang.org/x/tools/internal/telemetry/export	[no test files]
ok  	golang.org/x/tools/internal/telemetry/export/ocagent	0.006s
?   	golang.org/x/tools/internal/telemetry/export/ocagent/wire	[no test files]
?   	golang.org/x/tools/internal/telemetry/export/prometheus	[no test files]
?   	golang.org/x/tools/internal/telemetry/log	[no test files]
?   	golang.org/x/tools/internal/telemetry/metric	[no test files]
?   	golang.org/x/tools/internal/telemetry/stats	[no test files]
?   	golang.org/x/tools/internal/telemetry/tag	[no test files]
?   	golang.org/x/tools/internal/telemetry/trace	[no test files]
?   	golang.org/x/tools/internal/telemetry/unit	[no test files]
?   	golang.org/x/tools/internal/testenv	[no test files]
?   	golang.org/x/tools/internal/tool	[no test files]
ok  	golang.org/x/tools/internal/txtar	0.013s
?   	golang.org/x/tools/internal/xcontext	[no test files]
?   	golang.org/x/tools/playground	[no test files]
ok  	golang.org/x/tools/playground/socket	0.005s
ok  	golang.org/x/tools/present	0.023s
ok  	golang.org/x/tools/refactor/eg	3.367s
ok  	golang.org/x/tools/refactor/importgraph	0.896s
ok  	golang.org/x/tools/refactor/rename	0.087s
?   	golang.org/x/tools/refactor/satisfy	[no test files]
linux-amd64 (Go 1.12.x) - tests ran in GOPATH mode with x/tools/gopls directory skipped
  builder: linux-amd64
      rev: cf06b9aa81004a017e5c98422fce2fafd1f24921
 buildlet: http://10.240.0.225 GCE VM: buildlet-linux-stretch-rn7ff7fd9
  started: 2019-09-11 13:46:08.1965733 +0000 UTC m=+282.899211131
   status: still running

Events:
  2019-09-11T13:46:08Z checking_for_snapshot 
  2019-09-11T13:46:08Z finish_checking_for_snapshot after 16.5ms
  2019-09-11T13:46:08Z get_buildlet 
  2019-09-11T13:46:08Z awaiting_gce_quota 
  2019-09-11T13:46:08Z finish_awaiting_gce_quota after 0s
  2019-09-11T13:46:08Z create_gce_buildlet buildlet-linux-stretch-rn7ff7fd9
  2019-09-11T13:46:08Z create_gce_instance buildlet-linux-stretch-rn7ff7fd9
  2019-09-11T13:46:18Z finish_create_gce_instance after 10.4s; buildlet-linux-stretch-rn7ff7fd9
  2019-09-11T13:46:18Z wait_buildlet_start buildlet-linux-stretch-rn7ff7fd9
  2019-09-11T13:46:20Z got_instance_info waiting_for_buildlet...
  2019-09-11T13:47:00Z finish_wait_buildlet_start after 41.1s; buildlet-linux-stretch-rn7ff7fd9
  2019-09-11T13:47:00Z finish_create_gce_buildlet after 51.7s; buildlet-linux-stretch-rn7ff7fd9
  2019-09-11T13:47:00Z finish_get_buildlet after 51.8s
  2019-09-11T13:47:00Z using_buildlet 10.240.0.225:80
  2019-09-11T13:47:00Z write_snapshot_tar 
  2019-09-11T13:47:05Z finish_write_snapshot_tar after 5.41s
  2019-09-11T13:47:05Z make_and_test 
  2019-09-11T13:47:05Z fetching_subrepo tools
  2019-09-11T13:47:05Z get_source 
  2019-09-11T13:47:05Z finish_get_source after 0s
  2019-09-11T13:47:06Z get_source 
  2019-09-11T13:47:06Z finish_get_source after 0s
  2019-09-11T13:47:06Z get_source 
  2019-09-11T13:47:06Z finish_get_source after 0s
  2019-09-11T13:47:06Z get_source 
  2019-09-11T13:47:06Z finish_get_source after 0s
  2019-09-11T13:47:06Z get_source 
  2019-09-11T13:47:06Z finish_get_source after 0s
  2019-09-11T13:47:07Z get_source 
  2019-09-11T13:47:07Z finish_get_source after 0s
  2019-09-11T13:47:07Z get_source 
  2019-09-11T13:47:07Z finish_get_source after 0s
  2019-09-11T13:47:07Z listing_subrepo_packages tools
  2019-09-11T13:47:08Z finish_listing_subrepo_packages after 229.8ms; tools
  2019-09-11T13:47:08Z running_subrepo_tests tools
   +4.9s (now)

Build log:
linux-amd64 at cf06b9aa81004a017e5c98422fce2fafd1f24921 building tools at d876d77976bd0ae3fa7013f4d86ec4080237cc8c

testing in GOPATH mode
:: Running /workdir/go/bin/go with args ["/workdir/go/bin/go" "test" "-short" "golang.org/x/tools/benchmark/parse" "golang.org/x/tools/blog" "golang.org/x/tools/blog/atom" "golang.org/x/tools/cmd/auth/authtest" "golang.org/x/tools/cmd/auth/cookieauth" "golang.org/x/tools/cmd/auth/gitauth" "golang.org/x/tools/cmd/auth/netrcauth" "golang.org/x/tools/cmd/benchcmp" "golang.org/x/tools/cmd/bundle" "golang.org/x/tools/cmd/callgraph" "golang.org/x/tools/cmd/compilebench" "golang.org/x/tools/cmd/cover" "golang.org/x/tools/cmd/digraph" "golang.org/x/tools/cmd/eg" "golang.org/x/tools/cmd/fiximports" "golang.org/x/tools/cmd/getgo" "golang.org/x/tools/cmd/getgo/server" "golang.org/x/tools/cmd/go-contrib-init" "golang.org/x/tools/cmd/godex" "golang.org/x/tools/cmd/godoc" "golang.org/x/tools/cmd/goimports" "golang.org/x/tools/cmd/gomvpkg" "golang.org/x/tools/cmd/gopls" "golang.org/x/tools/cmd/gorename" "golang.org/x/tools/cmd/gotype" "golang.org/x/tools/cmd/goyacc" "golang.org/x/tools/cmd/guru" "golang.org/x/tools/cmd/guru/serial" "golang.org/x/tools/cmd/html2article" "golang.org/x/tools/cmd/present" "golang.org/x/tools/cmd/splitdwarf" "golang.org/x/tools/cmd/splitdwarf/internal/macho" "golang.org/x/tools/cmd/ssadump" "golang.org/x/tools/cmd/stress" "golang.org/x/tools/cmd/stringer" "golang.org/x/tools/cmd/toolstash" "golang.org/x/tools/container/intsets" "golang.org/x/tools/cover" "golang.org/x/tools/go/analysis" "golang.org/x/tools/go/analysis/analysistest" "golang.org/x/tools/go/analysis/internal/analysisflags" "golang.org/x/tools/go/analysis/internal/checker" "golang.org/x/tools/go/analysis/internal/facts" "golang.org/x/tools/go/analysis/multichecker" "golang.org/x/tools/go/analysis/passes/asmdecl" "golang.org/x/tools/go/analysis/passes/assign" "golang.org/x/tools/go/analysis/passes/atomic" "golang.org/x/tools/go/analysis/passes/atomicalign" "golang.org/x/tools/go/analysis/passes/bools" "golang.org/x/tools/go/analysis/passes/buildssa" "golang.org/x/tools/go/analysis/passes/buildtag" "golang.org/x/tools/go/analysis/passes/cgocall" "golang.org/x/tools/go/analysis/passes/composite" "golang.org/x/tools/go/analysis/passes/copylock" "golang.org/x/tools/go/analysis/passes/ctrlflow" "golang.org/x/tools/go/analysis/passes/deepequalerrors" "golang.org/x/tools/go/analysis/passes/errorsas" "golang.org/x/tools/go/analysis/passes/findcall" "golang.org/x/tools/go/analysis/passes/findcall/cmd/findcall" "golang.org/x/tools/go/analysis/passes/httpresponse" "golang.org/x/tools/go/analysis/passes/inspect" "golang.org/x/tools/go/analysis/passes/internal/analysisutil" "golang.org/x/tools/go/analysis/passes/loopclosure" "golang.org/x/tools/go/analysis/passes/lostcancel" "golang.org/x/tools/go/analysis/passes/lostcancel/cmd/lostcancel" "golang.org/x/tools/go/analysis/passes/nilfunc" "golang.org/x/tools/go/analysis/passes/nilness" "golang.org/x/tools/go/analysis/passes/nilness/cmd/nilness" "golang.org/x/tools/go/analysis/passes/pkgfact" "golang.org/x/tools/go/analysis/passes/printf" "golang.org/x/tools/go/analysis/passes/shadow" "golang.org/x/tools/go/analysis/passes/shadow/cmd/shadow" "golang.org/x/tools/go/analysis/passes/shift" "golang.org/x/tools/go/analysis/passes/stdmethods" "golang.org/x/tools/go/analysis/passes/structtag" "golang.org/x/tools/go/analysis/passes/tests" "golang.org/x/tools/go/analysis/passes/unmarshal" "golang.org/x/tools/go/analysis/passes/unmarshal/cmd/unmarshal" "golang.org/x/tools/go/analysis/passes/unreachable" "golang.org/x/tools/go/analysis/passes/unsafeptr" "golang.org/x/tools/go/analysis/passes/unusedresult" "golang.org/x/tools/go/analysis/singlechecker" "golang.org/x/tools/go/analysis/unitchecker" "golang.org/x/tools/go/ast/astutil" "golang.org/x/tools/go/ast/inspector" "golang.org/x/tools/go/buildutil" "golang.org/x/tools/go/callgraph" "golang.org/x/tools/go/callgraph/cha" "golang.org/x/tools/go/callgraph/rta" "golang.org/x/tools/go/callgraph/static" "golang.org/x/tools/go/cfg" "golang.org/x/tools/go/expect" "golang.org/x/tools/go/gccgoexportdata" "golang.org/x/tools/go/gcexportdata" "golang.org/x/tools/go/internal/cgo" "golang.org/x/tools/go/internal/gccgoimporter" "golang.org/x/tools/go/internal/gcimporter" "golang.org/x/tools/go/internal/packagesdriver" "golang.org/x/tools/go/loader" "golang.org/x/tools/go/packages" "golang.org/x/tools/go/packages/gopackages" "golang.org/x/tools/go/packages/packagestest" "golang.org/x/tools/go/pointer" "golang.org/x/tools/go/ssa" "golang.org/x/tools/go/ssa/interp" "golang.org/x/tools/go/ssa/ssautil" "golang.org/x/tools/go/types/objectpath" "golang.org/x/tools/go/types/typeutil" "golang.org/x/tools/go/vcs" "golang.org/x/tools/godoc" "golang.org/x/tools/godoc/analysis" "golang.org/x/tools/godoc/golangorgenv" "golang.org/x/tools/godoc/redirect" "golang.org/x/tools/godoc/static" "golang.org/x/tools/godoc/util" "golang.org/x/tools/godoc/vfs" "golang.org/x/tools/godoc/vfs/gatefs" "golang.org/x/tools/godoc/vfs/httpfs" "golang.org/x/tools/godoc/vfs/mapfs" "golang.org/x/tools/godoc/vfs/zipfs" "golang.org/x/tools/imports" "golang.org/x/tools/internal/apidiff" "golang.org/x/tools/internal/fastwalk" "golang.org/x/tools/internal/gopathwalk" "golang.org/x/tools/internal/imports" "golang.org/x/tools/internal/jsonrpc2" "golang.org/x/tools/internal/lsp" "golang.org/x/tools/internal/lsp/browser" "golang.org/x/tools/internal/lsp/cache" "golang.org/x/tools/internal/lsp/cmd" "golang.org/x/tools/internal/lsp/debug" "golang.org/x/tools/internal/lsp/diff" "golang.org/x/tools/internal/lsp/diff/difftest" "golang.org/x/tools/internal/lsp/diff/myers" "golang.org/x/tools/internal/lsp/fuzzy" "golang.org/x/tools/internal/lsp/protocol" "golang.org/x/tools/internal/lsp/snippet" "golang.org/x/tools/internal/lsp/source" "golang.org/x/tools/internal/lsp/telemetry" "golang.org/x/tools/internal/lsp/tests" "golang.org/x/tools/internal/memoize" "golang.org/x/tools/internal/module" "golang.org/x/tools/internal/semver" "golang.org/x/tools/internal/span" "golang.org/x/tools/internal/telemetry" "golang.org/x/tools/internal/telemetry/export" "golang.org/x/tools/internal/telemetry/export/ocagent" "golang.org/x/tools/internal/telemetry/export/ocagent/wire" "golang.org/x/tools/internal/telemetry/export/prometheus" "golang.org/x/tools/internal/telemetry/log" "golang.org/x/tools/internal/telemetry/metric" "golang.org/x/tools/internal/telemetry/stats" "golang.org/x/tools/internal/telemetry/tag" "golang.org/x/tools/internal/telemetry/trace" "golang.org/x/tools/internal/telemetry/unit" "golang.org/x/tools/internal/testenv" "golang.org/x/tools/internal/tool" "golang.org/x/tools/internal/txtar" "golang.org/x/tools/internal/xcontext" "golang.org/x/tools/playground" "golang.org/x/tools/playground/socket" "golang.org/x/tools/present" "golang.org/x/tools/refactor/eg" "golang.org/x/tools/refactor/importgraph" "golang.org/x/tools/refactor/rename" "golang.org/x/tools/refactor/satisfy"] and env ["PATH=/workdir/go/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin" "HOSTNAME=buildlet-linux-stretch-rn7ff7fd9" "DEBIAN_FRONTEND=noninteractive" "HOME=/root" "USER=root" "GO_STAGE0_NET_DELAY=3.1s" "GO_STAGE0_DL_DELAY=0s" "WORKDIR=/workdir" "GOROOT_BOOTSTRAP=/workdir/go1.4" "GO_BUILDER_NAME=linux-amd64" "GOROOT_BOOTSTRAP=/go1.4" "GO_DISABLE_OUTBOUND_NETWORK=1" "GOROOT=/workdir/go" "GOPATH=/workdir/gopath" "GOPROXY=http://10.240.0.72:30157" "TMPDIR=/workdir/tmp" "GOCACHE=/workdir/gocache"] in dir /workdir/gopath/src/golang.org/x/tools

ok  	golang.org/x/tools/benchmark/parse	0.024s
ok  	golang.org/x/tools/blog	0.005s
?   	golang.org/x/tools/blog/atom	[no test files]
?   	golang.org/x/tools/cmd/auth/authtest	[no test files]
?   	golang.org/x/tools/cmd/auth/cookieauth	[no test files]
?   	golang.org/x/tools/cmd/auth/gitauth	[no test files]
?   	golang.org/x/tools/cmd/auth/netrcauth	[no test files]
ok  	golang.org/x/tools/cmd/benchcmp	0.023s
ok  	golang.org/x/tools/cmd/bundle	0.019s
ok  	golang.org/x/tools/cmd/callgraph	7.806s
?   	golang.org/x/tools/cmd/compilebench	[no test files]
ok  	golang.org/x/tools/cmd/cover	1.887s
ok  	golang.org/x/tools/cmd/digraph	0.007s
?   	golang.org/x/tools/cmd/eg	[no test files]
ok  	golang.org/x/tools/cmd/fiximports	9.163s
ok  	golang.org/x/tools/cmd/getgo	0.011s
?   	golang.org/x/tools/cmd/getgo/server	[no test files]
ok  	golang.org/x/tools/cmd/go-contrib-init	0.025s
?   	golang.org/x/tools/cmd/godex	[no test files]
ok  	golang.org/x/tools/cmd/godoc	12.199s
?   	golang.org/x/tools/cmd/goimports	[no test files]
?   	golang.org/x/tools/cmd/gomvpkg	[no test files]
?   	golang.org/x/tools/cmd/gopls	[no test files]
ok  	golang.org/x/tools/cmd/gorename	9.500s
?   	golang.org/x/tools/cmd/gotype	[no test files]
?   	golang.org/x/tools/cmd/goyacc	[no test files]
ok  	golang.org/x/tools/cmd/guru	0.038s
?   	golang.org/x/tools/cmd/guru/serial	[no test files]
?   	golang.org/x/tools/cmd/html2article	[no test files]
?   	golang.org/x/tools/cmd/present	[no test files]
?   	golang.org/x/tools/cmd/splitdwarf	[no test files]
ok  	golang.org/x/tools/cmd/splitdwarf/internal/macho	0.005s
?   	golang.org/x/tools/cmd/ssadump	[no test files]
?   	golang.org/x/tools/cmd/stress	[no test files]
ok  	golang.org/x/tools/cmd/stringer	38.294s
?   	golang.org/x/tools/cmd/toolstash	[no test files]
ok  	golang.org/x/tools/container/intsets	0.833s
?   	golang.org/x/tools/cover	[no test files]
?   	golang.org/x/tools/go/analysis	[no test files]
ok  	golang.org/x/tools/go/analysis/analysistest	0.157s
ok  	golang.org/x/tools/go/analysis/internal/analysisflags	0.150s
ok  	golang.org/x/tools/go/analysis/internal/checker	0.186s
ok  	golang.org/x/tools/go/analysis/internal/facts	0.325s
ok  	golang.org/x/tools/go/analysis/multichecker	17.395s
ok  	golang.org/x/tools/go/analysis/passes/asmdecl	0.944s
ok  	golang.org/x/tools/go/analysis/passes/assign	1.754s
ok  	golang.org/x/tools/go/analysis/passes/atomic	0.108s
ok  	golang.org/x/tools/go/analysis/passes/atomicalign	0.120s
ok  	golang.org/x/tools/go/analysis/passes/bools	1.779s
ok  	golang.org/x/tools/go/analysis/passes/buildssa	0.065s
ok  	golang.org/x/tools/go/analysis/passes/buildtag	0.052s
ok  	golang.org/x/tools/go/analysis/passes/cgocall	3.895s
ok  	golang.org/x/tools/go/analysis/passes/composite	3.041s
ok  	golang.org/x/tools/go/analysis/passes/copylock	1.598s
ok  	golang.org/x/tools/go/analysis/passes/ctrlflow	3.080s
ok  	golang.org/x/tools/go/analysis/passes/deepequalerrors	2.243s
?   	golang.org/x/tools/go/analysis/passes/errorsas	[no test files]
ok  	golang.org/x/tools/go/analysis/passes/findcall	0.372s
?   	golang.org/x/tools/go/analysis/passes/findcall/cmd/findcall	[no test files]
ok  	golang.org/x/tools/go/analysis/passes/httpresponse	3.553s
?   	golang.org/x/tools/go/analysis/passes/inspect	[no test files]
?   	golang.org/x/tools/go/analysis/passes/internal/analysisutil	[no test files]
ok  	golang.org/x/tools/go/analysis/passes/loopclosure	0.099s
ok  	golang.org/x/tools/go/analysis/passes/lostcancel	2.579s
?   	golang.org/x/tools/go/analysis/passes/lostcancel/cmd/lostcancel	[no test files]
ok  	golang.org/x/tools/go/analysis/passes/nilfunc	0.059s
ok  	golang.org/x/tools/go/analysis/passes/nilness	0.085s
?   	golang.org/x/tools/go/analysis/passes/nilness/cmd/nilness	[no test files]
ok  	golang.org/x/tools/go/analysis/passes/pkgfact	0.063s
ok  	golang.org/x/tools/go/analysis/passes/printf	2.612s
ok  	golang.org/x/tools/go/analysis/passes/shadow	2.068s
?   	golang.org/x/tools/go/analysis/passes/shadow/cmd/shadow	[no test files]
ok  	golang.org/x/tools/go/analysis/passes/shift	0.115s
ok  	golang.org/x/tools/go/analysis/passes/stdmethods	4.052s
ok  	golang.org/x/tools/go/analysis/passes/structtag	2.097s
ok  	golang.org/x/tools/go/analysis/passes/tests	2.690s
ok  	golang.org/x/tools/go/analysis/passes/unmarshal	2.843s
?   	golang.org/x/tools/go/analysis/passes/unmarshal/cmd/unmarshal	[no test files]
ok  	golang.org/x/tools/go/analysis/passes/unreachable	0.089s
ok  	golang.org/x/tools/go/analysis/passes/unsafeptr	1.775s
ok  	golang.org/x/tools/go/analysis/passes/unusedresult	1.833s
?   	golang.org/x/tools/go/analysis/singlechecker	[no test files]
ok  	golang.org/x/tools/go/analysis/unitchecker	2.912s
ok  	golang.org/x/tools/go/ast/astutil	0.021s
ok  	golang.org/x/tools/go/ast/inspector	0.129s
ok  	golang.org/x/tools/go/buildutil	0.052s
?   	golang.org/x/tools/go/callgraph	[no test files]
ok  	golang.org/x/tools/go/callgraph/cha	0.053s
ok  	golang.org/x/tools/go/callgraph/rta	0.011s
ok  	golang.org/x/tools/go/callgraph/static	0.008s
ok  	golang.org/x/tools/go/cfg	0.018s
ok  	golang.org/x/tools/go/expect	0.019s
ok  	golang.org/x/tools/go/gccgoexportdata	0.010s
ok  	golang.org/x/tools/go/gcexportdata	0.013s
?   	golang.org/x/tools/go/internal/cgo	[no test files]
ok  	golang.org/x/tools/go/internal/gccgoimporter	0.045s
ok  	golang.org/x/tools/go/internal/gcimporter	40.366s
?   	golang.org/x/tools/go/internal/packagesdriver	[no test files]
ok  	golang.org/x/tools/go/loader	7.670s
ok  	golang.org/x/tools/go/packages	42.505s
?   	golang.org/x/tools/go/packages/gopackages	[no test files]
ok  	golang.org/x/tools/go/packages/packagestest	0.063s
ok  	golang.org/x/tools/go/pointer	7.943s
ok  	golang.org/x/tools/go/ssa	5.945s
ok  	golang.org/x/tools/go/ssa/interp	0.614s
ok  	golang.org/x/tools/go/ssa/ssautil	4.359s
ok  	golang.org/x/tools/go/types/objectpath	0.016s
ok  	golang.org/x/tools/go/types/typeutil	0.762s
ok  	golang.org/x/tools/go/vcs	0.036s
ok  	golang.org/x/tools/godoc	0.861s
?   	golang.org/x/tools/godoc/analysis	[no test files]
?   	golang.org/x/tools/godoc/golangorgenv	[no test files]
ok  	golang.org/x/tools/godoc/redirect	5.119s
ok  	golang.org/x/tools/godoc/static	2.033s
?   	golang.org/x/tools/godoc/util	[no test files]
ok  	golang.org/x/tools/godoc/vfs	0.025s
ok  	golang.org/x/tools/godoc/vfs/gatefs	0.033s
?   	golang.org/x/tools/godoc/vfs/httpfs	[no test files]
ok  	golang.org/x/tools/godoc/vfs/mapfs	0.037s
ok  	golang.org/x/tools/godoc/vfs/zipfs	0.025s
?   	golang.org/x/tools/imports	[no test files]
ok  	golang.org/x/tools/internal/apidiff	0.808s
ok  	golang.org/x/tools/internal/fastwalk	0.018s
ok  	golang.org/x/tools/internal/gopathwalk	0.005s
ok  	golang.org/x/tools/internal/imports	32.291s
ok  	golang.org/x/tools/internal/jsonrpc2	0.023s
ok  	golang.org/x/tools/internal/lsp	16.192s
?   	golang.org/x/tools/internal/lsp/browser	[no test files]
?   	golang.org/x/tools/internal/lsp/cache	[no test files]
ok  	golang.org/x/tools/internal/lsp/cmd	4.976s
?   	golang.org/x/tools/internal/lsp/debug	[no test files]
ok  	golang.org/x/tools/internal/lsp/diff	0.015s
?   	golang.org/x/tools/internal/lsp/diff/difftest	[no test files]
ok  	golang.org/x/tools/internal/lsp/diff/myers	0.012s
ok  	golang.org/x/tools/internal/lsp/fuzzy	0.011s
?   	golang.org/x/tools/internal/lsp/protocol	[no test files]
ok  	golang.org/x/tools/internal/lsp/snippet	0.011s
ok  	golang.org/x/tools/internal/lsp/source	14.266s
?   	golang.org/x/tools/internal/lsp/telemetry	[no test files]
?   	golang.org/x/tools/internal/lsp/tests	[no test files]
ok  	golang.org/x/tools/internal/memoize	0.045s
ok  	golang.org/x/tools/internal/module	0.004s
ok  	golang.org/x/tools/internal/semver	0.010s
ok  	golang.org/x/tools/internal/span	0.006s
?   	golang.org/x/tools/internal/telemetry	[no test files]
?   	golang.org/x/tools/internal/telemetry/export	[no test files]
ok  	golang.org/x/tools/internal/telemetry/export/ocagent	0.011s
?   	golang.org/x/tools/internal/telemetry/export/ocagent/wire	[no test files]
?   	golang.org/x/tools/internal/telemetry/export/prometheus	[no test files]
?   	golang.org/x/tools/internal/telemetry/log	[no test files]
?   	golang.org/x/tools/internal/telemetry/metric	[no test files]
?   	golang.org/x/tools/internal/telemetry/stats	[no test files]
?   	golang.org/x/tools/internal/telemetry/tag	[no test files]
?   	golang.org/x/tools/internal/telemetry/trace	[no test files]
?   	golang.org/x/tools/internal/telemetry/unit	[no test files]
?   	golang.org/x/tools/internal/testenv	[no test files]
?   	golang.org/x/tools/internal/tool	[no test files]
ok  	golang.org/x/tools/internal/txtar	0.013s
?   	golang.org/x/tools/internal/xcontext	[no test files]
?   	golang.org/x/tools/playground	[no test files]
ok  	golang.org/x/tools/playground/socket	0.015s
ok  	golang.org/x/tools/present	0.019s
ok  	golang.org/x/tools/refactor/eg	3.388s
ok  	golang.org/x/tools/refactor/importgraph	0.885s
ok  	golang.org/x/tools/refactor/rename	0.078s
?   	golang.org/x/tools/refactor/satisfy	[no test files]
linux-amd64-race (Go tip) - ran in module mode
  builder: linux-amd64-race
      rev: 0e015e20cfe7265635af605d274ff8dc2de5b3a2
 buildlet: http://10.240.0.227 GCE VM: buildlet-linux-jessie-rn08fcf81
  started: 2019-09-11 13:46:08.196533639 +0000 UTC m=+282.899171463
    ended: 2019-09-11 13:50:31.018847814 +0000 UTC m=+545.721485727
  success: true

Events:
  2019-09-11T13:46:08Z checking_for_snapshot 
  2019-09-11T13:46:08Z finish_checking_for_snapshot after 39.6ms
  2019-09-11T13:46:08Z get_buildlet 
  2019-09-11T13:46:08Z awaiting_gce_quota 
  2019-09-11T13:46:08Z finish_awaiting_gce_quota after 0s
  2019-09-11T13:46:08Z create_gce_buildlet buildlet-linux-jessie-rn08fcf81
  2019-09-11T13:46:08Z create_gce_instance buildlet-linux-jessie-rn08fcf81
  2019-09-11T13:46:19Z finish_create_gce_instance after 10.7s; buildlet-linux-jessie-rn08fcf81
  2019-09-11T13:46:19Z wait_buildlet_start buildlet-linux-jessie-rn08fcf81
  2019-09-11T13:46:21Z got_instance_info waiting_for_buildlet...
  2019-09-11T13:46:59Z finish_wait_buildlet_start after 39.8s; buildlet-linux-jessie-rn08fcf81
  2019-09-11T13:46:59Z finish_create_gce_buildlet after 50.7s; buildlet-linux-jessie-rn08fcf81
  2019-09-11T13:46:59Z finish_get_buildlet after 51s
  2019-09-11T13:46:59Z using_buildlet 10.240.0.227:80
  2019-09-11T13:46:59Z write_snapshot_tar 
  2019-09-11T13:47:03Z finish_write_snapshot_tar after 3.83s
  2019-09-11T13:47:03Z make_and_test 
  2019-09-11T13:47:03Z fetching_subrepo tools
  2019-09-11T13:47:03Z get_source 
  2019-09-11T13:47:03Z finish_get_source after 0s
  2019-09-11T13:47:03Z running_subrepo_tests tools
  2019-09-11T13:50:30Z finish_running_subrepo_tests after 3m27.1s; tools
  2019-09-11T13:50:31Z finish_make_and_test after 3m27.4s
  2019-09-11T13:50:31Z done all tests passed

Build log:
linux-amd64-race at 0e015e20cfe7265635af605d274ff8dc2de5b3a2 building tools at d876d77976bd0ae3fa7013f4d86ec4080237cc8c

testing in module mode; GOMOD=/workdir/gopath/src/golang.org/x/tools/go.mod
:: Running /workdir/go/bin/go with args ["/workdir/go/bin/go" "test" "-short" "-race" "golang.org/x/tools/..."] and env ["PATH=/workdir/go/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin" "HOSTNAME=buildlet-linux-jessie-rn08fcf81" "DEBIAN_FRONTEND=noninteractive" "HOME=/root" "USER=root" "GO_STAGE0_NET_DELAY=6s" "GO_STAGE0_DL_DELAY=0s" "WORKDIR=/workdir" "GOROOT_BOOTSTRAP=/workdir/go1.4" "GO_BUILDER_NAME=linux-amd64-race" "GOROOT_BOOTSTRAP=/go1.4" "GO_DISABLE_OUTBOUND_NETWORK=1" "GOROOT=/workdir/go" "GOPATH=/workdir/gopath" "GOPROXY=http://10.240.0.72:30157" "TMPDIR=/workdir/tmp" "GOCACHE=/workdir/gocache"] in dir /workdir/gopath/src/golang.org/x/tools

go: downloading golang.org/x/sync v0.0.0-20190423024810-112230192c58
go: extracting golang.org/x/sync v0.0.0-20190423024810-112230192c58
go: downloading golang.org/x/net v0.0.0-20190620200207-3b0461eec859
go: downloading golang.org/x/xerrors v0.0.0-20190717185122-a985d3407aa7
go: extracting golang.org/x/xerrors v0.0.0-20190717185122-a985d3407aa7
go: extracting golang.org/x/net v0.0.0-20190620200207-3b0461eec859
go: finding golang.org/x/net v0.0.0-20190620200207-3b0461eec859
go: finding golang.org/x/xerrors v0.0.0-20190717185122-a985d3407aa7
go: finding golang.org/x/sync v0.0.0-20190423024810-112230192c58
ok  	golang.org/x/tools/benchmark/parse	1.026s
ok  	golang.org/x/tools/blog	1.012s
?   	golang.org/x/tools/blog/atom	[no test files]
?   	golang.org/x/tools/cmd/auth/authtest	[no test files]
?   	golang.org/x/tools/cmd/auth/cookieauth	[no test files]
?   	golang.org/x/tools/cmd/auth/gitauth	[no test files]
?   	golang.org/x/tools/cmd/auth/netrcauth	[no test files]
ok  	golang.org/x/tools/cmd/benchcmp	1.009s
ok  	golang.org/x/tools/cmd/bundle	1.022s
ok  	golang.org/x/tools/cmd/callgraph	22.978s
?   	golang.org/x/tools/cmd/compilebench	[no test files]
ok  	golang.org/x/tools/cmd/cover	2.372s
ok  	golang.org/x/tools/cmd/digraph	1.019s
?   	golang.org/x/tools/cmd/eg	[no test files]
ok  	golang.org/x/tools/cmd/fiximports	8.145s
ok  	golang.org/x/tools/cmd/getgo	1.022s
?   	golang.org/x/tools/cmd/getgo/server	[no test files]
ok  	golang.org/x/tools/cmd/go-contrib-init	1.013s
?   	golang.org/x/tools/cmd/godex	[no test files]
ok  	golang.org/x/tools/cmd/godoc	14.044s
?   	golang.org/x/tools/cmd/goimports	[no test files]
?   	golang.org/x/tools/cmd/gomvpkg	[no test files]
?   	golang.org/x/tools/cmd/gopls	[no test files]
ok  	golang.org/x/tools/cmd/gorename	7.760s
?   	golang.org/x/tools/cmd/gotype	[no test files]
?   	golang.org/x/tools/cmd/goyacc	[no test files]
ok  	golang.org/x/tools/cmd/guru	1.039s
?   	golang.org/x/tools/cmd/guru/serial	[no test files]
?   	golang.org/x/tools/cmd/html2article	[no test files]
?   	golang.org/x/tools/cmd/present	[no test files]
?   	golang.org/x/tools/cmd/splitdwarf	[no test files]
ok  	golang.org/x/tools/cmd/splitdwarf/internal/macho	1.016s
?   	golang.org/x/tools/cmd/ssadump	[no test files]
?   	golang.org/x/tools/cmd/stress	[no test files]
ok  	golang.org/x/tools/cmd/stringer	24.431s
?   	golang.org/x/tools/cmd/toolstash	[no test files]
ok  	golang.org/x/tools/container/intsets	2.687s
?   	golang.org/x/tools/cover	[no test files]
?   	golang.org/x/tools/go/analysis	[no test files]
ok  	golang.org/x/tools/go/analysis/analysistest	1.141s
ok  	golang.org/x/tools/go/analysis/internal/analysisflags	7.166s
ok  	golang.org/x/tools/go/analysis/internal/checker	1.043s
ok  	golang.org/x/tools/go/analysis/internal/facts	1.097s
ok  	golang.org/x/tools/go/analysis/multichecker	58.859s
ok  	golang.org/x/tools/go/analysis/passes/asmdecl	2.290s
ok  	golang.org/x/tools/go/analysis/passes/assign	4.768s
ok  	golang.org/x/tools/go/analysis/passes/atomic	1.115s
ok  	golang.org/x/tools/go/analysis/passes/atomicalign	1.136s
ok  	golang.org/x/tools/go/analysis/passes/bools	3.713s
ok  	golang.org/x/tools/go/analysis/passes/buildssa	1.085s
ok  	golang.org/x/tools/go/analysis/passes/buildtag	1.043s
ok  	golang.org/x/tools/go/analysis/passes/cgocall	8.163s
ok  	golang.org/x/tools/go/analysis/passes/composite	8.910s
ok  	golang.org/x/tools/go/analysis/passes/copylock	4.582s
ok  	golang.org/x/tools/go/analysis/passes/ctrlflow	8.227s
ok  	golang.org/x/tools/go/analysis/passes/deepequalerrors	7.499s
ok  	golang.org/x/tools/go/analysis/passes/errorsas	5.134s
ok  	golang.org/x/tools/go/analysis/passes/findcall	1.370s
?   	golang.org/x/tools/go/analysis/passes/findcall/cmd/findcall	[no test files]
ok  	golang.org/x/tools/go/analysis/passes/httpresponse	13.480s
?   	golang.org/x/tools/go/analysis/passes/inspect	[no test files]
?   	golang.org/x/tools/go/analysis/passes/internal/analysisutil	[no test files]
ok  	golang.org/x/tools/go/analysis/passes/loopclosure	1.056s
ok  	golang.org/x/tools/go/analysis/passes/lostcancel	6.989s
?   	golang.org/x/tools/go/analysis/passes/lostcancel/cmd/lostcancel	[no test files]
ok  	golang.org/x/tools/go/analysis/passes/nilfunc	1.163s
ok  	golang.org/x/tools/go/analysis/passes/nilness	1.057s
?   	golang.org/x/tools/go/analysis/passes/nilness/cmd/nilness	[no test files]
ok  	golang.org/x/tools/go/analysis/passes/pkgfact	1.125s
ok  	golang.org/x/tools/go/analysis/passes/printf	8.827s
ok  	golang.org/x/tools/go/analysis/passes/shadow	4.953s
?   	golang.org/x/tools/go/analysis/passes/shadow/cmd/shadow	[no test files]
ok  	golang.org/x/tools/go/analysis/passes/shift	1.123s
ok  	golang.org/x/tools/go/analysis/passes/stdmethods	16.023s
ok  	golang.org/x/tools/go/analysis/passes/structtag	8.602s
ok  	golang.org/x/tools/go/analysis/passes/tests	7.950s
ok  	golang.org/x/tools/go/analysis/passes/unmarshal	6.972s
?   	golang.org/x/tools/go/analysis/passes/unmarshal/cmd/unmarshal	[no test files]
ok  	golang.org/x/tools/go/analysis/passes/unreachable	1.135s
ok  	golang.org/x/tools/go/analysis/passes/unsafeptr	5.656s
ok  	golang.org/x/tools/go/analysis/passes/unusedresult	6.436s
?   	golang.org/x/tools/go/analysis/singlechecker	[no test files]
ok  	golang.org/x/tools/go/analysis/unitchecker	26.245s
ok  	golang.org/x/tools/go/ast/astutil	1.123s
ok  	golang.org/x/tools/go/ast/inspector	1.377s
ok  	golang.org/x/tools/go/buildutil	1.113s
?   	golang.org/x/tools/go/callgraph	[no test files]
ok  	golang.org/x/tools/go/callgraph/cha	1.023s
ok  	golang.org/x/tools/go/callgraph/rta	1.023s
ok  	golang.org/x/tools/go/callgraph/static	1.015s
ok  	golang.org/x/tools/go/cfg	1.008s
ok  	golang.org/x/tools/go/expect	1.007s
ok  	golang.org/x/tools/go/gccgoexportdata	1.009s
ok  	golang.org/x/tools/go/gcexportdata	1.173s
?   	golang.org/x/tools/go/internal/cgo	[no test files]
ok  	golang.org/x/tools/go/internal/gccgoimporter	1.041s
ok  	golang.org/x/tools/go/internal/gcimporter	27.787s
?   	golang.org/x/tools/go/internal/packagesdriver	[no test files]
ok  	golang.org/x/tools/go/loader	22.944s
ok  	golang.org/x/tools/go/packages	58.873s
?   	golang.org/x/tools/go/packages/gopackages	[no test files]
ok  	golang.org/x/tools/go/packages/packagestest	1.166s
ok  	golang.org/x/tools/go/pointer	17.422s
ok  	golang.org/x/tools/go/ssa	23.819s
ok  	golang.org/x/tools/go/ssa/interp	2.342s
ok  	golang.org/x/tools/go/ssa/ssautil	11.265s
ok  	golang.org/x/tools/go/types/objectpath	1.031s
ok  	golang.org/x/tools/go/types/typeutil	4.922s
ok  	golang.org/x/tools/go/vcs	1.055s
ok  	golang.org/x/tools/godoc	3.950s
?   	golang.org/x/tools/godoc/analysis	[no test files]
?   	golang.org/x/tools/godoc/golangorgenv	[no test files]
ok  	golang.org/x/tools/godoc/redirect	6.225s
ok  	golang.org/x/tools/godoc/static	19.271s
?   	golang.org/x/tools/godoc/util	[no test files]
ok  	golang.org/x/tools/godoc/vfs	1.014s
ok  	golang.org/x/tools/godoc/vfs/gatefs	1.041s
?   	golang.org/x/tools/godoc/vfs/httpfs	[no test files]
ok  	golang.org/x/tools/godoc/vfs/mapfs	1.049s
ok  	golang.org/x/tools/godoc/vfs/zipfs	1.053s
?   	golang.org/x/tools/imports	[no test files]
ok  	golang.org/x/tools/internal/apidiff	1.728s
ok  	golang.org/x/tools/internal/fastwalk	1.020s
ok  	golang.org/x/tools/internal/gopathwalk	1.022s
ok  	golang.org/x/tools/internal/imports	36.656s
ok  	golang.org/x/tools/internal/jsonrpc2	1.018s
ok  	golang.org/x/tools/internal/lsp	19.483s
?   	golang.org/x/tools/internal/lsp/browser	[no test files]
?   	golang.org/x/tools/internal/lsp/cache	[no test files]
ok  	golang.org/x/tools/internal/lsp/cmd	10.759s
?   	golang.org/x/tools/internal/lsp/debug	[no test files]
ok  	golang.org/x/tools/internal/lsp/diff	1.036s
?   	golang.org/x/tools/internal/lsp/diff/difftest	[no test files]
ok  	golang.org/x/tools/internal/lsp/diff/myers	1.037s
ok  	golang.org/x/tools/internal/lsp/fuzzy	1.066s
?   	golang.org/x/tools/internal/lsp/protocol	[no test files]
ok  	golang.org/x/tools/internal/lsp/snippet	1.023s
ok  	golang.org/x/tools/internal/lsp/source	20.112s
?   	golang.org/x/tools/internal/lsp/telemetry	[no test files]
?   	golang.org/x/tools/internal/lsp/tests	[no test files]
ok  	golang.org/x/tools/internal/memoize	1.020s
ok  	golang.org/x/tools/internal/module	1.040s
ok  	golang.org/x/tools/internal/semver	1.013s
ok  	golang.org/x/tools/internal/span	1.015s
?   	golang.org/x/tools/internal/telemetry	[no test files]
?   	golang.org/x/tools/internal/telemetry/export	[no test files]
ok  	golang.org/x/tools/internal/telemetry/export/ocagent	1.011s
?   	golang.org/x/tools/internal/telemetry/export/ocagent/wire	[no test files]
?   	golang.org/x/tools/internal/telemetry/export/prometheus	[no test files]
?   	golang.org/x/tools/internal/telemetry/log	[no test files]
?   	golang.org/x/tools/internal/telemetry/metric	[no test files]
?   	golang.org/x/tools/internal/telemetry/stats	[no test files]
?   	golang.org/x/tools/internal/telemetry/tag	[no test files]
?   	golang.org/x/tools/internal/telemetry/trace	[no test files]
?   	golang.org/x/tools/internal/telemetry/unit	[no test files]
?   	golang.org/x/tools/internal/testenv	[no test files]
?   	golang.org/x/tools/internal/tool	[no test files]
ok  	golang.org/x/tools/internal/txtar	1.016s
?   	golang.org/x/tools/internal/xcontext	[no test files]
?   	golang.org/x/tools/playground	[no test files]
ok  	golang.org/x/tools/playground/socket	1.016s
ok  	golang.org/x/tools/present	1.028s
ok  	golang.org/x/tools/refactor/eg	10.939s
ok  	golang.org/x/tools/refactor/importgraph	5.004s
ok  	golang.org/x/tools/refactor/rename	1.351s
?   	golang.org/x/tools/refactor/satisfy	[no test files]
windows-386-2008 (Go tip) - ran in module mode
  builder: windows-386-2008
      rev: 0e015e20cfe7265635af605d274ff8dc2de5b3a2
 buildlet: http://10.240.0.223 GCE VM: buildlet-windows-amd64-2008-rncdf4836
  started: 2019-09-11 13:46:08.19654547 +0000 UTC m=+282.899183299
   status: still running

Events:
  2019-09-11T13:46:08Z checking_for_snapshot 
  2019-09-11T13:46:08Z finish_checking_for_snapshot after 11.5ms
  2019-09-11T13:46:08Z get_buildlet 
  2019-09-11T13:46:08Z awaiting_gce_quota 
  2019-09-11T13:46:08Z finish_awaiting_gce_quota after 0s
  2019-09-11T13:46:08Z create_gce_buildlet buildlet-windows-amd64-2008-rncdf4836
  2019-09-11T13:46:08Z create_gce_instance buildlet-windows-amd64-2008-rncdf4836
  2019-09-11T13:46:19Z finish_create_gce_instance after 10.4s; buildlet-windows-amd64-2008-rncdf4836
  2019-09-11T13:46:19Z wait_buildlet_start buildlet-windows-amd64-2008-rncdf4836
  2019-09-11T13:46:20Z got_instance_info waiting_for_buildlet...
  2019-09-11T13:47:03Z finish_wait_buildlet_start after 44.3s; buildlet-windows-amd64-2008-rncdf4836
  2019-09-11T13:47:03Z finish_create_gce_buildlet after 54.9s; buildlet-windows-amd64-2008-rncdf4836
  2019-09-11T13:47:03Z finish_get_buildlet after 55s
  2019-09-11T13:47:03Z using_buildlet 10.240.0.223:80
  2019-09-11T13:47:03Z write_snapshot_tar 
  2019-09-11T13:47:13Z finish_write_snapshot_tar after 9.66s
  2019-09-11T13:47:13Z make_and_test 
  2019-09-11T13:47:13Z fetching_subrepo tools
  2019-09-11T13:47:13Z get_source 
  2019-09-11T13:47:13Z finish_get_source after 0s
  2019-09-11T13:47:15Z running_subrepo_tests tools
 +213.3s (now)

Build log:
windows-386-2008 at 0e015e20cfe7265635af605d274ff8dc2de5b3a2 building tools at d876d77976bd0ae3fa7013f4d86ec4080237cc8c

testing in module mode; GOMOD=C:\workdir\gopath\src\golang.org\x\tools\go.mod
:: Running C:\workdir\go\bin\go with args ["C:\\workdir\\go\\bin\\go" "test" "-short" "golang.org/x/tools/..."] and env ["GOBUILDEXIT=1" "=::=::\\" "=C:=C:\\golang" "ALLUSERSPROFILE=C:\\ProgramData" "APPDATA=C:\\Users\\gopher\\AppData\\Roaming" "CommonProgramFiles=C:\\Program Files\\Common Files" "CommonProgramFiles(x86)=C:\\Program Files (x86)\\Common Files" "CommonProgramW6432=C:\\Program Files\\Common Files" "COMPUTERNAME=SERVER-2008R2-V" "ComSpec=C:\\Windows\\system32\\cmd.exe" "FP_NO_HOST_CHECK=NO" "GooGetRoot=C:\\ProgramData\\GooGet" "GOROOT_BOOTSTRAP=C:\\workdir\\go1.4" "HOMEDRIVE=C:" "HOMEPATH=\\Users\\gopher" "LOCALAPPDATA=C:\\Users\\gopher\\AppData\\Local" "LOGONSERVER=\\\\SERVER-2008R2-V" "NUMBER_OF_PROCESSORS=4" "OS=Windows_NT" "PATH=C:\\workdir/go/bin;C:\\Windows\\system32;C:\\Windows;C:\\Windows\\System32\\Wbem;C:\\Windows\\System32\\WindowsPowerShell\\v1.0\\;C:\\Windows\\System32\\WindowsPowerShell\\v1.0\\;C:\\ProgramData\\GooGet;C:\\Program Files\\Google\\Compute Engine\\metadata_scripts;C:\\Program Files (x86)\\Google\\Cloud SDK\\google-cloud-sdk\\bin;C:\\Windows\\System32\\WindowsPowerShell\\v1.0\\;C:\\Program Files\\Google\\Compute Engine\\sysprep;C:\\godep\\gcc32\\bin" "PATHEXT=.COM;.EXE;.BAT;.CMD;.VBS;.VBE;.JS;.JSE;.WSF;.WSH;.MSC" "PROCESSOR_ARCHITECTURE=AMD64" "PROCESSOR_IDENTIFIER=Intel64 Family 6 Model 63 Stepping 0, GenuineIntel" "PROCESSOR_LEVEL=6" "PROCESSOR_REVISION=3f00" "ProgramData=C:\\ProgramData" "ProgramFiles=C:\\Program Files" "ProgramFiles(x86)=C:\\Program Files (x86)" "ProgramW6432=C:\\Program Files" "PROMPT=$P$G" "PSModulePath=C:\\Windows\\system32\\WindowsPowerShell\\v1.0\\Modules\\;C:\\Program Files (x86)\\Google\\Cloud SDK\\google-cloud-sdk\\platform\\PowerShell" "PUBLIC=C:\\Users\\Public" "SESSIONNAME=Console" "SystemDrive=C:" "SystemRoot=C:\\Windows" "TEMP=C:\\Users\\gopher\\AppData\\Local\\Temp" "TMP=C:\\Users\\gopher\\AppData\\Local\\Temp" "USERDOMAIN=SERVER-2008R2-V" "USERDOMAIN_ROAMINGPROFILE=SERVER-2008R2-V" "USERNAME=gopher" "USERPROFILE=C:\\Users\\gopher" "windir=C:\\Windows" "windows_tracing_flags=3" "windows_tracing_logfile=C:\\BVTBin\\Tests\\installpackage\\csilogfile.log" "GO_STAGE0_NET_DELAY=37.2s" "GO_STAGE0_DL_DELAY=100ms" "WORKDIR=C:\\workdir" "GO_BUILDER_NAME=windows-386-2008" "GOARCH=386" "GOHOSTARCH=386" "GOROOT=C:\\workdir\\go" "GOPATH=C:\\workdir\\gopath" "GOPROXY=http://10.240.0.72:30157"] in dir C:\workdir\gopath\src\golang.org\x\tools

go: downloading golang.org/x/xerrors v0.0.0-20190717185122-a985d3407aa7
go: downloading golang.org/x/net v0.0.0-20190620200207-3b0461eec859
go: downloading golang.org/x/sync v0.0.0-20190423024810-112230192c58
go: extracting golang.org/x/xerrors v0.0.0-20190717185122-a985d3407aa7
go: extracting golang.org/x/sync v0.0.0-20190423024810-112230192c58
go: extracting golang.org/x/net v0.0.0-20190620200207-3b0461eec859
go: finding golang.org/x/net v0.0.0-20190620200207-3b0461eec859
go: finding golang.org/x/xerrors v0.0.0-20190717185122-a985d3407aa7
go: finding golang.org/x/sync v0.0.0-20190423024810-112230192c58
ok  	golang.org/x/tools/benchmark/parse	0.050s
ok  	golang.org/x/tools/blog	0.053s
?   	golang.org/x/tools/blog/atom	[no test files]
?   	golang.org/x/tools/cmd/auth/authtest	[no test files]
?   	golang.org/x/tools/cmd/auth/cookieauth	[no test files]
?   	golang.org/x/tools/cmd/auth/gitauth	[no test files]
?   	golang.org/x/tools/cmd/auth/netrcauth	[no test files]
ok  	golang.org/x/tools/cmd/benchcmp	0.102s
ok  	golang.org/x/tools/cmd/bundle	0.073s
ok  	golang.org/x/tools/cmd/callgraph	8.728s
?   	golang.org/x/tools/cmd/compilebench	[no test files]
ok  	golang.org/x/tools/cmd/cover	4.635s
ok  	golang.org/x/tools/cmd/digraph	0.064s
?   	golang.org/x/tools/cmd/eg	[no test files]
ok  	golang.org/x/tools/cmd/fiximports	22.106s
ok  	golang.org/x/tools/cmd/getgo	2.814s
?   	golang.org/x/tools/cmd/getgo/server	[no test files]
ok  	golang.org/x/tools/cmd/go-contrib-init	0.109s
?   	golang.org/x/tools/cmd/godex	[no test files]
ok  	golang.org/x/tools/cmd/godoc	16.199s
?   	golang.org/x/tools/cmd/goimports	[no test files]
?   	golang.org/x/tools/cmd/gomvpkg	[no test files]
?   	golang.org/x/tools/cmd/gopls	[no test files]
ok  	golang.org/x/tools/cmd/gorename	19.331s
?   	golang.org/x/tools/cmd/gotype	[no test files]
?   	golang.org/x/tools/cmd/goyacc	[no test files]
ok  	golang.org/x/tools/cmd/guru	0.077s
?   	golang.org/x/tools/cmd/guru/serial	[no test files]
?   	golang.org/x/tools/cmd/html2article	[no test files]
?   	golang.org/x/tools/cmd/present	[no test files]
ok  	golang.org/x/tools/cmd/splitdwarf/internal/macho	0.064s
?   	golang.org/x/tools/cmd/ssadump	[no test files]
?   	golang.org/x/tools/cmd/stress	[no test files]
ok  	golang.org/x/tools/cmd/stringer	46.637s
?   	golang.org/x/tools/cmd/toolstash	[no test files]
ok  	golang.org/x/tools/container/intsets	0.728s
?   	golang.org/x/tools/cover	[no test files]
?   	golang.org/x/tools/go/analysis	[no test files]
ok  	golang.org/x/tools/go/analysis/analysistest	0.328s
ok  	golang.org/x/tools/go/analysis/internal/analysisflags	0.036s
ok  	golang.org/x/tools/go/analysis/internal/checker	0.367s
ok  	golang.org/x/tools/go/analysis/internal/facts	0.826s
ok  	golang.org/x/tools/go/analysis/multichecker	0.046s
ok  	golang.org/x/tools/go/analysis/passes/asmdecl	1.761s
ok  	golang.org/x/tools/go/analysis/passes/assign	1.369s
ok  	golang.org/x/tools/go/analysis/passes/atomic	0.216s
ok  	golang.org/x/tools/go/analysis/passes/atomicalign	2.130s
ok  	golang.org/x/tools/go/analysis/passes/bools	1.331s
ok  	golang.org/x/tools/go/analysis/passes/buildssa	0.131s
ok  	golang.org/x/tools/go/analysis/passes/buildtag	0.230s
ok  	golang.org/x/tools/go/analysis/passes/cgocall	3.764s
ok  	golang.org/x/tools/go/analysis/passes/composite	1.811s
ok  	golang.org/x/tools/go/analysis/passes/copylock	2.036s
ok  	golang.org/x/tools/go/analysis/passes/ctrlflow	2.655s
ok  	golang.org/x/tools/go/analysis/passes/deepequalerrors	2.022s
ok  	golang.org/x/tools/go/analysis/passes/errorsas	0.961s
ok  	golang.org/x/tools/go/analysis/passes/findcall	0.861s
?   	golang.org/x/tools/go/analysis/passes/findcall/cmd/findcall	[no test files]
ok  	golang.org/x/tools/go/analysis/passes/httpresponse	2.269s
?   	golang.org/x/tools/go/analysis/passes/inspect	[no test files]
?   	golang.org/x/tools/go/analysis/passes/internal/analysisutil	[no test files]
ok  	golang.org/x/tools/go/analysis/passes/loopclosure	0.179s
ok  	golang.org/x/tools/go/analysis/passes/lostcancel	2.950s
?   	golang.org/x/tools/go/analysis/passes/lostcancel/cmd/lostcancel	[no test files]
ok  	golang.org/x/tools/go/analysis/passes/nilfunc	0.509s
ok  	golang.org/x/tools/go/analysis/passes/nilness	0.144s
?   	golang.org/x/tools/go/analysis/passes/nilness/cmd/nilness	[no test files]
ok  	golang.org/x/tools/go/analysis/passes/pkgfact	0.155s
ok  	golang.org/x/tools/go/analysis/passes/printf	2.407s
ok  	golang.org/x/tools/go/analysis/passes/shadow	2.043s
?   	golang.org/x/tools/go/analysis/passes/shadow/cmd/shadow	[no test files]
ok  	golang.org/x/tools/go/analysis/passes/shift	0.323s
ok  	golang.org/x/tools/go/analysis/passes/stdmethods	4.551s
ok  	golang.org/x/tools/go/analysis/passes/structtag	1.953s
ok  	golang.org/x/tools/go/analysis/passes/tests	3.025s
ok  	golang.org/x/tools/go/analysis/passes/unmarshal	1.812s
?   	golang.org/x/tools/go/analysis/passes/unmarshal/cmd/unmarshal	[no test files]
ok  	golang.org/x/tools/go/analysis/passes/unreachable	0.312s
ok  	golang.org/x/tools/go/analysis/passes/unsafeptr	2.035s
ok  	golang.org/x/tools/go/analysis/passes/unusedresult	2.448s
?   	golang.org/x/tools/go/analysis/singlechecker	[no test files]
ok  	golang.org/x/tools/go/analysis/unitchecker	0.125s
ok  	golang.org/x/tools/go/ast/astutil	0.084s
ok  	golang.org/x/tools/go/ast/inspector	0.338s
ok  	golang.org/x/tools/go/buildutil	0.111s
?   	golang.org/x/tools/go/callgraph	[no test files]
ok  	golang.org/x/tools/go/callgraph/cha	0.049s
ok  	golang.org/x/tools/go/callgraph/rta	0.047s
ok  	golang.org/x/tools/go/callgraph/static	0.049s
ok  	golang.org/x/tools/go/cfg	0.055s
ok  	golang.org/x/tools/go/expect	0.052s
ok  	golang.org/x/tools/go/gccgoexportdata	0.055s
ok  	golang.org/x/tools/go/gcexportdata	0.062s
?   	golang.org/x/tools/go/internal/cgo	[no test files]
ok  	golang.org/x/tools/go/internal/gccgoimporter	0.059s
ok  	golang.org/x/tools/go/internal/gcimporter	31.254s
?   	golang.org/x/tools/go/internal/packagesdriver	[no test files]
ok  	golang.org/x/tools/go/loader	7.159s
ok  	golang.org/x/tools/go/packages	58.463s
?   	golang.org/x/tools/go/packages/gopackages	[no test files]
ok  	golang.org/x/tools/go/packages/packagestest	0.358s
ok  	golang.org/x/tools/go/pointer	4.837s
ok  	golang.org/x/tools/go/ssa	6.942s
ok  	golang.org/x/tools/go/ssa/interp	1.874s
ok  	golang.org/x/tools/go/ssa/ssautil	2.868s
ok  	golang.org/x/tools/go/types/objectpath	0.048s
ok  	golang.org/x/tools/go/types/typeutil	1.200s
ok  	golang.org/x/tools/go/vcs	0.059s
ok  	golang.org/x/tools/godoc	0.920s
?   	golang.org/x/tools/godoc/analysis	[no test files]
?   	golang.org/x/tools/godoc/golangorgenv	[no test files]
ok  	golang.org/x/tools/godoc/redirect	0.434s
ok  	golang.org/x/tools/godoc/static	1.775s
?   	golang.org/x/tools/godoc/util	[no test files]
ok  	golang.org/x/tools/godoc/vfs	0.050s
ok  	golang.org/x/tools/godoc/vfs/gatefs	0.058s
?   	golang.org/x/tools/godoc/vfs/httpfs	[no test files]
ok  	golang.org/x/tools/godoc/vfs/mapfs	0.039s
ok  	golang.org/x/tools/godoc/vfs/zipfs	0.125s
?   	golang.org/x/tools/imports	[no test files]
ok  	golang.org/x/tools/internal/apidiff	1.113s
ok  	golang.org/x/tools/internal/fastwalk	0.061s
ok  	golang.org/x/tools/internal/gopathwalk	0.050s
ok  	golang.org/x/tools/internal/imports	56.099s
ok  	golang.org/x/tools/internal/jsonrpc2	0.211s
ok  	golang.org/x/tools/internal/lsp	32.700s
?   	golang.org/x/tools/internal/lsp/browser	[no test files]
?   	golang.org/x/tools/internal/lsp/cache	[no test files]
ok  	golang.org/x/tools/internal/lsp/cmd	10.428s
?   	golang.org/x/tools/internal/lsp/debug	[no test files]
ok  	golang.org/x/tools/internal/lsp/diff	0.037s
?   	golang.org/x/tools/internal/lsp/diff/difftest	[no test files]
ok  	golang.org/x/tools/internal/lsp/diff/myers	0.032s
ok  	golang.org/x/tools/internal/lsp/fuzzy	0.042s
?   	golang.org/x/tools/internal/lsp/protocol	[no test files]
ok  	golang.org/x/tools/internal/lsp/snippet	0.030s
ok  	golang.org/x/tools/internal/lsp/source	25.289s
?   	golang.org/x/tools/internal/lsp/telemetry	[no test files]
?   	golang.org/x/tools/internal/lsp/tests	[no test files]
ok  	golang.org/x/tools/internal/memoize	0.032s
ok  	golang.org/x/tools/internal/module	0.038s
ok  	golang.org/x/tools/internal/semver	0.037s
ok  	golang.org/x/tools/internal/span	0.054s
?   	golang.org/x/tools/internal/telemetry	[no test files]
?   	golang.org/x/tools/internal/telemetry/export	[no test files]
ok  	golang.org/x/tools/internal/telemetry/export/ocagent	0.052s
?   	golang.org/x/tools/internal/telemetry/export/ocagent/wire	[no test files]
?   	golang.org/x/tools/internal/telemetry/export/prometheus	[no test files]
?   	golang.org/x/tools/internal/telemetry/log	[no test files]
?   	golang.org/x/tools/internal/telemetry/metric	[no test files]
?   	golang.org/x/tools/internal/telemetry/stats	[no test files]
?   	golang.org/x/tools/internal/telemetry/tag	[no test files]
?   	golang.org/x/tools/internal/telemetry/trace	[no test files]
?   	golang.org/x/tools/internal/telemetry/unit	[no test files]
?   	golang.org/x/tools/internal/testenv	[no test files]
?   	golang.org/x/tools/internal/tool	[no test files]
ok  	golang.org/x/tools/internal/txtar	0.054s
?   	golang.org/x/tools/internal/xcontext	[no test files]
?   	golang.org/x/tools/playground	[no test files]
ok  	golang.org/x/tools/playground/socket	0.043s
ok  	golang.org/x/tools/present	0.050s
ok  	golang.org/x/tools/refactor/eg	0.058s
ok  	golang.org/x/tools/refactor/importgraph	3.147s
ok  	golang.org/x/tools/refactor/rename	0.251s
?   	golang.org/x/tools/refactor/satisfy	[no test files]
android-amd64-emu (Go tip) - ran in module mode
  builder: android-amd64-emu
      rev: 0e015e20cfe7265635af605d274ff8dc2de5b3a2
 buildlet: http://10.240.0.226 GCE VM: buildlet-android-amd64-emu-rne450bca
  started: 2019-09-11 13:46:08.196506607 +0000 UTC m=+282.899144437
   status: still running

Events:
  2019-09-11T13:46:08Z checking_for_snapshot 
  2019-09-11T13:46:08Z finish_checking_for_snapshot after 19.4ms
  2019-09-11T13:46:08Z get_buildlet 
  2019-09-11T13:46:08Z awaiting_gce_quota 
  2019-09-11T13:46:08Z finish_awaiting_gce_quota after 0s
  2019-09-11T13:46:08Z create_gce_buildlet buildlet-android-amd64-emu-rne450bca
  2019-09-11T13:46:08Z create_gce_instance buildlet-android-amd64-emu-rne450bca
  2019-09-11T13:46:19Z finish_create_gce_instance after 10.6s; buildlet-android-amd64-emu-rne450bca
  2019-09-11T13:46:19Z wait_buildlet_start buildlet-android-amd64-emu-rne450bca
  2019-09-11T13:46:20Z got_instance_info waiting_for_buildlet...
  2019-09-11T13:47:09Z finish_wait_buildlet_start after 49.6s; buildlet-android-amd64-emu-rne450bca
  2019-09-11T13:47:09Z finish_create_gce_buildlet after 1m0.4s; buildlet-android-amd64-emu-rne450bca
  2019-09-11T13:47:09Z finish_get_buildlet after 1m0.6s
  2019-09-11T13:47:09Z using_buildlet 10.240.0.226:80
  2019-09-11T13:47:09Z write_snapshot_tar 
  2019-09-11T13:47:16Z finish_write_snapshot_tar after 7.11s
  2019-09-11T13:47:16Z make_and_test 
  2019-09-11T13:47:16Z fetching_subrepo tools
  2019-09-11T13:47:16Z get_source 
  2019-09-11T13:47:16Z finish_get_source after 0s
  2019-09-11T13:47:16Z running_subrepo_tests tools
 +164.0s (now)

Build log:
android-amd64-emu at 0e015e20cfe7265635af605d274ff8dc2de5b3a2 building tools at d876d77976bd0ae3fa7013f4d86ec4080237cc8c

testing in module mode; GOMOD=/workdir/gopath/src/golang.org/x/tools/go.mod
:: Running /workdir/go/bin/go with args ["/workdir/go/bin/go" "test" "-short" "golang.org/x/tools/..."] and env ["PATH=/workdir/go/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/android/sdk/platform-tools:/android/sdk/build-tools/27.0.3:/android/gradle/bin" "HOSTNAME=buildlet-android-amd64-emu-rne450bca" "DEBIAN_FRONTEND=noninteractive" "GO_BUILDER_ENV=android-amd64-emu" "ANDROID_HOME=/android/sdk" "CGO_CFLAGS=-I/android/openal-headers" "CC_FOR_android_386=/android/sdk/ndk-bundle/toolchains/llvm/prebuilt/linux-x86_64/bin/i686-linux-android26-clang" "CC_FOR_android_amd64=/android/sdk/ndk-bundle/toolchains/llvm/prebuilt/linux-x86_64/bin/x86_64-linux-android26-clang" "HOME=/root" "USER=root" "GO_STAGE0_NET_DELAY=100ms" "GO_STAGE0_DL_DELAY=0s" "WORKDIR=/workdir" "GOROOT_BOOTSTRAP=/workdir/go1.4" "GO_BUILDER_NAME=android-amd64-emu" "GOROOT_BOOTSTRAP=/go1.4" "GOARCH=amd64" "GOOS=android" "GOHOSTARCH=amd64" "GOHOSTOS=linux" "CGO_ENABLED=1" "GOROOT=/workdir/go" "GOPATH=/workdir/gopath" "GOPROXY=http://10.240.0.72:30157" "TMPDIR=/workdir/tmp" "GOCACHE=/workdir/gocache"] in dir /workdir/gopath/src/golang.org/x/tools

go: downloading golang.org/x/net v0.0.0-20190620200207-3b0461eec859
go: downloading golang.org/x/xerrors v0.0.0-20190717185122-a985d3407aa7
go: extracting golang.org/x/xerrors v0.0.0-20190717185122-a985d3407aa7
go: downloading golang.org/x/sync v0.0.0-20190423024810-112230192c58
go: extracting golang.org/x/sync v0.0.0-20190423024810-112230192c58
go: extracting golang.org/x/net v0.0.0-20190620200207-3b0461eec859
go: finding golang.org/x/net v0.0.0-20190620200207-3b0461eec859
go: finding golang.org/x/xerrors v0.0.0-20190717185122-a985d3407aa7
go: finding golang.org/x/sync v0.0.0-20190423024810-112230192c58
ok  	golang.org/x/tools/benchmark/parse	65.795s
ok  	golang.org/x/tools/blog	63.634s
?   	golang.org/x/tools/blog/atom	[no test files]
?   	golang.org/x/tools/cmd/auth/authtest	[no test files]
?   	golang.org/x/tools/cmd/auth/cookieauth	[no test files]
?   	golang.org/x/tools/cmd/auth/gitauth	[no test files]
?   	golang.org/x/tools/cmd/auth/netrcauth	[no test files]
ok  	golang.org/x/tools/cmd/benchcmp	65.800s
ok  	golang.org/x/tools/cmd/bundle	63.660s
?   	golang.org/x/tools/cmd/callgraph	[no test files]
?   	golang.org/x/tools/cmd/compilebench	[no test files]
?   	golang.org/x/tools/cmd/cover	[no test files]
ok  	golang.org/x/tools/cmd/digraph	0.819s
?   	golang.org/x/tools/cmd/eg	[no test files]
?   	golang.org/x/tools/cmd/fiximports	[no test files]
ok  	golang.org/x/tools/cmd/getgo	2.410s
?   	golang.org/x/tools/cmd/getgo/server	[no test files]
ok  	golang.org/x/tools/cmd/go-contrib-init	0.697s
?   	golang.org/x/tools/cmd/godex	[no test files]
ok  	golang.org/x/tools/cmd/godoc	1.790s
?   	golang.org/x/tools/cmd/goimports	[no test files]
?   	golang.org/x/tools/cmd/gomvpkg	[no test files]
?   	golang.org/x/tools/cmd/gopls	[no test files]
ok  	golang.org/x/tools/cmd/gorename	0.998s
?   	golang.org/x/tools/cmd/gotype	[no test files]
?   	golang.org/x/tools/cmd/goyacc	[no test files]
ok  	golang.org/x/tools/cmd/guru	1.618s
?   	golang.org/x/tools/cmd/guru/serial	[no test files]
?   	golang.org/x/tools/cmd/html2article	[no test files]
?   	golang.org/x/tools/cmd/present	[no test files]
?   	golang.org/x/tools/cmd/splitdwarf	[no test files]
ok  	golang.org/x/tools/cmd/splitdwarf/internal/macho	2.667s
?   	golang.org/x/tools/cmd/ssadump	[no test files]
?   	golang.org/x/tools/cmd/stress	[no test files]
ok  	golang.org/x/tools/cmd/stringer	1.997s
?   	golang.org/x/tools/cmd/toolstash	[no test files]
ok  	golang.org/x/tools/container/intsets	3.936s
?   	golang.org/x/tools/cover	[no test files]
?   	golang.org/x/tools/go/analysis	[no test files]
ok  	golang.org/x/tools/go/analysis/analysistest	1.741s
ok  	golang.org/x/tools/go/analysis/internal/analysisflags	2.692s
ok  	golang.org/x/tools/go/analysis/internal/checker	0.731s
ok  	golang.org/x/tools/go/analysis/internal/facts	1.856s
ok  	golang.org/x/tools/go/analysis/multichecker	1.480s
ok  	golang.org/x/tools/go/analysis/passes/asmdecl	2.213s
ok  	golang.org/x/tools/go/analysis/passes/assign	4.569s
ok  	golang.org/x/tools/go/analysis/passes/atomic	1.515s
ok  	golang.org/x/tools/go/analysis/passes/atomicalign	3.847s
ok  	golang.org/x/tools/go/analysis/passes/bools	3.849s
ok  	golang.org/x/tools/go/analysis/passes/buildssa	3.419s
ok  	golang.org/x/tools/go/analysis/passes/buildtag	1.787s
ok  	golang.org/x/tools/go/analysis/passes/cgocall	6.969s
ok  	golang.org/x/tools/go/analysis/passes/composite	3.574s
ok  	golang.org/x/tools/go/analysis/passes/copylock	9.773s
ok  	golang.org/x/tools/go/analysis/passes/ctrlflow	7.746s
ok  	golang.org/x/tools/go/analysis/passes/deepequalerrors	8.541s
ok  	golang.org/x/tools/go/analysis/passes/errorsas	7.807s
ok  	golang.org/x/tools/go/analysis/passes/findcall	5.715s
?   	golang.org/x/tools/go/analysis/passes/findcall/cmd/findcall	[no test files]
ok  	golang.org/x/tools/go/analysis/passes/httpresponse	9.660s
?   	golang.org/x/tools/go/analysis/passes/inspect	[no test files]
?   	golang.org/x/tools/go/analysis/passes/internal/analysisutil	[no test files]
ok  	golang.org/x/tools/go/analysis/passes/loopclosure	1.717s
ok  	golang.org/x/tools/go/analysis/passes/lostcancel	8.242s
?   	golang.org/x/tools/go/analysis/passes/lostcancel/cmd/lostcancel	[no test files]
ok  	golang.org/x/tools/go/analysis/passes/nilfunc	8.362s
ok  	golang.org/x/tools/go/analysis/passes/nilness	7.516s
?   	golang.org/x/tools/go/analysis/passes/nilness/cmd/nilness	[no test files]
ok  	golang.org/x/tools/go/analysis/passes/pkgfact	3.072s
ok  	golang.org/x/tools/go/analysis/passes/printf	5.551s
ok  	golang.org/x/tools/go/analysis/passes/shadow	2.197s
?   	golang.org/x/tools/go/analysis/passes/shadow/cmd/shadow	[no test files]
ok  	golang.org/x/tools/go/analysis/passes/shift	2.067s
ok  	golang.org/x/tools/go/analysis/passes/stdmethods	8.202s
ok  	golang.org/x/tools/go/analysis/passes/structtag	8.400s
ok  	golang.org/x/tools/go/analysis/passes/tests	12.995s
ok  	golang.org/x/tools/go/analysis/passes/unmarshal	7.696s
?   	golang.org/x/tools/go/analysis/passes/unmarshal/cmd/unmarshal	[no test files]
ok  	golang.org/x/tools/go/analysis/passes/unreachable	6.880s
ok  	golang.org/x/tools/go/analysis/passes/unsafeptr	8.494s
ok  	golang.org/x/tools/go/analysis/passes/unusedresult	4.743s
?   	golang.org/x/tools/go/analysis/singlechecker	[no test files]
ok  	golang.org/x/tools/go/analysis/unitchecker	3.326s
ok  	golang.org/x/tools/go/ast/astutil	3.750s
ok  	golang.org/x/tools/go/ast/inspector	1.801s
ok  	golang.org/x/tools/go/buildutil	0.643s
?   	golang.org/x/tools/go/callgraph	[no test files]
?   	golang.org/x/tools/go/callgraph/cha	[no test files]
?   	golang.org/x/tools/go/callgraph/rta	[no test files]
ok  	golang.org/x/tools/go/callgraph/static	0.544s
ok  	golang.org/x/tools/go/cfg	0.583s
ok  	golang.org/x/tools/go/expect	0.701s
ok  	golang.org/x/tools/go/gccgoexportdata	0.430s
ok  	golang.org/x/tools/go/gcexportdata	0.701s
?   	golang.org/x/tools/go/internal/cgo	[no test files]
ok  	golang.org/x/tools/go/internal/gccgoimporter	0.930s
ok  	golang.org/x/tools/go/internal/gcimporter	1.409s
?   	golang.org/x/tools/go/internal/packagesdriver	[no test files]
ok  	golang.org/x/tools/go/loader	0.607s
ok  	golang.org/x/tools/go/packages	70.485s
?   	golang.org/x/tools/go/packages/gopackages	[no test files]
ok  	golang.org/x/tools/go/packages/packagestest	70.823s
ok  	golang.org/x/tools/go/pointer	74.147s
ok  	golang.org/x/tools/go/ssa	77.424s
ok  	golang.org/x/tools/go/ssa/interp	8.784s
ok  	golang.org/x/tools/go/ssa/ssautil	11.339s
ok  	golang.org/x/tools/go/types/objectpath	7.256s
ok  	golang.org/x/tools/go/types/typeutil	4.785s
ok  	golang.org/x/tools/go/vcs	4.191s
ok  	golang.org/x/tools/godoc	2.465s
?   	golang.org/x/tools/godoc/analysis	[no test files]
?   	golang.org/x/tools/godoc/golangorgenv	[no test files]
ok  	golang.org/x/tools/godoc/redirect	1.097s
ok  	golang.org/x/tools/godoc/static	3.500s
?   	golang.org/x/tools/godoc/util	[no test files]
ok  	golang.org/x/tools/godoc/vfs	3.538s
ok  	golang.org/x/tools/godoc/vfs/gatefs	2.501s
?   	golang.org/x/tools/godoc/vfs/httpfs	[no test files]
ok  	golang.org/x/tools/godoc/vfs/mapfs	1.256s
ok  	golang.org/x/tools/godoc/vfs/zipfs	0.590s
?   	golang.org/x/tools/imports	[no test files]
ok  	golang.org/x/tools/internal/apidiff	2.642s
ok  	golang.org/x/tools/internal/fastwalk	0.427s
ok  	golang.org/x/tools/internal/gopathwalk	2.566s
ok  	golang.org/x/tools/internal/imports	31.171s
ok  	golang.org/x/tools/internal/jsonrpc2	2.255s
ok  	golang.org/x/tools/internal/lsp	47.883s
?   	golang.org/x/tools/internal/lsp/browser	[no test files]
?   	golang.org/x/tools/internal/lsp/cache	[no test files]
ok  	golang.org/x/tools/internal/lsp/cmd	54.963s
?   	golang.org/x/tools/internal/lsp/debug	[no test files]
ok  	golang.org/x/tools/internal/lsp/diff	29.304s
?   	golang.org/x/tools/internal/lsp/diff/difftest	[no test files]
ok  	golang.org/x/tools/internal/lsp/diff/myers	27.005s
ok  	golang.org/x/tools/internal/lsp/fuzzy	27.338s
?   	golang.org/x/tools/internal/lsp/protocol	[no test files]
ok  	golang.org/x/tools/internal/lsp/snippet	8.860s
ok  	golang.org/x/tools/internal/lsp/source	19.070s
?   	golang.org/x/tools/internal/lsp/telemetry	[no test files]
?   	golang.org/x/tools/internal/lsp/tests	[no test files]
ok  	golang.org/x/tools/internal/memoize	1.701s
ok  	golang.org/x/tools/internal/module	0.454s
ok  	golang.org/x/tools/internal/semver	0.529s
ok  	golang.org/x/tools/internal/span	0.430s
?   	golang.org/x/tools/internal/telemetry	[no test files]
?   	golang.org/x/tools/internal/telemetry/export	[no test files]
ok  	golang.org/x/tools/internal/telemetry/export/ocagent	18.722s
?   	golang.org/x/tools/internal/telemetry/export/ocagent/wire	[no test files]
?   	golang.org/x/tools/internal/telemetry/export/prometheus	[no test files]
?   	golang.org/x/tools/internal/telemetry/log	[no test files]
?   	golang.org/x/tools/internal/telemetry/metric	[no test files]
?   	golang.org/x/tools/internal/telemetry/stats	[no test files]
?   	golang.org/x/tools/internal/telemetry/tag	[no test files]
?   	golang.org/x/tools/internal/telemetry/trace	[no test files]
?   	golang.org/x/tools/internal/telemetry/unit	[no test files]
?   	golang.org/x/tools/internal/testenv	[no test files]
?   	golang.org/x/tools/internal/tool	[no test files]
ok  	golang.org/x/tools/internal/txtar	18.582s
?   	golang.org/x/tools/internal/xcontext	[no test files]
?   	golang.org/x/tools/playground	[no test files]
ok  	golang.org/x/tools/playground/socket	18.433s
ok  	golang.org/x/tools/present	0.281s
?   	golang.org/x/tools/refactor/eg	[no test files]
?   	golang.org/x/tools/refactor/importgraph	[no test files]
ok  	golang.org/x/tools/refactor/rename	0.255s
?   	golang.org/x/tools/refactor/satisfy	[no test files]

Notably, in the "linux-amd64 (Go 1.12.x)" build where tests ran in GOPATH mode, the x/tools/gopls directory was skipped as expected according to the rule encoded in ShouldTestPackageInGOPATHMode of CL 194397.

I'll also watch the post-submit builders to make sure nothing unexpected happens there.

gopherbot pushed a commit to golang/build that referenced this issue Sep 11, 2019
cmd/coordinator: detect current build mode in subrepo tests
It will be necessary to know whether the current environment
and configuration has resulted in module mode or GOPATH mode
being selected. Do this dynamically by invoking 'go env GOMOD',
since the outcome depends on the version of Go and its default
GO111MODULE behavior, as well as whether a go.mod file is added
to the subrepo, and what environment overrides were applied by
coordinator via the BuildConfig.ModulesEnv method.

This requires the repository being tested to be available on disk,
so move the step of fetching it to happen earlier.

For now, this change only detects and logs the build mode.
Future changes will use this information further.

Updates golang/go#34190
Updates golang/go#32528
Updates golang/go#30233

Change-Id: I641becaaae5b6cfad22961d8864a877241e61cd3
Reviewed-on: https://go-review.googlesource.com/c/build/+/194277
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Andrew Bonventre <andybons@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Reviewed-by: Alexander Rakoczy <alex@golang.org>
@dmitshur

This comment has been minimized.

Copy link
Member Author

commented Sep 11, 2019

There was a minor issue affecting the "build", "oauth2", "website", and "perf" repos being misdetected as being tested in GOPATH mode, while in reality they're always tested in module mode. It was fixed in Patch Set 8 of CL 194277. I've verified that the fix is working as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.