x/tools/gopls: gopls ignores the fact that the client doesn't support hierarchicalDocumentSymbolSupport #34893
Labels
Milestone
Comments
Claimed! :-) |
ysz
added a commit
to ysz/tools
that referenced
this issue
Oct 17, 2019
Return empty flat list of all symbols if client does not support hierarchical document symbols
ysz
added a commit
to ysz/tools
that referenced
this issue
Oct 17, 2019
Return SymbolInformation[] list if client does not support hierarchical document symbols https://microsoft.github.io/language-server-protocol/specifications/specification-3-14/#textDocument_documentSymbol Fixes golang/go#34893
ysz
added a commit
to ysz/tools
that referenced
this issue
Oct 17, 2019
Return flat list of symbols if client does not support hierarchical document symbols https://microsoft.github.io/language-server-protocol/specifications/specification-3-14/#textDocument_documentSymbol Fixes golang/go#34893
ysz
added a commit
to ysz/tools
that referenced
this issue
Oct 17, 2019
Change https://golang.org/cl/221823 mentions this issue: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What version of Go are you using (
go version
)?Does this issue reproduce with the latest release?
Yes.
What operating system and processor architecture are you using (
go env
)?go env
OutputWhat did you do?
eglot
LSP clientM-x eglot
. At this point eglot notifies gopls for its capabilities as a client. Note that it doesn't reporthierarchicalDocumentSymbolSupport
as supported.M-x imenu
which causes the following communication, note that gopls replies with a hierarchical document symbol response.What did you expect to see?
The list of symbols in the main.go file, i.e. the
main()
function.What did you see instead?
Emacs error.
Notes
textDocument/documentSymbol
joaotavora/eglot#303The text was updated successfully, but these errors were encountered: