Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build/buildlet: add context support #35707

Open
bradfitz opened this issue Nov 20, 2019 · 2 comments
Open

x/build/buildlet: add context support #35707

bradfitz opened this issue Nov 20, 2019 · 2 comments
Milestone

Comments

@bradfitz
Copy link
Contributor

@bradfitz bradfitz commented Nov 20, 2019

The build system in general predates the context package.

The coordinator and other pieces have started using contexts over time, but the biggest missing piece right now is the buildlet package.

This is a tracking bug to add context support to the buildlet client.

@gopherbot gopherbot added this to the Unreleased milestone Nov 20, 2019
@gopherbot gopherbot added the Builders label Nov 20, 2019
@gopherbot
Copy link

@gopherbot gopherbot commented Nov 20, 2019

Change https://golang.org/cl/207908 mentions this issue: buildlet: add context argument to Client.Exec

@dmitshur dmitshur added the NeedsFix label Nov 20, 2019
gopherbot pushed a commit to golang/build that referenced this issue Nov 20, 2019
(And update all the callers in the tree.)

Updates golang/go#35707

Change-Id: I504ef73ea4ba7f8028f47a658c1cd519c7b5d986
Reviewed-on: https://go-review.googlesource.com/c/build/+/207908
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
@gopherbot
Copy link

@gopherbot gopherbot commented Nov 20, 2019

Change https://golang.org/cl/208157 mentions this issue: buildlet: add context argument to most of the remaining Client methods

gopherbot pushed a commit to golang/build that referenced this issue Nov 20, 2019
(And update all the callers in the tree.)

Updates golang/go#35707

Change-Id: I54769bbe374f31ae1dd07776b27818db91ce8c70
Reviewed-on: https://go-review.googlesource.com/c/build/+/208157
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.