Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build: add a builder that runs long tests with a gccgo toolchain #35786

Open
jayconrod opened this issue Nov 22, 2019 · 3 comments
Open

x/build: add a builder that runs long tests with a gccgo toolchain #35786

jayconrod opened this issue Nov 22, 2019 · 3 comments

Comments

@jayconrod
Copy link
Contributor

@jayconrod jayconrod commented Nov 22, 2019

From the list at build.golang.org, there don't seem to be any builders running a gccgo toolchain. It would be useful to have one to make sure we don't regress on gccgo support.

For quick reference: gccgo setup instructions

@bcmills
Copy link
Member

@bcmills bcmills commented Nov 18, 2020

This missing build configuration masked a failure in a new test (#42688).

(FYI @golang/release for prioritization.)

@bcmills
Copy link
Member

@bcmills bcmills commented Jan 28, 2021

Another masked failure, apparently since Dec. 9: #43974.

@gopherbot
Copy link

@gopherbot gopherbot commented Jan 28, 2021

Change https://golang.org/cl/287613 mentions this issue: cmd/go: revert TestScript/build_trimpath to use ioutil.ReadFile

gopherbot pushed a commit that referenced this issue Jan 28, 2021
This call was changed to os.ReadFile in CL 266365, but the test also
builds that source file using gccgo if present, and released versions
of gccgo do not yet support ioutil.ReadFile.

Manually tested with gccgo gccgo 10.2.1 (see #35786).

Fixes #43974.
Updates #42026.

Change-Id: Ic4ca0848d3ca324e2ab10fd14ad867f21e0898e3
Reviewed-on: https://go-review.googlesource.com/c/go/+/287613
Trust: Bryan C. Mills <bcmills@google.com>
Run-TryBot: Bryan C. Mills <bcmills@google.com>
Reviewed-by: Jay Conrod <jayconrod@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants