Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/net/http2: TestTransportPingWhenReading fails on Plan 9 #39233

Closed
millerresearch opened this issue May 24, 2020 · 2 comments
Closed

x/net/http2: TestTransportPingWhenReading fails on Plan 9 #39233

millerresearch opened this issue May 24, 2020 · 2 comments

Comments

@millerresearch
Copy link

@millerresearch millerresearch commented May 24, 2020

What version of Go are you using (go version)?

Current master on sub-repo builders.

What operating system and processor architecture are you using (go env)?

Plan 9, affects arm, 386 and amd64.

I think this is a new test, introduced in CL198040

Example logs for each GOARCH:
https://build.golang.org/log/aa9acd550974f473c6fa49e100c751e2d64be3d0
https://build.golang.org/log/ab04d68c8dc68e4192029ce39c1429906413efed
https://build.golang.org/log/8b4eb0a7cda60a1af29c2d2b03396aa51aaa2187

@millerresearch
Copy link
Author

@millerresearch millerresearch commented May 26, 2020

The new test was using (*TCPConn).CloseWrite which doesn't work on Plan 9, because the Plan 9 kernel's tcp/ip implementation doesn't support half-close. See #17906. I'll send a CL with the usual workaround (call (*TCPConn).Close as well).

@gopherbot
Copy link

@gopherbot gopherbot commented May 26, 2020

Change https://golang.org/cl/235217 mentions this issue: x/net/http2: don't rely on TCP CloseWrite in tests on Plan 9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants