Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/link: incorrect GC bitmap when global's type is in another shared object [1.13 backport] #39956

Open
gopherbot opened this issue Jun 30, 2020 · 6 comments

Comments

@gopherbot
Copy link

@gopherbot gopherbot commented Jun 30, 2020

@aclements requested issue #39927 to be considered for backport to the next 1.15 minor release.

@gopherbot, please backport to Go 1.14 and 1.13.

@aclements aclements changed the title cmd/link: incorrect GC bitmap when global's type is in another shared object [1.15 backport] cmd/link: incorrect GC bitmap when global's type is in another shared object [1.13 backport] Jun 30, 2020
@gopherbot gopherbot added this to the Go1.13.13 milestone Jun 30, 2020
@dmitshur
Copy link
Member

@dmitshur dmitshur commented Jul 10, 2020

Backport approved for Go 1.14 (#39955) and 1.13 (this issue) based on the rationale in #39955 (comment).

@dmitshur
Copy link
Member

@dmitshur dmitshur commented Jul 10, 2020

@cherrymui You've sent a 1.14 backport CL for #39955. Are you able to send one for 1.13 (this issue) as well?

@cherrymui
Copy link
Contributor

@cherrymui cherrymui commented Jul 10, 2020

I could do that. But Go 1.13 is EOL soon, right? Probably not needed, then?

@dmitshur
Copy link
Member

@dmitshur dmitshur commented Jul 10, 2020

@cherrymui Yes, 1.13 will become unsupported once 1.15 is released, which should happen next month. However, both 1.14 and 1.13 are supported equally until then (see #34536 for more details), so if this issue is serious to warrant a backport, our backport policy says that it must be applied to both 1.13 and 1.14 (since the bug exists in both versions). If it's okay not to apply it to 1.13, then that means it's okay not to apply it to 1.14 either.

So, the next steps here are to create a backport CL for Go 1.13, or wait for now, or decide that this issue doesn't warrant being backported and users can wait for Go 1.15 to get the fix. Let us know what approach you think is best.

@cherrymui
Copy link
Contributor

@cherrymui cherrymui commented Jul 10, 2020

Okay, I'll make a CL, then. Thanks.

@gopherbot
Copy link
Author

@gopherbot gopherbot commented Jul 10, 2020

Change https://golang.org/cl/241978 mentions this issue: [release-branch.go1.13] cmd/link: fix GC data reading from shared library (attempt 2)

@andybons andybons modified the milestones: Go1.13.13, Go1.13.14, Go1.13.15 Jul 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.